Received: by 10.192.165.148 with SMTP id m20csp1184885imm; Wed, 25 Apr 2018 14:04:42 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+40+YYucJxrwmlufXiDW3UyYOstFg0JAE9Uy4u1vNLJK87xN9OoKk3E3GIO4ih/IyHw5FJ X-Received: by 10.98.111.137 with SMTP id k131mr26278525pfc.81.1524690282278; Wed, 25 Apr 2018 14:04:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524690282; cv=none; d=google.com; s=arc-20160816; b=gBeSM4I0giZWc+Bteg7W/7cDIhy3jLXG0mIvd8rVgmqMbUJwWeSpsjeNweviTmrL60 8R1RontwlohZu509OaQrkJfIbg7NLEQnrpwYE1hhBXe1Y0lMLvueaNwWj+0MY3k5lA8W GfvjvfXZzelyn4yW8vZYbbDykmheNHGM+ZSLGB1XVJdksXjhie87GJcDAqZx51G+YOhr SRPR/5yZAPAVILm0qfynjrlVcbQJKUtKLU3z2X+virJXjyPtsnKmbQd7tNv+D22jITWw eYNV4OIF25DnpM0AZ4CpypnQvhC6C9mg0+xOcC2DLTQB0rzceSIAfzhz63kM9fA+8+cD AytA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:spamdiagnosticmetadata :spamdiagnosticoutput:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature:arc-authentication-results; bh=pK2uhcreY98DKfT9YrtvEzSAUHccnx9OGVtfpPED0BA=; b=wsFvWFjfroqoePtR6qkVB/vVu+9MJZweQOL3WR8ydAKcsJXs18Nmp8n3wdw5PgCqZ4 3elX2M4lSphuc9YtocHo4tCTk2P3MCk9IJctQTX9nFsviaGgkncfFDxoik0OWdGa1kO0 nfPF+ED3K3LuIZHTsG4wJMVaIQ+nmPJjg+0/+V5HMDKPbpn5EOIEE8muIPTX6KoBQxFw DNBk4bKcd5/SNT0qY+5UVaihvwwkVmZz3lTPCPRHfCxM2wVADU0vw8Zp9PmH+12u1vT9 jwiRrHoaAMxUroXTSQ5Autw98lTTchN0Cs140mDfGUbObQNQhBSKowJAEa2USON6IapY 4ikg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=GtSWcDG8; dkim=fail header.i=@fb.onmicrosoft.com header.s=selector1-fb-com header.b=GBLgVvvP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p10si14285707pgn.330.2018.04.25.14.04.04; Wed, 25 Apr 2018 14:04:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=GtSWcDG8; dkim=fail header.i=@fb.onmicrosoft.com header.s=selector1-fb-com header.b=GBLgVvvP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751655AbeDYVCy (ORCPT + 99 others); Wed, 25 Apr 2018 17:02:54 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:47502 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751410AbeDYVCu (ORCPT ); Wed, 25 Apr 2018 17:02:50 -0400 Received: from pps.filterd (m0001255.ppops.net [127.0.0.1]) by mx0b-00082601.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3PL2JHT009221; Wed, 25 Apr 2018 14:02:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=facebook; bh=pK2uhcreY98DKfT9YrtvEzSAUHccnx9OGVtfpPED0BA=; b=GtSWcDG8ZyY8aHDrmgf/zsMR9kqSX1NVZEjMf263PFOqzOQVJPCqJqSP8Dof+3vWBLwk dBywssVQfpY2wIqJGU/VQH6Vec7mWCg+kyx9kWaM6W7cd21eLTj74hduNI4zLvG/Yvuh LbOxIUM6kQ9rhsQFyFlUNCt1eDmYKAPnJas= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0b-00082601.pphosted.com with ESMTP id 2hjva6h01g-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 25 Apr 2018 14:02:19 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.21) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 25 Apr 2018 14:02:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pK2uhcreY98DKfT9YrtvEzSAUHccnx9OGVtfpPED0BA=; b=GBLgVvvPo1oRd7aHvuH9e6COeeTCLxR3FVYwUqWxp/pMKVG1SE0JFJYu/LAFYQS589Dk85EuL86UWyMQONCO3dUgyZ061JDZRO10y1xxBOnubBYtuATTgnyoM3Rmuk0jBGti0qDCPV64DkqJYOw/Ni4r9ggnbXLRzbmHNjM6nA8= Received: from castle (2620:10d:c092:180::1:aea8) by CO1PR15MB1077.namprd15.prod.outlook.com (2a01:111:e400:7b66::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.13; Wed, 25 Apr 2018 21:02:01 +0000 Date: Wed, 25 Apr 2018 22:01:49 +0100 From: Roman Gushchin To: David Rientjes CC: , , , , Vlastimil Babka , Matthew Wilcox , Andrew Morton , Alexander Viro , Michal Hocko , Johannes Weiner Subject: Re: [PATCH] mm: don't show nr_indirectly_reclaimable in /proc/vmstat Message-ID: <20180425210143.GA10277@castle> References: <20180425191422.9159-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [2620:10d:c092:180::1:aea8] X-ClientProxiedBy: DB3PR0202CA0014.eurprd02.prod.outlook.com (2603:10a6:8:1::27) To CO1PR15MB1077.namprd15.prod.outlook.com (2a01:111:e400:7b66::7) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:CO1PR15MB1077; X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1077;3:OhGbEzMtFUn4fRk6G2F6f4n2H3g9esywcJuCcep22Hf50OM9p3e/9noCFXKt4cYA48r8DeRoVxNu+ZpSbtvJFBmZPCOKrW5Iod4QQzyt3sGdCCqNwgISExWeDF0D26mtVCuAQtU+nJNKQCFd41vmqJQHMgvviSssfnKAj3rWjwCZgbgGkVsnYUzRzr5Wbh17jpk4IxG15r2FzdPVqgyrTK0cVL/dGvrSFDupX+hfERIlcGoQuUM6aqfqmVX64Gyg;25:BLn1Cjqcs5hrUSf2cEiMZDgkO3rnuIJqBeopEXxgEBdnsG3nJvT+GvTvLPdtHGDtiB9nUuBmGnstsX4Hqjejw9XZ4wANB0fdgM02zWhiwIy/DfcVYkHj+W6v/4BrChmmQCoUCX0vH0awHdrucaNRzVMCG3u1uUuDGNtw8ohZC4X2J8f3B+MCSzNDVh1EoO5Q+87rhjwpBqZliQzJ+3YzoESEHTNkYUIBBP0RpsNDOQYRBHMPgXRVPgTD2b0Yk+XcAuzggFnJwfo1SBjZQN+LnBjuQBMshe8XgcMybiuMxtX7PZKVkFDmrmwcvJrQxEFLPAupwwYdV0OzKsE1btoqkw==;31:u95sy8s9b7h2/NNJvYZLZPoReMe/X3PSxs+0n3+PBgTanRTY9ZEvYwGbvq7zcjWsBHD4X+A1p94BAE5usUpzCDZsnEBct6u2v0iE1K2uKRD/hHFaKtGu80ZiLIhES1ODLCBgptKMHPRM6fYzms1Q0Q/9oB5maMYTOFzcXqZvmNenhOO1o6PxlcT0ymVaN3AzzxX+M1tAeUYmmnW9LzPzT4WgEyfKXjJOnTlIGDA4lvM= X-MS-TrafficTypeDiagnostic: CO1PR15MB1077: X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1077;20:dpNZpRy11gVPErvoVTxQINJ07pY+n/OYWp12/Wu2++R2r8oKz8wPmW2tJtjsKDJPhGJgSJSB9JD7WHT8lYRBNFDdWKbgVkmf9Su0kvKPwp5DnSIOZnCzyu2W/7y8K633h8bxosc8NT5KAP6o+6C/0cruuyzWOY5v62gU1xOHPnkrCubMlSx7fp5YiaS/3Inr9yvtjhkoDfSGdt7YCWzRHOsZ8CED8RFrQkVycvJ9gnyqB4vpW7NLNkoh/LW0q5iyZP62liJ57Fss7CHhpkkx8JN3OC8yPDQiEcRnkIIB7nZzw0etPLSYV9l2wVM7yBB5FjtcaIrPGW4O/Kbc/KqBYJ+4dMYY4IuOcUgs8hpwG3aZD1FwrT6CgnB8rxDeMHrGMXbpLtfcorJKGwrfSG3z5d5GA5gg0gax7H1+3vRjAuq2gMya7ZP9ftMchZtSYv8JFhcB5nW9DX1V2l1fYtUkFaK8o0RYhy60pkyukGrvMHg0Bv1fVR772F1d0alRCggG;4:k84zKI+odS5DWnrRX1NWaxa1/MXfGbYCrRfJW6wcdk2btfG3Hnyuqpu900ruN9NOoddcmALs0avhb/0k6kCxF5hTxBbxMB3MpAt7G8b/kWVP76vzpxlGQObMz2B4bvQzKc6RIUE2mSHEuESi2b3LZf+HRV8XKSrgNZY4znVr3XKcU7RBbRXydU/zXsZjq8fSZUeMeO1laJZsfaNwqx88tFVPzgbxTvEKK5wknQO9CAakOn4DrvUIbKf+AeUqDsZZ+1jW7uBu+Z0aKHUpYJ3JRw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231232)(11241501184)(944501410)(52105095)(93006095)(93001095)(6041310)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:CO1PR15MB1077;BCL:0;PCL:0;RULEID:;SRVR:CO1PR15MB1077; X-Forefront-PRVS: 06530126A4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(396003)(39860400002)(39380400002)(376002)(366004)(346002)(189003)(199004)(386003)(316002)(486006)(446003)(11346002)(33896004)(478600001)(186003)(16526019)(476003)(9686003)(55016002)(6246003)(86362001)(76176011)(7416002)(4326008)(305945005)(5660300001)(25786009)(53936002)(16586007)(58126008)(46003)(54906003)(33716001)(50466002)(68736007)(6666003)(97736004)(6916009)(229853002)(23726003)(6116002)(6496006)(1076002)(106356001)(105586002)(47776003)(81166006)(81156014)(7736002)(33656002)(8936002)(8676002)(52396003)(52116002)(2906002)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR15MB1077;H:castle;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:3;A:1; Received-SPF: None (protection.outlook.com: fb.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO1PR15MB1077;23:JKc6NywPaCOWY8Cf7lAsV+VJViQ8ebaSpfttV+V5f?= =?us-ascii?Q?vkKqFBdCKKaFyIGxZ45U9jXm9N5T/1qwpZHdMdsI+cuiNs2DI382haqvMnpj?= =?us-ascii?Q?YQpP1q3o6TXyTKChqD17yZNnAwWZIbt2F7cTQ0A6QL9A37igNo9WZfiKGjQK?= =?us-ascii?Q?MTNTfLZJOwa0/dvELX/5RN0NtwKi1MNrEimmRIkjxrelI3N1WWPoqwvHlkwh?= =?us-ascii?Q?4Z8kCiFAyqWVHCG6FIOt6iineh/4ltVoMHDvVbhAhz9wh5+vpfhA6KAPSljM?= =?us-ascii?Q?Y/lOxAK0h5oSgfbxost+eb9Guyeis0bb8H0VXhILZpkooZmk/nUVto4i9CCP?= =?us-ascii?Q?H7OPBHtzOUIOqtYh+Nsi5EHq2Khz7qiL37s32XMeDT1MpgCT7jiYTlG3bsHZ?= =?us-ascii?Q?G8FBt8/gaQ3oRa7olQ38tNthYOGJRqQlw5XH5pI5KrIqdHYa88+phaucsy2V?= =?us-ascii?Q?6IaatFscKYKdiBPKLqs+Q4jSixVUzhaZGrQjWKzVOa09V3HvjvM+8OwOwVx4?= =?us-ascii?Q?uWBo9SdmvV0tP3Lrj/dBUGD66WOnjLAWBvOy8z80pWrtI8dPt1k3crPDqcT0?= =?us-ascii?Q?vi44J7Nmxy4icJgntzOSEEMLteEtBBA1Kd3EcEEi1Xu30CRIPFr/f0EIipAL?= =?us-ascii?Q?UTbM2mv/QkFsnrOl+NZeRiSXfIOCGn8/vYP1jNRf+HtFLWSmFAjSuUx6fWM3?= =?us-ascii?Q?jD4wxHDne4xag97ui3fB0X2L6ILoisTZ6Bl+Qux9QdVXitEbaitbuXWvY16J?= =?us-ascii?Q?ytbu2ZU38Qj/cWwoBXqOaK351WikHFs5bplO18gESUntHzVW7wwZSPwKgROe?= =?us-ascii?Q?mcAlyUA6ghQ0RvNFDzMEeVRxLp+JONJllGh+TKkNC8LOtkxgjCIIPBOnG6qM?= =?us-ascii?Q?XcLqEBRO7gqEBwksa5LNceIyBTKAt8zxSwN+SZHuzgEVfGWGrsGNi4UGNq+1?= =?us-ascii?Q?TQRoIkU2teMZDQzGNL1IePh9569QIHJYpqXe5qg+9f383n/j1G63bhusBvzA?= =?us-ascii?Q?CVETl1O2e8taMN08zpnQ7FaKyY5p0c7ZUy3CalkmGV91uujjpd2DQw7Nb9gM?= =?us-ascii?Q?APUcYpbOExfiAa3yPzaGhYoDdVmJ1IlwjpKMbTETv4pCRoSTyMyYC6qBBbIV?= =?us-ascii?Q?jWfdowZQtRxWzD/otuo//Qep0QpkpL87PWUA/3a84dqopgjHd8tm6XX8VjI4?= =?us-ascii?Q?c4OGr6oCZTJMFGnJfLqc2Fu2UuhWEc81HdVPv4E28SmuR9o6xlGEHZMPKfHf?= =?us-ascii?Q?Z+KSHuXeo79/uyHlLEaqBnU3RLJBre/vwbrXtYwP/eU5RuJ2VnpSBf8EVJhc?= =?us-ascii?B?dz09?= X-Microsoft-Antispam-Message-Info: bG3xDWpe0cYtmXPHQ34JXTtWxqJrPF99kJ7zfzIDa1iRscsLVtnWEOknABoCpME75FdWfC8Y7WhtPVL8EpC/5pzNkD4kR3fypdzm3DjiNXvHBQ9drwxxurZLC+DKcnfuT7RoOa1PaCQbhEl/zXTZSBTPf9JSA+yrfn1nN1wPWwU9cOhQkaY8+HQ5GlWqpB9/ X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1077;6:L77Usb2P9FGczUYZMoORjY+VKnfYLJ0LdVdfLQ6VFvCuJO0IkXgQISlVn6i2OglMjrnrpZgXSJBOm0Ik8WiXYUYgtNJJ6yI3DNFJUKsm1aXxYBxmnO84M+9vLA9W8ihw26vPwG7ZmWwrScqq9eF48wpJs4x4293sUw701HHsv5xv0Tjz4tdH7Axyw1otER+TnqnBleN6YpDSFyMa3ZwHswGOQBEpxYhWkzewCb1zMk5puqlXGn/7J/WweqoplwXpmra/inWygoWP62sqz8xIMknGLB4Mv2RBPSIgko7Ls5/oYxrccHpBUG/8SltohWfQYozL2YM4APHYVrWvUHEsOML0vKkpCG/CMQJ69P2OKXKWYGO9+2fU/CYiFiXVXO5MWoVkUqLU8dGFXuO8SSiNdomsZJc198H3Y4d4lRX+4Q6lZKVBIKBIv3Dse7nGWx9kdYsEJLHydb179e+2UD0GPw==;5:2rQg1AZaAG8bcL5yTYztLUEq/QxTER2OqcZPsQq2ZC0HtZChoxESk5UOzUloJRct3HqJ4UYciFV2qe5wjuM8ZlwyPTyNfiNyGrfqLDCqko/BnWKHZRXBwQT6b+kcEpKPC9zo1x0x36KHAgpCCIqOT5oICPxyfvaslmufu94TUlY=;24:RLnFGuIqN2uK0qx23fSBIsrAfzfo06ft2AGcEz6j0ErKWgFeH6f73Qgc5Q5fNolJ4n9JOFBpljH6qqvZC68mEZ5UrgNfAuPLUUukP2xgFb4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1077;7:sPtCB84jn+288yw2heB+PxsAeaTJjWnmjWbR50kQ5lumLfPL0f6nw9E1JSi/Tjc90yMGQFF9EszqcGioYxZs2LiAUC3esFSi4UH0joXnsVpeV2XiuadPuZkGp/Jd4lZOG1Bg8msRVr8kvo94BS1UkxbRn3YbMEJRrFLisj2s9f9pn0+ScAZ9Uiv0s8Y5V1IoMf8LBiHYFgw+l+U+o+0xmAwFT+OgVEtM4a+4eyQ3ZoU5sWCaFOkijYP/mxR9qbVI;20:cZhfKEj+SopbYqqeUHxgA++nRDkznDcFT/aXkKI+tql9BjsG47UgFFVN/qBwheUvXYJYaCOdDCHb2O1guoODlAfA7Vx03/Q8ZCkr423nnUyvSCeoEQ7IpEk7nEpHQvl5tWtMxd7vfpygPCWLi7WCh/oG0D3B0WIbj1M8Dy7gLHg= X-MS-Office365-Filtering-Correlation-Id: fc8a14a2-d968-45e5-bcd5-08d5aaefcbb6 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2018 21:02:01.0225 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc8a14a2-d968-45e5-bcd5-08d5aaefcbb6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR15MB1077 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-25_06:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 25, 2018 at 12:37:26PM -0700, David Rientjes wrote: > On Wed, 25 Apr 2018, Roman Gushchin wrote: > > > Don't show nr_indirectly_reclaimable in /proc/vmstat, > > because there is no need in exporting this vm counter > > to the userspace, and some changes are expected > > in reclaimable object accounting, which can alter > > this counter. > > > > I don't think it should be a per-node vmstat, in this case. It appears > only to be used for the global context. Shouldn't this be handled like > totalram_pages, total_swap_pages, totalreserve_pages, etc? Hi, David! I don't see any reasons why re-using existing infrastructure for fast vm counters is bad, and why should we re-invent it for this case. Thanks!