Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180425025125.GH6014@localhost>
References: <20180424211111.140374-1-sjg@chromium.org> <20180425025125.GH6014@localhost>
From:   Simon Glass <sjg@chromium.org>
Date:   Wed, 25 Apr 2018 15:17:37 -0600
Message-ID: <CAPnjgZ1ExEQHL8W2+k=+wS98O3CCX25dKngv_PFNvgAKVBD4Hw@mail.gmail.com>
Subject: Re: [PATCH] firmware: dmi: Add access to the SKU ID string
To:     Vinod Koul <vinod.koul@intel.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        C Shapiro <shapiroc@chromium.org>,
        Aaron Durbin <adurbin@chromium.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Alex Hung <alex.hung@canonical.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jean Delvare <jdelvare@suse.com>,
        sayli karnik <karniksayli1995@gmail.com>,
        Sagar Dharia <sdharia@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Vinod,

On 24 April 2018 at 20:51, Vinod Koul <vinod.koul@intel.com> wrote:
> On Tue, Apr 24, 2018 at 03:11:11PM -0600, Simon Glass wrote:
>> This is used in some systems from user space for determining the identity
>> of the device.
>>
>> Expose this as a file so that that user-space tools don't need to read
>> from /sys/firmware/dmi/tables/DMI
>
> sysfs is an ABI and needs to be documented, I don't see that in this patch,
> pls add.

Thanks for taking a look. The only mention of the dmi/id I can find is
in Kconfig:

config DMIID
    bool "Export DMI identification via sysfs to userspace"
    depends on DMI
    default y
help
  Say Y here if you want to query SMBIOS/DMI system identification
  information from userspace through /sys/class/dmi/id/ or if you want
  DMI-based module auto-loading.


Are you suggesting that I create a list of the things in the /id node,
or something else?

Regards,
Simon