Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263556AbTHWJju (ORCPT ); Sat, 23 Aug 2003 05:39:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263583AbTHWJju (ORCPT ); Sat, 23 Aug 2003 05:39:50 -0400 Received: from imf.math.ku.dk ([130.225.103.32]:35304 "EHLO imf.math.ku.dk") by vger.kernel.org with ESMTP id S263787AbTHWJjs (ORCPT ); Sat, 23 Aug 2003 05:39:48 -0400 Date: Sat, 23 Aug 2003 11:39:44 +0200 (CEST) From: Peter Berg Larsen To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, Peter Osterlund , Vojtech Pavlik Subject: Re: [PATCH 2.6] Synaptics: support reconnect keeping the same input device In-Reply-To: <200308230131.57111.dtor_core@ameritech.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 891 Lines: 29 On Sat, 23 Aug 2003, Dmitry Torokhov wrote: > Here is the update to the Synaptics touchpad driver. It is supposed to go > on top of patches form Peter Osterlund site: > + if (SYN_CAP_MULTI_BUTTON_NO(priv->ext_cap)) { > switch (SYN_CAP_MULTI_BUTTON_NO(priv->ext_cap) & ~0x01) { > default: > printk(KERN_ERR "This touchpad reports more than 8 multi-buttons, don't know how to handle.\n"); > case 8: ... > case 6: > case 4: > case 2: > } I think a break is needed after the default case as the documentation says "If nExtBtm is greater than 8 ... nExtbtm should be considered to be invalid and treated as zero." Peter - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/