Received: by 10.192.165.148 with SMTP id m20csp1438902imm; Wed, 25 Apr 2018 19:11:32 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+VQUEcpzlNDq5PWsWaXKxNzFeR9rUMRwVTIEvVqp1EfOAS4P+GtNCyBBqASHbsHKC873vV X-Received: by 2002:a17:902:f24:: with SMTP id 33-v6mr32289114ply.242.1524708692686; Wed, 25 Apr 2018 19:11:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524708692; cv=none; d=google.com; s=arc-20160816; b=QAx8R4HKBGrmKHUfoZaDugahZJiRqea4RgQdq+V4r5yedLkVHx30bDXA+BSifqaPSW B0Fyy7MNRXUfCxsa+BsJbpQsfBR6I0mFL5qls0sGWgy7yBTcd6dLZL2lwPxarYvvNChz +gCqOugNjnTxOSgINISZfsQfar8Z5N34k/ezqjXbN8wHoFO6SB26eU8v2I/sDJlas9PH JpQl6TINV5QGb00knCOHZPKZUQdmTYbZkewxj9EsS3uAhwHUXLMRGO9VWYIFs5OdohGp qC4AqE9NZG/sH6MjhXWMbvO+q5ahngFg5IlITd3eBIxjlv3UtIqMMrOfau/67rD6mjwp +M/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=N8Rko9UEBH5syck8u54BJLoTfhrMUr0NxeV9koA0iEA=; b=FSrZ5Bk/k17QHSxrX9pjbjMAdOlW/9NXcPgJVkAcq5dAQqbUlZgKxaAXBryzGGFiL4 h31pwqJyxVGb29tRV3WmzgqamJXXZxddL+jSjlwzjG/ngG9qn8ksCDMsaCWiwfyRM8L4 5QKwGU02VgktmvZ6cUeyutoy/njs2JAP/iJ+8nkp+lz0ZWK0lwr9OZxQ5rjiKFwH+LoI cZ5c8+lJYKDVv6ENA0pV4YwGSzbR0bB7tMzzl2FVcT4Bq7NpjCOKXkJnnOPWar1Dd9kD uAQxzAt05by9g/AxYPnnnWMvlmUvZrHR2QO+z2n0Uj4WujkXKeHjkjhh4F+DsqTHsMaq THrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ApNds34L; dkim=pass header.i=@codeaurora.org header.s=default header.b=gQrbL4K3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l12si4820488pga.536.2018.04.25.19.11.18; Wed, 25 Apr 2018 19:11:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ApNds34L; dkim=pass header.i=@codeaurora.org header.s=default header.b=gQrbL4K3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754163AbeDZCJ4 (ORCPT + 99 others); Wed, 25 Apr 2018 22:09:56 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44378 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129AbeDZCIn (ORCPT ); Wed, 25 Apr 2018 22:08:43 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7B3F760F78; Thu, 26 Apr 2018 02:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524708522; bh=HtKuGSiXY2zjf0UyR5DCGH6lDh/uNTzl1DeQlQYjx/Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ApNds34LlHZv+hvN+OzoqXxgOWQKbNBObxAbyAE8YGixmMPJwmMLAarm3OZlAh0Iz GTUZVpGsXonDmYubv+HY7mg0uLPdoIEkJuam9qtBQXOmcd2h8bRYKA9Pr+ec0xQYJk +etbjYhCjn+E/0Irjf/C7C87r0u3zIwKyPS5ekKs= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from clew-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: clew@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6FB5D60F78; Thu, 26 Apr 2018 02:08:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524708521; bh=HtKuGSiXY2zjf0UyR5DCGH6lDh/uNTzl1DeQlQYjx/Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gQrbL4K3Gjr9smtZ9NFjEZhVGybRfnZF0ngCNr3fgDPv13ZonpdMa7mtviEQz9mHl l9qllDD3mtCN/OLmkvQR2VU0cSNFYnE0vLyM2Wnm8rKcq/XEfHkrMY+10tlNdFZ2In rLcjRHyLrJMxT3h1Lf3Bep2eyE8sjECIZh5Smhhs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6FB5D60F78 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=clew@codeaurora.org From: Chris Lew To: bjorn.andersson@linaro.org, andy.gross@linaro.org, david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com Cc: aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, clew@codeaurora.org Subject: [PATCH v2 4/6] rpmsg: Guard against null endpoint ops in destroy Date: Wed, 25 Apr 2018 19:07:50 -0700 Message-Id: <1524708472-18263-5-git-send-email-clew@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1524708472-18263-1-git-send-email-clew@codeaurora.org> References: <1524708472-18263-1-git-send-email-clew@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In RPMSG GLINK the chrdev device will allocate an ept as part of the rpdev creation. This device will not register endpoint ops even though it has an allocated ept. Protect against the case where the device is being destroyed. Signed-off-by: Chris Lew --- Changes since v1: - New change drivers/rpmsg/rpmsg_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index 920a02f0462c..7bfe36afccc5 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -88,7 +88,7 @@ struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev, */ void rpmsg_destroy_ept(struct rpmsg_endpoint *ept) { - if (ept) + if (ept && ept->ops) ept->ops->destroy_ept(ept); } EXPORT_SYMBOL(rpmsg_destroy_ept); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project