Received: by 10.192.165.148 with SMTP id m20csp1656477imm; Wed, 25 Apr 2018 23:42:19 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoq2LPOTg0SXdOJeKaee8cr66uXWVw+T5sIwSeVto80lv44PvUx2ySLIj6uiN+3YL8EyVAU X-Received: by 2002:a17:902:d687:: with SMTP id v7-v6mr5034099ply.201.1524724939817; Wed, 25 Apr 2018 23:42:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524724939; cv=none; d=google.com; s=arc-20160816; b=VbJoXobLFlo0jQVQTXsFeKyVjrbh48BiVjWQJ5EHrOSgFwkEFqdNm/5O41bMf3aNED Q0uMPj6SPuTHNXdDtaAgQeVeBD6iRvTsj8wG+YUB1dRk3YgCJTulbnXA18OoY09cvMaI wKwoVw1Us5nvKS65+n7AxeXjUjAFfrzDlPm5KbPKCJP4YNAOq5tbcQozlzuL8Ohr6tDu e0+alPmOHB3KID4u5/4tCwAfOWU1wK/r4CEPs/Jzl57s0Cqvm5UhTMqO1ho62equGuh+ fG+Y5g0A3nbLErHfiW5NDrkwmIyng7+Ko4cSR/up8Vf/6Q1S+/giyubvr6xYWKVRDVI2 7j+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=x0k2WIlFsfMX610QS11KEY5ckVs1Vgm/HJC8y5+vxvg=; b=e//Xx3cnv7MkYEwOOHHAxN1P5kblyb44PVWpvHyzTFnsuRAaimwZ6P5dbh82VCpjGy Y1JIoeYClfTgqecmI7b3XJSDOEgGncGSbvhwNRg81WbMB0M73WuThGYmeRF4MtoEp++d 270HJNunhK5MIri41h76XwPKbcbYaXL68/D3LJys9Gn35naS0019xqUoEzaW2KH3Nq5I 8gK+zaUatcaKickvfutAzcM/Tzx9pI0sv7IG4HIK+PSflUFMKjhz8M/3BScmELxwaSZp +HugSYASEsGZlzpKeXpIwWJJ21VeznV1dge03Yw5qzDL8Ou0v7A68mOSiMz+140zwrb4 CQqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10-v6si18716280pla.127.2018.04.25.23.42.05; Wed, 25 Apr 2018 23:42:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753800AbeDZGlC (ORCPT + 99 others); Thu, 26 Apr 2018 02:41:02 -0400 Received: from verein.lst.de ([213.95.11.211]:40534 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753307AbeDZGk5 (ORCPT ); Thu, 26 Apr 2018 02:40:57 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 9DA2568DA7; Thu, 26 Apr 2018 08:42:39 +0200 (CEST) Date: Thu, 26 Apr 2018 08:42:39 +0200 From: Christoph Hellwig To: Greentime Hu Cc: Christoph Hellwig , linux-arch , Michal Simek , Vincent Chen , linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux , linux-xtensa@linux-xtensa.org, Linux Kernel Mailing List Subject: Re: [PATCH 13/22] nds32: use generic dma_noncoherent_ops Message-ID: <20180426064239.GA13895@lst.de> References: <20180420080313.18796-1-hch@lst.de> <20180420080313.18796-14-hch@lst.de> <20180424191640.GA32495@lst.de> <20180425064055.GA11460@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Can you try this patch ontop of either the new or original one? --- diff --git a/lib/dma-noncoherent.c b/lib/dma-noncoherent.c index f4b8532c20ac..a2c192b3508d 100644 --- a/lib/dma-noncoherent.c +++ b/lib/dma-noncoherent.c @@ -48,7 +48,7 @@ static int dma_noncoherent_map_sg(struct device *dev, struct scatterlist *sgl, return nents; } -#ifdef CONFIG_DMA_NONCOHERENT_SYNC_FOR_CPU +#ifdef CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU static void dma_noncoherent_sync_single_for_cpu(struct device *dev, dma_addr_t addr, size_t size, enum dma_data_direction dir) { @@ -88,7 +88,7 @@ const struct dma_map_ops dma_noncoherent_ops = { .sync_sg_for_device = dma_noncoherent_sync_sg_for_device, .map_page = dma_noncoherent_map_page, .map_sg = dma_noncoherent_map_sg, -#ifdef CONFIG_DMA_NONCOHERENT_SYNC_FOR_CPU +#ifdef CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU .sync_single_for_cpu = dma_noncoherent_sync_single_for_cpu, .sync_sg_for_cpu = dma_noncoherent_sync_sg_for_cpu, .unmap_page = dma_noncoherent_unmap_page,