Received: by 10.192.165.148 with SMTP id m20csp1739519imm; Thu, 26 Apr 2018 01:18:21 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/NKqJojGqtIx8cXtt8JfUTPa7jnTs/aA3Ki52F7jQ7PakBZlkl+FVDdxxR+K1Dd0s3yc/X X-Received: by 2002:a17:902:1025:: with SMTP id b34-v6mr32828593pla.324.1524730701859; Thu, 26 Apr 2018 01:18:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524730701; cv=none; d=google.com; s=arc-20160816; b=oeih6B7+kar0/nIVtQQFtBI7G7OYaDQilSbc7dGdjlonMEUwGZMA3iM452Joz1v7GM Y8VVsPn/xpW64A5iBEWMwYYxb+7+ECZlSmuhXus2mrXfuoZjKqYY0wn1ArmXLmprT2Uo tZqUqBtb+7NNfVsqT5eu5N3ZiDRBrk7xreMzuFJ67xRVzoMEYzviZqo5wsUuIlwT6W3A ep60W/cG54aogo1ii0dntxR+cMEzZyEFCj4Icz0EjiVAe0UaZ/cnQ+AMKfAxhi2JGSJf Yk9ayngFKXAekTsvxPef3h4USg66Wv9kYlhyRaNDrI4e5iuyofwfOKiBzMHGJabqHwGB Xv5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=0Y4IA4uzRXAX9koUdnStyKKQXliINhWJ0dm3mvmvKSE=; b=qKtRPDwjvWHrUu7G1a5xxxhJFzrPla/OBifYdHKYM+Z91tUmFRR19Xi419RDzS7WZK clRkx3L+hs9Nk/W9eqmiwepNQSUvsxWI0+ar3H8V4Cp+Zsoqvp7Yr873+71bAQy3Ew3d DDFk1CEBB86uPo6i+VHWChtmRwoWnnF+Y1BUC4bmb0L093pOpiuFulLSZECZ77Iiz1ye DRcAxkq3MmsYYTHzshgYvTJ29MXRVHXymZ1JViHNQ/X2J+9UzYfFu4VTjl7f7rq6fUHC rw0X7GpRe9Pr4tgNCtWFLQj3221LhOAFTmtNe9gjc0L4xNRH9zH62X2NstewQr90ZxwK 2PbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=g5We+gZO; dkim=pass header.i=@codeaurora.org header.s=default header.b=n5T9OpIM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w65si170099pfa.18.2018.04.26.01.18.07; Thu, 26 Apr 2018 01:18:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=g5We+gZO; dkim=pass header.i=@codeaurora.org header.s=default header.b=n5T9OpIM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754278AbeDZIRA (ORCPT + 99 others); Thu, 26 Apr 2018 04:17:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39814 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753717AbeDZIQy (ORCPT ); Thu, 26 Apr 2018 04:16:54 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id ECEEF60A06; Thu, 26 Apr 2018 08:16:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524730614; bh=fpg7pog6NS/oNnX9TuunGOgcpXjKC5C9RE5oMIrA7lQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=g5We+gZOTTy9dHBzcZ/IvYvCkTXB7P8P/1wlH6ospLN5q3iYeLt9Pu1l2MJElmJI9 9Zlhi4OcbWAzBmTILmDDAIfmfJx+2nA9RcSxb01ccjNlSqMKhWPT2DkyWfUNnfAdZf vbvZP3YmaBcrOuZH2lYxfF+SJ51LESUWYb2KeMtA= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8BACE60390; Thu, 26 Apr 2018 08:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524730613; bh=fpg7pog6NS/oNnX9TuunGOgcpXjKC5C9RE5oMIrA7lQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=n5T9OpIM2hRamUcpQcEJudDhFQLSXFBvxQcEkwIaMHxJk1ew+cRJSoTccvIQz93bq 1ipg+JWPPpGaQ48K58LC6rXt4dzjnTB8suSbEe+ouqYtjab/ZKv1IXEGH7BJshxKI5 II79H8NMuApwsLz0OuFOoxc7/wHkuU1loEBrgzuo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8BACE60390 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Eyal Reizer Cc: linux-wireless@vger.kernel.org, robh@kernel.org, sre@kernel.org, tony@atomide.com, linux-kernel@vger.kernel.org, Eyal Reizer Subject: Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power References: <1524721631-5983-1-git-send-email-eyalr@ti.com> Date: Thu, 26 Apr 2018 11:16:48 +0300 In-Reply-To: <1524721631-5983-1-git-send-email-eyalr@ti.com> (Eyal Reizer's message of "Thu, 26 Apr 2018 08:47:11 +0300") Message-ID: <87po2m7573.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eyal Reizer writes: > pm_runtime handles sdio power on and power off transitions. > An old workaround for trying to control the power explicitly from the > driver was in fact causing failures on suspend/resume as the mmc layer > already power the module on resume. > > In case of resume pm_runtime_get sync returns a positive device's usage > count causing the driver to try an re-initialize an already initialized > device. This was causing sdio bus failure on resume. > > Remove this manual power on/off sequence as it is in-fact not needed. > > Signed-off-by: Eyal Reizer > Acked-by: Tony Lindgren No changelog. https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing No need to resubmit because of this, I guess you just fixed the title and added Tony's Acked-by? -- Kalle Valo