Received: by 10.192.165.148 with SMTP id m20csp1758163imm; Thu, 26 Apr 2018 01:40:29 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/6YvoQLUoOlPKruncgIT/3PbAAoNDN4KErnlZ2QbXTcWO34n33HBQOtTYw/LKlHOkVSBUp X-Received: by 10.98.196.19 with SMTP id y19mr26728614pff.97.1524732029890; Thu, 26 Apr 2018 01:40:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524732029; cv=none; d=google.com; s=arc-20160816; b=y8DGv7/zcErBJ/TopeOpBUTIxKTFoOklUR1y846w30YWdY9SVcowT55MQj/LCzlY1I 7KO0tUzc4JLQUzPSIfVKNIZscBqolR30lnMX2hG/u609sAWl+EGsPW6xrg3r27rfBfRN ianzZRy/I6qlTwb3faII8TJ+ZmP8BPB4IA9Q2PbJ5DuuI8ry8lXqXtiFOuqdA51M0y02 fBJ4cCbwUZSosYLT8TiJQRcR5rLmmAM3iLsxIXq9B5o5aemttn/fcNdCt4sl/XmYaClG GyaWT6dMluH21JgD3T+zOevsdUUMxEqocThGon687oUuhlodeQMi2pLexcjHnWu+UZ25 pB0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=REXOgqFaXiPo7fawGA/sLFXfJie3CLCG3Fzx4REnZvQ=; b=CJBlvkvrToNzpSGOnYAmh6ZNR5Bph/QNZiGh8odf2oDdor7ibbwn5a8DonIe/o4H3G AUqUX4HI4UsljwQh2cUDxOeyaBsGnDi9bxVtXhYbnChIHth6D8IEQanNmuc7ToD3uoCp BveyVWh77nQPwpwkgHRKqWBpORIdOMXfTQaKk7fYh7mGcURvdwlVpT0yf18OA34VOXMj gUukldBXV7hfI5G7Eaf+fDoj6JxkUbbwdUv75Y7GerQ9S3WP8suRtT39w/TEmLyYZf5C 25X5WQG5vbz/qBPnwo2Q4+oAh5RLXQn9fa92l9Ankxm8si1pGZV/7yXF6zP2c8qQbLYT 1pow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=urigtsKM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j28si9954831pfe.337.2018.04.26.01.40.15; Thu, 26 Apr 2018 01:40:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=urigtsKM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754709AbeDZIhr (ORCPT + 99 others); Thu, 26 Apr 2018 04:37:47 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:59175 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753717AbeDZIhn (ORCPT ); Thu, 26 Apr 2018 04:37:43 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id w3Q8bZjE029011; Thu, 26 Apr 2018 03:37:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1524731855; bh=REXOgqFaXiPo7fawGA/sLFXfJie3CLCG3Fzx4REnZvQ=; h=From:To:CC:Subject:Date:References:In-Reply-To; b=urigtsKMx4up/Kve0ZTRPl2l11ceYXM5kETWQkrrFyVYX3HwlZ7F39u/ji+ILIVR3 nF7LV2vhtebuA64rQsUoPIBlzqf88dS8QYQ05Rq0Sk0JdnXCXt8MZHP4VS/iS2VDvm k7eaJWPx4u8DzxDscfrjbaHIo2g4RKz19GfK8j+0= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w3Q8bZnM011423; Thu, 26 Apr 2018 03:37:35 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 26 Apr 2018 03:37:35 -0500 Received: from DFLE103.ent.ti.com ([fe80::7431:ea48:7659:dc14]) by DFLE103.ent.ti.com ([fe80::7431:ea48:7659:dc14%17]) with mapi id 15.01.1466.003; Thu, 26 Apr 2018 03:37:35 -0500 From: "Reizer, Eyal" To: Kalle Valo , Eyal Reizer CC: "linux-wireless@vger.kernel.org" , "robh@kernel.org" , "sre@kernel.org" , "tony@atomide.com" , "linux-kernel@vger.kernel.org" Subject: RE: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power Thread-Topic: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power Thread-Index: AQHT3Tbwi014TSdlKkSYw3lWOlNC+qQSuLfQ Date: Thu, 26 Apr 2018 08:37:35 +0000 Message-ID: <4750eeeedcde47d39cd207a8c21ef802@ti.com> References: <1524721631-5983-1-git-send-email-eyalr@ti.com> <87po2m7573.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87po2m7573.fsf@kamboji.qca.qualcomm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [137.167.25.139] x-exclaimer-md-config: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >=20 > > pm_runtime handles sdio power on and power off transitions. > > An old workaround for trying to control the power explicitly from the > > driver was in fact causing failures on suspend/resume as the mmc layer > > already power the module on resume. > > > > In case of resume pm_runtime_get sync returns a positive device's usage > > count causing the driver to try an re-initialize an already initialized > > device. This was causing sdio bus failure on resume. > > > > Remove this manual power on/off sequence as it is in-fact not needed. > > > > Signed-off-by: Eyal Reizer > > Acked-by: Tony Lindgren >=20 > No changelog. >=20 > https://wireless.wiki.kernel.org/en/developers/documentation/submittingp > atches#changelog_missing >=20 > No need to resubmit because of this, I guess you just fixed the title > and added Tony's Acked-by? Yes, this is correct. No change in the actual patch hence there was no chan= ge=20 Log. Best Regards, Eyal