Received: by 10.192.165.148 with SMTP id m20csp1771959imm; Thu, 26 Apr 2018 01:56:47 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqR9ktTLMioDL2ugqovxvTmgO9MjcPJSpx9HxbwT/EqofeJMrOp4ZIeNy7hqoDIpTqkBa9L X-Received: by 10.101.74.2 with SMTP id s2mr3606904pgq.265.1524733007825; Thu, 26 Apr 2018 01:56:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524733007; cv=none; d=google.com; s=arc-20160816; b=mmPbBHC0dq8M5MPWLFH/NpCK7w3Cam1b5TQORQxUS3P4spTnWw26WgQduiBuDAtJE4 9KltDMQlLPIsAimnxmDs8oFlBYM28FFqczP4HUnenWhW+/yZZRL5vjnXu1Yu3V+0IGa1 M+64AEvozyzE8xDyPLX4nzLPq+79qBu3rsezXQZ64xBbD+QozyQdZRvlpFOqBgai4x9P 5vIhSM9PRiq78TnhTfm9b1la0qXyczjT971d02GkVa9GBh37zweT+Tv6SebvA9kLCnk4 4G0aWaHp0iUqcFqqr1JPZyB0iXDh3qJtU4rpk9tRl4q6GB73V4buGqThmKlsXzHfUaV+ 8djw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=soNOtJTU3RLapthGVgaxgE2rq+eWjefBnIsGZ8fdPIU=; b=Z6eLfvGf8efqcgMvYy6YJBKAECjds+a2UF0a932elCxeRl3u+yvR3ZJ0lWO5jgCOpN kxH7gapqu5JnpvVxIhdkYPxrpnJQMrHDHf10oWRgPhyQnSiynywEG7RdROTulLm/oDve 64yshLesysObl8gD0GGaFcG7d/7GhhtT7rXvwC1HN1jjrId3+Vg7i2x0zR5kIjZXAjx+ DUUOXpFBubpHkWcroxJa1J3gCybIbMnN+uJLBGHV8fP8Kassg+jmGRI526LfiWJscPDH ZIxeLlSVqgJCM346NN2e8/9XrO6wh5HUiKLSayOhR6gKWYxm8Do7vtyaOSDoIvxWEGLa Mwaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XNyT9mzJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e125si17326346pfe.244.2018.04.26.01.56.33; Thu, 26 Apr 2018 01:56:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XNyT9mzJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755084AbeDZIzB (ORCPT + 99 others); Thu, 26 Apr 2018 04:55:01 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:44300 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754740AbeDZIxZ (ORCPT ); Thu, 26 Apr 2018 04:53:25 -0400 Received: by mail-lf0-f65.google.com with SMTP id h197-v6so2141112lfg.11 for ; Thu, 26 Apr 2018 01:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=soNOtJTU3RLapthGVgaxgE2rq+eWjefBnIsGZ8fdPIU=; b=XNyT9mzJnUkGkoFXZutUPqR6OUTdzK7zOJtCsxtOa4FzXYXviyirFT13T/Udc9yQn4 guB3FCR/XQKjsCm3Bex2FGOY08H959IC2f8xPmw+Tq6U4nLaJrFI8eOKZmlnIIe0ONtU 9+mwEATHkJkNqOfN2ZiFRaJ39a2GeuDi+XgJY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=soNOtJTU3RLapthGVgaxgE2rq+eWjefBnIsGZ8fdPIU=; b=aar5WwwQY4ZdXvwbeJUw8fYrSf4CrTmgWk1LU8SMSqK59OnYPPcgiTlGMUeDeg2cjf R7B7WBzVDuiHs5Xhm/pcJl2+E7X9F/WGdOrU2ya3ch7GJ6wP3ht5YIOPCxw+DN4Kmo6X Xrjs3wdwnW1ovJI0u6T5IqjL+K/s1V83ir5eWFhbLCQqI5iLWygNSg0Bl9MUY0W7x/jj dQujPVgCHtCg0hBvGcXX5SbNTPlsYb49kssxxvxdvNg0WdGixu7nJ5pcNNI1lkRD96wy tSBbrSkocFHBbDHjw6lyjIOZmPcZ+KkM9gczSA6vLml35itvw56x2Kp8/5SS13ySBvG+ 5anw== X-Gm-Message-State: ALQs6tDaSrqadD9sjT2W7rv11fIzmGSnMOe1WUOOGges4qIjoQpYlbww IoWIQxF09pw0QttsFiluy+d5odNr7/g= X-Received: by 2002:a19:dd83:: with SMTP id w3-v6mr16829692lfi.82.1524732804044; Thu, 26 Apr 2018 01:53:24 -0700 (PDT) Received: from localhost.localdomain (h-158-174-22-210.NA.cust.bahnhof.se. [158.174.22.210]) by smtp.gmail.com with ESMTPSA id u83-v6sm681097lff.65.2018.04.26.01.53.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Apr 2018 01:53:23 -0700 (PDT) From: Ulf Hansson To: "Rafael J . Wysocki" , Greg Kroah-Hartman , linux-pm@vger.kernel.org Cc: Ulf Hansson , Kevin Hilman , Geert Uytterhoeven , Viresh Kumar , Vincent Guittot , Mark Brown , Vinod Koul , Sanyog Kale , Pierre-Louis Bossart , Wolfram Sang , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/11] amba: Respect all error codes from dev_pm_domain_attach() Date: Thu, 26 Apr 2018 10:53:05 +0200 Message-Id: <1524732790-2234-7-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1524732790-2234-1-git-send-email-ulf.hansson@linaro.org> References: <1524732790-2234-1-git-send-email-ulf.hansson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The limitation of being able to check only for -EPROBE_DEFER from dev_pm_domain_attach() has been removed. Hence let's respect all error codes and bail out accordingly. Cc: Russell King Signed-off-by: Ulf Hansson --- drivers/amba/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 594c228..79fcbff 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -243,7 +243,7 @@ static int amba_probe(struct device *dev) break; ret = dev_pm_domain_attach(dev, true); - if (ret == -EPROBE_DEFER) + if (ret) break; ret = amba_get_enable_pclk(pcdev); @@ -370,7 +370,7 @@ static int amba_device_try_add(struct amba_device *dev, struct resource *parent) } ret = dev_pm_domain_attach(&dev->dev, true); - if (ret == -EPROBE_DEFER) { + if (ret) { iounmap(tmp); goto err_release; } -- 2.7.4