Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180405120012.7671-1-colin.king@canonical.com>
References: <20180405120012.7671-1-colin.king@canonical.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 26 Apr 2018 11:06:05 +0200
Message-ID: <CACRpkdZ2zRJfcSWbi_zwvtMnu_eGqAi684Wh3qWfjMazJqNsUA@mail.gmail.com>
Subject: Re: [PATCH] gpio: 104-dio-48e: make array 'ports' static, shrinks
 object size
To:     Colin King <colin.king@canonical.com>
Cc:     William Breathitt Gray <vilhelm.gray@gmail.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        kernel-janitors@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 5, 2018 at 2:00 PM, Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const read-only array 'ports' on the stack but instead
> make it static. Makes the object code smaller by over 100 buytes:
>
> Before:
>    text    data     bss     dec     hex filename
>   10959    4952     832   16743    4167 drivers/gpio/gpio-104-dio-48e.o
>
> After:
>    text    data     bss     dec     hex filename
>   10790    5008     832   16630    40f6 drivers/gpio/gpio-104-dio-48e.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied with William's ACK.

Yours,
Linus Walleij