Received: by 10.192.165.148 with SMTP id m20csp1842233imm; Thu, 26 Apr 2018 03:07:51 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqfIE5cFZGxoqilpjADjntohaTmo4R/I5m5V0r4Uhx/YLpSO8G8Ru2s5WIeC22k1hxNLqGd X-Received: by 2002:a17:902:bd46:: with SMTP id b6-v6mr4273997plx.170.1524737271197; Thu, 26 Apr 2018 03:07:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524737271; cv=none; d=google.com; s=arc-20160816; b=poqgBfx66AVZltljNPh0Iss3BvV5DQcNRucSTqIIiXDUl4YZAP9PaGhVCgugTVZObY 5BHGTpkqMUC5z6HKqX08WqQWQ8D7wjM0JWxjRjVlcMphpZ3j0PPqtt/rbRcpug4WiwM/ UoQRt5UltQzXw4T6ziXhXn2aHgQE3sifqogF7iNqFp3wHqhZrWjtX2lFHeNLzmaej+9Z Y8zK+nmkjwNz5k/M9U8yYMN4aUf2EphL/9+C358w8rXyTEhrHpjlLnmIgPN0XGttp6e/ HIpA5Y71MEQcK3gLwQMUYbEMhPeht1d9YvVAIEKVc0VvQ2ofrTudDE2PrlZrqWo60etG xyXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=nGna2Moc+HAc2zn/gM+gci895KeWMlc1zdtqcSwXQTU=; b=MWJ7sD/brlBpOWIG8DkzUHN8eEzKWryiOyHArYofXag+t7YpZQGz6b3NdbNsuE/kn7 6EebFIWQsZI16TvdRyXmTMwHZBeVdUtg3ZtBiapPmrkmomAsKEeQp9pnLtpLAFpNOf+N fij1VA/nuXrG7PONk/glnTD3Zcl3x87xCP/zu0wmEdlcNVRVH2q1JljuSi7ZCvpmIyS4 Al/Q2ObtWpvA+3Hoq3FmcNrfgMMe3srspOUC5n8ikOxDz5A1aFQGrgjB8MavyM/HW8/4 jsmDyP8+nSwFslL4mMTkpCJ0Hf1d9CDvzcbrH7+jDpgRdt3QE4CWwHHHgp53i349GEaQ Aj2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1-v6si18619104plb.253.2018.04.26.03.07.37; Thu, 26 Apr 2018 03:07:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754149AbeDZKGZ (ORCPT + 99 others); Thu, 26 Apr 2018 06:06:25 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:50432 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753403AbeDZKGV (ORCPT ); Thu, 26 Apr 2018 06:06:21 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 742A915AD; Thu, 26 Apr 2018 03:06:20 -0700 (PDT) Received: from localhost (unknown [10.37.12.162]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4F023F487; Thu, 26 Apr 2018 03:06:19 -0700 (PDT) Date: Thu, 26 Apr 2018 12:06:15 +0200 From: Christoffer Dall To: Auger Eric Cc: eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, cdall@kernel.org, peter.maydell@linaro.org, andre.przywara@arm.com, drjones@redhat.com, wei@redhat.com Subject: Re: [PATCH v3 07/12] KVM: arm/arm64: Adapt vgic_v3_check_base to multiple rdist regions Message-ID: <20180426100615.GB19872@C02W217FHV2R.local> References: <1523607658-9166-1-git-send-email-eric.auger@redhat.com> <1523607658-9166-8-git-send-email-eric.auger@redhat.com> <20180424210748.GH4533@C02W217FHV2R.local> <557b2aaf-3f6f-ea11-55e2-5667b651922b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <557b2aaf-3f6f-ea11-55e2-5667b651922b@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 26, 2018 at 10:29:35AM +0200, Auger Eric wrote: > Hi Christoffer, > On 04/24/2018 11:07 PM, Christoffer Dall wrote: > > On Fri, Apr 13, 2018 at 10:20:53AM +0200, Eric Auger wrote: > >> We introduce a new helper to check there is no overlap between > >> dist region (if set) and registered rdist regions. This both > >> handles the case of legacy single rdist region (implicitly sized > >> with the number of online vcpus) and the new case of multiple > >> explicitly sized rdist regions. > > > > I don't understand this change, really. Is this just a cleanup, or > > changing some functionality (why?). > > > > I think this could have come with the introduction of > > vgic_v3_rdist_overlap() before patch 6, and then patch 6 could have been > > simplified (hopefully) to just call this "check that nothing in the > > world ever collides withi itself" function. > I have merged this patch and vgic_v3_rd_region_size + > vgic_v3_rdist_overlap and put it before this patch. > > Also I reworked the commit message which was unclear I acknowledge. > > With respect to using the adapted vgic_v3_check_base() in > vgic_v3_insert_redist_region(), it is less obvious to me. > > In vgic_v3_insert_redist_region we do the checks *before* inserting the > new rdist region in the list of redist regions. While > vgic_v3_check_base() does the checks on already registered rdist and > dist regions. So I would be tempted to leave > vgic_v3_insert_redist_region() implementation as it is. > ok, but do see my suggestion there to factor out the check, which should make that function slightly easier to read. Then perhaps you can use that function from vgic_v3_check_base to check that each rdist doesn't overlap with the distributor? Thanks, -Christoffer