Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Reizer, Eyal" <eyalr@ti.com>
To:     Kalle Valo <kvalo@codeaurora.org>
CC:     Eyal Reizer <eyalreizer@gmail.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "robh@kernel.org" <robh@kernel.org>,
        "sre@kernel.org" <sre@kernel.org>,
        "tony@atomide.com" <tony@atomide.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio
 power
Thread-Topic: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio
 power
Thread-Index: AQHT3UCfetw9p/qzd0ix7CJgDFtru6QS1AWQ
Date:   Thu, 26 Apr 2018 10:14:13 +0000
Message-ID: <d6699a26485443bf8a9a798ddca05e6f@ti.com>
References: <1524721631-5983-1-git-send-email-eyalr@ti.com>
        <87po2m7573.fsf@kamboji.qca.qualcomm.com>
        <4750eeeedcde47d39cd207a8c21ef802@ti.com>
 <87lgda71zl.fsf@kamboji.qca.qualcomm.com>
In-Reply-To: <87lgda71zl.fsf@kamboji.qca.qualcomm.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>=20
> >>
> >> > pm_runtime handles sdio power on and power off transitions.
> >> > An old workaround for trying to control the power explicitly from th=
e
> >> > driver was in fact causing failures on suspend/resume as the mmc lay=
er
> >> > already power the module on resume.
> >> >
> >> > In case of resume pm_runtime_get sync returns a positive device's
> usage
> >> > count causing the driver to try an re-initialize an already initiali=
zed
> >> > device. This was causing sdio bus failure on resume.
> >> >
> >> > Remove this manual power on/off sequence as it is in-fact not needed=
.
> >> >
> >> > Signed-off-by: Eyal Reizer <eyalr@ti.com>
> >> > Acked-by: Tony Lindgren <tony@atomide.com>
> >>
> >> No changelog.
> >>
> >>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingp
> >> atches#changelog_missing
> >>
> >> No need to resubmit because of this, I guess you just fixed the title
> >> and added Tony's Acked-by?
> >
> > Yes, this is correct. No change in the actual patch hence there was no
> change
> > Log.
>=20
> _Always_ include a change log, even if you didn't actually change
> anything. Otherwise the maintainer has no clue what has changed and why
> a new version was submitted.
>=20
Understood. Thanks!

BR,
Eyal