Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Y.b. Lu" <yangbo.lu@nxp.com>
To:     Richard Cochran <richardcochran@gmail.com>
CC:     "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
Subject: RE: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware
 timestamping
Thread-Topic: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware
 timestamping
Thread-Index: AQHT3HZv/Y/PznkfA0CVZRkLjjVOL6QSVOYAgACBylA=
Date:   Thu, 26 Apr 2018 10:22:49 +0000
Message-ID: <DB6PR0401MB2536A4E804E84D417AD1398CF88E0@DB6PR0401MB2536.eurprd04.prod.outlook.com>
References: <20180425091749.46841-1-yangbo.lu@nxp.com>
 <20180426023308.aezdge7xlbqoe5at@localhost>
In-Reply-To: <20180426023308.aezdge7xlbqoe5at@localhost>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d8bcbaf1-4eb7-4c68-10fe-08d5ab5fa958
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2018 10:22:49.3532
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2246
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Richard,


> -----Original Message-----
> From: Richard Cochran [mailto:richardcochran@gmail.com]
> Sent: Thursday, April 26, 2018 10:33 AM
> To: Y.b. Lu <yangbo.lu@nxp.com>
> Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Greg
> Kroah-Hartman <gregkh@linuxfoundation.org>; dan.carpenter@oracle.com;
> Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
> Subject: Re: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware
> timestamping
>=20
> On Wed, Apr 25, 2018 at 05:17:49PM +0800, Yangbo Lu wrote:
>=20
> > +/* PTP nominal frequency 1GHz */
> > +#define DPAA2_PTP_NOMINAL_FREQ_PERIOD_NS 1
>=20
> Nit: Frequency is the inverse of the period.  It can be one or the other,=
 not
> both.
>=20
> Why not call it simply DPAA2_PTP_CLK_PERIOD_NS?

[Y.b. Lu] Thanks. Let me use DPAA2_PTP_CLK_PERIOD_NS in next version.

>=20
> You haven't implemented the ethtool_get_ts_info() method, but you need to
> do so.  Show us how the user can related these MAC time stamps to the PHC
> device in your other patch series.

[Y.b. Lu] I will add patch for ethtool_get_ts_info in next version. Thanks!
But I'm not sure whether ethtool should show hw timestamping always ignorin=
g phc enabled or not.
Actually the hw timestamping is supported always since ptp clock had been i=
nitialized in MC firmware.
Let me just send out the patch for reviewing.

>=20
> Thanks,
> Richard