Received: by 10.192.165.148 with SMTP id m20csp2233265imm; Thu, 26 Apr 2018 07:52:30 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqhJPRFPBOh9DEkCcMvMHUQUaEUBvrCKisbm7JCJhK3V7ya9QQF7D0c63bjptjTh2VN/Jua X-Received: by 2002:a17:902:7146:: with SMTP id u6-v6mr3849367plm.289.1524754350725; Thu, 26 Apr 2018 07:52:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524754350; cv=none; d=google.com; s=arc-20160816; b=UifwQxFA6yABq4wHzV0GlNzhzSxalyKPHsngBQ7XjJZ/gqWA7hDaCphgUTtd4pVHuI wqd4ufJmpuJ0MMv5p+z2ySwG1vit5bz+YXHf7ksbwks451hPW8MTVemxE2gPRG1oCdvw ulYqpQTb9jK8Ec4du6oeFaha1Qgv4HDiqPkO/tmZDeYH2uPz9z2tnNOAQrS5NqBQIc1j pALBzzJaqvGrAqt3VIEniaInaTAmPVSzT5fzAtI4wolcOR4yNzeJVjWBCHTbR4DnqYsX MVfsyKydIXA0M8sUxV1QiGpiheJMNFBfUgLaG19H0/sVuJxshNClnrjuZ29g2+NzyMyC mBag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=m7CpeULxUZkSLNZ+t9eMSIUdgUQ89F8fTo3W5b7YsQM=; b=clxrLQSDcsXc2AYJevBBJvOIBFO10MRYFZLd68X+BuU84ttlWZ5yiV2bWMZYuz/qhm zWvxz2+a3S3cx/Fu4wIbXwxvi8HpAeP+0amrvH1ws7kYivPORrHKFVVwZu01t7UqB8W4 tYopkY4SR5TMk8xJoP43wkcv/Vfq3a/exSIJGcj3OZ09pyuCkGPM8Bg9tdQ9uLf5emJV QWmB4ht6Nz0onE0cUnjWwjnl707J7igXArEQdNI9F+v1LlWJ5TiwyMIvGsfplXvIMzo6 /4C7xIUHxV5uFh0kcFmnGUz3N78GwkjSg/aPna/Zl1zODyQZMxbtBwv/1HzQMh30CZJk vmqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=RazsZTd8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j33-v6si19009700pld.395.2018.04.26.07.52.16; Thu, 26 Apr 2018 07:52:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=RazsZTd8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756552AbeDZOvE (ORCPT + 99 others); Thu, 26 Apr 2018 10:51:04 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35817 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756461AbeDZOvA (ORCPT ); Thu, 26 Apr 2018 10:51:00 -0400 Received: by mail-pf0-f196.google.com with SMTP id j5so18576321pfh.2 for ; Thu, 26 Apr 2018 07:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=m7CpeULxUZkSLNZ+t9eMSIUdgUQ89F8fTo3W5b7YsQM=; b=RazsZTd8hefxq8LD9fSPN4/ZVFxXYDduFgTvhwWeKZ+s9JVY2eddTSR7YS2XxLrUkX 6ZVwJrV90L3YTrqNLgtR3C6Z5Z6FpE/3NwI3R7duW1Fq8W2H9tXz3vMhVLARZcCrnvPN dJ0Jy6ME9inS6fDPwak6agrkVYZ115m5NSjOeCz0Eyzb4alL+W5MhquPnwFP6yB3FJoN EIHcz0A4o1TRypkUotWClSWAaQLiZWEoCimQ5bWp7Sc7AxuMPmK/VBG3uffKmcNonwWY ViAMv+rEgxVXqcpFGwH/oUGItKb8xKQvyi48/T048bwgZmebnbQtvn8q3jBaxhzNFJNk 8j7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=m7CpeULxUZkSLNZ+t9eMSIUdgUQ89F8fTo3W5b7YsQM=; b=JwuKMmkHbfu4Bj4bZEWRe7s8jemRtsf9gdtGIMDovQNoYQIBL6hVFhtcuAKSUnSpJk u6xUmPPBcNXMnRx88s+WSzVetI3PV01QE6GSRsfqABslsgKXqA9H8faBS1+8acJlJ/0q Cc9JwvW4UpYVM80HoSebLzGn2tB7sd+WF8gbmjg2i0iBkEHCxOx1l73Ik2iS8x+jHYh8 2bqBuxPboXzgEVUucmVmZnNWDzLTEhjrInt+DQget5xDh9um/oGIWqAkWXQDIUXExENR zxfK5TVwz5XsQlfoUnnBcsUyRj9Zanpd3hyfpppWOGxGIzYqKEiCDpnyjnD6lzHQkLie e5ow== X-Gm-Message-State: ALQs6tChMZ7ZQWT5c0dMzW9qePXPjMJfRpkRWjwrV/XGzu0VcYOBtFSv oxoR3o+Os/sncuK9OWX1djNPWESxlQk= X-Received: by 10.98.189.24 with SMTP id a24mr11244215pff.30.1524754259764; Thu, 26 Apr 2018 07:50:59 -0700 (PDT) Received: from localhost ([2620:15c:2c4:201:f5a:7eca:440a:3ead]) by smtp.gmail.com with ESMTPSA id s4sm20330340pgp.35.2018.04.26.07.50.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Apr 2018 07:50:58 -0700 (PDT) From: Eric Dumazet To: "David S . Miller" Cc: netdev , Andy Lutomirski , linux-kernel , linux-mm , Ka-Cheong Poon , Eric Dumazet , Eric Dumazet Subject: [PATCH v3 net-next 0/2] tcp: mmap: rework zerocopy receive Date: Thu, 26 Apr 2018 07:50:54 -0700 Message-Id: <20180426145056.220325-1-edumazet@google.com> X-Mailer: git-send-email 2.17.0.484.g0c8726318c-goog Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org syzbot reported a lockdep issue caused by tcp mmap() support. I implemented Andy Lutomirski nice suggestions to resolve the issue and increase scalability as well. First patch is adding a new getsockopt() operation and changes mmap() behavior. Second patch changes tcp_mmap reference program. v3: change TCP_ZEROCOPY_RECEIVE to be a getsockopt() option instead of setsockopt(), feedback from Ka-Cheon Poon v2: Added a missing page align of zc->length in tcp_zerocopy_receive() Properly clear zc->recv_skip_hint in case user request was completed. Eric Dumazet (2): tcp: add TCP_ZEROCOPY_RECEIVE support for zerocopy receive selftests: net: tcp_mmap must use TCP_ZEROCOPY_RECEIVE include/uapi/linux/tcp.h | 8 ++ net/ipv4/tcp.c | 192 +++++++++++++------------ tools/testing/selftests/net/tcp_mmap.c | 64 +++++---- 3 files changed, 146 insertions(+), 118 deletions(-) -- 2.17.0.484.g0c8726318c-goog