Received: by 10.192.165.148 with SMTP id m20csp2409845imm; Thu, 26 Apr 2018 10:28:59 -0700 (PDT) X-Google-Smtp-Source: AB8JxZru+W01pr2HpzHs+dlPKDWq5MuMsfuYDypry4LNSTg7ILMCz4m+/iNPyZ9JbNUsb7wwi+Q7 X-Received: by 2002:a17:902:9344:: with SMTP id g4-v6mr3846855plp.10.1524763739156; Thu, 26 Apr 2018 10:28:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524763739; cv=none; d=google.com; s=arc-20160816; b=HphI2SFXWFpoRfxAuO63Ju9VJu7/5f2X5PSQDQ/GnL+Q47BhT5B2hAgNe9BAWnY3k8 tt1oh6SFyZlDtC2WtRmJikxscpu23zK9OSKMrXLq8v7cZeX5MWjfTITVdtZrPkc707Jf vqqmrIAiRj+9mE5YdaA2WQ4iaDwjPpLAmYQFt0E1o4BR0GLAEZau2bjlV+/UZK4hlPD1 qQ/oI7KdrhdmgDd/AuFb9mATBYc9UJjXJJzpxk4Bu4EJk/6YI0z6Pj+1eluwoFJkPk7K 41BuhdU6FLxzezH/llK5HuAOCW7UNfvzJiZLKq5zGwHM1eh89ElKL+/NhylO5JhTH56i BOEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=xX6+jDSWU7IZneTfmwxAIyV9iHorWAoGLV8n8jqtl0I=; b=S/lRY8QIy1Ap+8hayFKIm+2XNmsptlP1UQuPnTJJvRgnqk/GcFe1q/psP6ifSs4VAB tn4UYc2x8RCbxLFpl/tH2sueWUfzbyV1CKxWQ5NcZKB8brrVuhqLTjCeDDu/vXfBOXSq ORqvaHO6abh3ZkjZwflbsgMsLNefPUSSRCWUEiWsOjiDFQfLM2R5rmuWfpRlwBXx/iFC zZr9OosUJY+A+LAcTG2+77usbesswBNbQ/N3q06rNZwsWCr8HZrJDp1PYH4AGlRzrlwj zjbbvcW2KEc4RqggFg/ymVo0DCGs+NWuvzWX5/l20VetRUJ7GmLeJ+U67gynKbbhGH/o U1cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L0sVre6b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 79si16118070pga.440.2018.04.26.10.28.44; Thu, 26 Apr 2018 10:28:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L0sVre6b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756850AbeDZR1d (ORCPT + 99 others); Thu, 26 Apr 2018 13:27:33 -0400 Received: from mail-ua0-f194.google.com ([209.85.217.194]:43589 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756715AbeDZR13 (ORCPT ); Thu, 26 Apr 2018 13:27:29 -0400 Received: by mail-ua0-f194.google.com with SMTP id s15so17768779uae.10; Thu, 26 Apr 2018 10:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xX6+jDSWU7IZneTfmwxAIyV9iHorWAoGLV8n8jqtl0I=; b=L0sVre6bfdN035BcBmmq5sPmnB+gbGJyS7OtcES4KsflrrXYZ22nz5C8hAs9A/CHzK z8kjQDz7FD6Tr++OHrqHtZddo+szLGUuOsOGN/aS7QRe6MMyxclHJBuFcsQXs6EJNKTp O9+XQnIVrQdPDYZxD9dPYfP8aHcPus0CkoHONbHC/VhK5R+hfQZyyoHlwUQTCBkj8LUd 80Qokkz869COK/Puq1o9Uly3Z/t18+cx/66FmYffO6M7XS4NCQMcFpKuvkwJdukD4ZsZ uOLFirjjkQPGDTe/0ULZnHnS0M2mmQMVTLusEVhkDrPftTlmY/wjlUO780N4ZmT5BJuE uqiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xX6+jDSWU7IZneTfmwxAIyV9iHorWAoGLV8n8jqtl0I=; b=s3cT+wONaINJ+JrAEdHcDMg5zHa/dPzw81LjRgIvtXfuB4QC7/bnrWFgL8dt2FZSqa sRgcddrKnHc/1jrDocvcWyVlChT0beze2q6ZIkWIcaYsi3Lx+6JrQI1LmX78jqUFaRFm ENitORyzWfiW+iMhIHdSSmUTpXnJjgUkymcixEEFvJYoXysvrwr/KvU7icp/cF3KobRj 7XFTHvdXxqUcyPFHtigRTNJj0JwZX3rkxeFczhH9/MpB/h7SYzxYEXcPYteC4Y5z/N6p /RVsxYaKp5eZzRC0Yjidd9DEAFazQ8EnNzA6PWyyZroUw5JOwtEbIFMaBYRsuynN+D8y jw7A== X-Gm-Message-State: ALQs6tA2QTeRZMYZs35Dxkc2AesO60Bf8UIPHe51aZqnbDa9NvTma/c5 Va5V3GTZ5THKXT6iW+ehAU/ORnvN9HdouoLER9Ph6Q== X-Received: by 10.159.59.6 with SMTP id i6mr25571507uah.169.1524763648702; Thu, 26 Apr 2018 10:27:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.3.129 with HTTP; Thu, 26 Apr 2018 10:27:07 -0700 (PDT) In-Reply-To: <20180420165143.mwcxwkf6j7ddckdt@gondor.apana.org.au> References: <1523282087-22128-1-git-send-email-s.mesoraca16@gmail.com> <20180420165143.mwcxwkf6j7ddckdt@gondor.apana.org.au> From: Salvatore Mesoraca Date: Thu, 26 Apr 2018 19:27:07 +0200 Message-ID: Subject: Re: [PATCH v2 0/2] crypto: removing various VLAs To: Herbert Xu Cc: linux-kernel@vger.kernel.org, Kernel Hardening , linux-crypto@vger.kernel.org, "David S. Miller" , Kees Cook , Eric Biggers , Laura Abbott Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-04-20 18:51 GMT+02:00 Herbert Xu : > On Mon, Apr 09, 2018 at 03:54:45PM +0200, Salvatore Mesoraca wrote: >> v2: >> As suggested by Herbert Xu, the blocksize and alignmask checks >> have been moved to crypto_check_alg. >> So, now, all the other separate checks are not necessary. >> Also, the defines have been moved to include/crypto/algapi.h. >> >> v1: >> As suggested by Laura Abbott[1], I'm resending my patch with >> MAX_BLOCKSIZE and MAX_ALIGNMASK defined in an header, so they >> can be used in other places. >> I took this opportunity to deal with some other VLAs not >> handled in the old patch. >> >> [1] http://lkml.kernel.org/r/4e536889-439a-49e6-dd95-2d4286913202@redhat.com >> >> Salvatore Mesoraca (2): >> crypto: api - laying defines and checks for statically allocated >> buffers >> crypto: remove several VLAs >> >> crypto/algapi.c | 10 ++++++++++ >> crypto/cfb.c | 7 +++---- >> crypto/cipher.c | 3 ++- >> crypto/ctr.c | 4 ++-- >> crypto/cts.c | 5 +++-- >> crypto/pcbc.c | 5 +++-- >> include/crypto/algapi.h | 8 ++++++++ >> 7 files changed, 31 insertions(+), 11 deletions(-) > > All applied. Thanks. Thank you very much. Salvatore