Received: by 10.192.165.148 with SMTP id m20csp2587914imm; Thu, 26 Apr 2018 13:40:59 -0700 (PDT) X-Google-Smtp-Source: AIpwx48pVFMI7iBYfI1tsADeWjvY3YBoZLNGEhyW+7R/Cy1siMAa8xVfbWw7ypMmIe2nRGwugc1d X-Received: by 10.99.97.8 with SMTP id v8mr28712251pgb.245.1524775259216; Thu, 26 Apr 2018 13:40:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524775259; cv=none; d=google.com; s=arc-20160816; b=p1bN5yNpnORd+XASCqeIBLjvAuAKwlh3w6gR58wLcp7x/mFJ3wmFq9pgcoUfN+3Hlh bMi1yXnrUdYTku/SdzIfd+BRErbrrJSkidgBkQuum3GUV1MGYu9wcY4kbiS+TgMKlDW2 ROABbC4bO6TPTEoaBt2sGTsZoEMyOnhQ32gyrCfp/NbejqWSFk1eQ13RzEkkL+1MgiCM jYucmyJ2l9poYz1cD1sdAy0Il+sj4suC1bGV8+fN547NYlqhL5376SRtl9EvT6jGpu7B AbmFAlwFBlLUbQ7q5j+E0tYh+fYXmFSkYG8g2GqT3dY2FjUXedIt2nQWOJHZVtmByCam XhwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=agVjj/YRM8QrtC/XYlXr4aIktPG4zGn3xQcd+au5UT4=; b=eQcleIXTrlWXgQO8/rM1bCiZcQS99zj6ITz69kH4PXfQN8fgJqMqSwcUZ7K9byDLT6 OsLEH4lxz8xzLP9gVSx0TgW0Boko9rhQP+fYJLeVtGDSVE10bUp+gFlAgXE/C7KD/dIW CXjlRlHXLP4aY59zz9q+hFzxdXqpyupIFk1/9p4tO4SD3VPkZ5o0/NSbr4Kz3KMjckJ2 Hlx4hJ4u1Ag4S4fHV0/XNT+vL1wYsVap6FY+JvgAgSH0gKC79pN6plKRhbhocwJJVFrf FZOtbJn1heauqnzkz9gzTe9OWEVsyrAMouOGANFJtb7Y0M5eKxDSRPaknH397tpq04F2 aqLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c7-v6si309042plr.145.2018.04.26.13.40.45; Thu, 26 Apr 2018 13:40:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754712AbeDZUjp (ORCPT + 99 others); Thu, 26 Apr 2018 16:39:45 -0400 Received: from mga07.intel.com ([134.134.136.100]:23928 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753393AbeDZUjo (ORCPT ); Thu, 26 Apr 2018 16:39:44 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2018 13:39:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,332,1520924400"; d="scan'208";a="50260727" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by fmsmga001.fm.intel.com with ESMTP; 26 Apr 2018 13:39:43 -0700 Date: Thu, 26 Apr 2018 14:41:04 -0600 From: Keith Busch To: Johannes Thumshirn Cc: Linux NVMe Mailinglist , Linux Kernel Mailinglist , Christoph Hellwig , Sagi Grimberg Subject: Re: [PATCH v2] nvme: change order of qid and cmdid in completion trace Message-ID: <20180426204104.GA3094@localhost.localdomain> References: <20180426202515.20206-1-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180426202515.20206-1-jthumshirn@suse.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 26, 2018 at 02:25:15PM -0600, Johannes Thumshirn wrote: > Keith reported that command submission and command completion > tracepoints have the order of the cmdid and qid fields swapped. > > While it isn't easily possible to change the command submission > tracepoint, as there is a regression test parsing it in blktests we > can swap the command completion tracepoint to have the fields aligned. It's the little things that matter. :) Thanks, applied to nvme-4.18.