Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Dexuan Cui <decui@microsoft.com>
To:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        KY Srinivasan <kys@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "driverdev-devel@linuxdriverproject.org" 
        <driverdev-devel@linuxdriverproject.org>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        "apw@canonical.com" <apw@canonical.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "marcelo.cerri@canonical.com" <marcelo.cerri@canonical.com>
Subject: [PATCH] Drivers: hv: vmbus: Fix the offer_in_progress in
 vmbus_process_offer()
Thread-Topic: [PATCH] Drivers: hv: vmbus: Fix the offer_in_progress in
 vmbus_process_offer()
Thread-Index: AdPdoKfzRngR012LQ7GfpBkEd0k4zg==
Date:   Thu, 26 Apr 2018 20:55:19 +0000
Message-ID: <KL1P15301MB00067BB599826701A41A23F8BF8E0@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=decui@microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-04-26T20:55:17.4478484Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic;
 Sensitivity=General
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=decui@microsoft.com; 
x-originating-ip: [2001:4898:80e8:b::47a]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;KL1P15301MB0071;7:DuBCdWt4jbl363XoLhwpmwJN/RYx5JJR1y0rsCJi6TznB/dOjAbsotCNtp91XLaXYx/c8LhkGJaIcCNjmAjaFWUzOMVLGkRv+KfQ3ae1wjisKRpYIdupGy6yisQCrCtjXY0rSQ+/HArhI/Pqts52tnjuK8Kn+KZ4+xImPQWR6gc9Z8CAAagpv8eUqWK165d71+euGqaczOcE4BIlDpRxOe03AmlcD9ocuhZI1qzQLgH832gpwMJGvulrs6ChZBql;20:1FCptmzUL2P1btXFnbIaD9ZeKSEE6YiQXgL2E5hHa2AD8vdAbn9dllQ+SJt91Ry0cjLo7FNzOkM6KldXxNXP4QN/9iC5LRVrRk8Ll673Tw40GDsmnSxrdZmsMrKDAX8agIC3RC0j8GSy3Fl92JJJkuA+f9v/TxFiRrIwg7qJ/EQ=
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:KL1P15301MB0071;
x-ms-traffictypediagnostic: KL1P15301MB0071:
x-microsoft-antispam-prvs: <KL1P15301MB00713F4A8356B493B6855088BF8E0@KL1P15301MB0071.APCP153.PROD.OUTLOOK.COM>
x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(9452136761055);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231232)(944501410)(52105095)(10201501046)(6055026)(6041310)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011);SRVR:KL1P15301MB0071;BCL:0;PCL:0;RULEID:;SRVR:KL1P15301MB0071;
x-forefront-prvs: 0654257CF5
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(39380400002)(396003)(39860400002)(366004)(346002)(189003)(199004)(81156014)(53936002)(1511001)(33656002)(3660700001)(8936002)(77096007)(8676002)(6636002)(81166006)(2900100001)(74316002)(305945005)(86612001)(102836004)(86362001)(99286004)(6506007)(10290500003)(7696005)(6116002)(2501003)(478600001)(7736002)(105586002)(486006)(476003)(5660300001)(106356001)(68736007)(2906002)(46003)(110136005)(25786009)(97736004)(54906003)(14454004)(10090500001)(22452003)(55016002)(3280700002)(1857600001)(4326008)(8990500004)(316002)(186003)(6436002)(9686003);DIR:OUT;SFP:1102;SCL:1;SRVR:KL1P15301MB0071;H:KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: vr6BrJydlDsDu4O+OmR8qpJNfMTp1yRiaVNT3J3a92LoMp8mfXrod5tOrvxcH3kafeRY626W29EeGsIjFHpuAxbSwiYgYQOhRh+j4bxodibytzdaX6fLwMklQg0WBBQod3r5dbmZXdD4KPLJpDJvhai7QbUjzJw+RCZC7+p9RXMdBeIAnRQtHAiRC+x+M/po
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: bde8332e-78c6-406d-302c-08d5abb80587
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bde8332e-78c6-406d-302c-08d5abb80587
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2018 20:55:19.2636
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1P15301MB0071
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


I didn't really hit a real bug, but just happened to spot the bug:
we have decreased the counter at the beginning of vmbus_process_offer(),
so we mustn't decrease it again.

Fixes: 6f3d791f3006 ("Drivers: hv: vmbus: Fix rescind handling issues")
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Cc: stable@vger.kernel.org
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Stable <stable@vger.kernel.org> # 4.14 and above
---
 drivers/hv/channel_mgmt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index ecc2bd2..f3b551a 100644
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -527,10 +527,8 @@ static void vmbus_process_offer(struct vmbus_channel *=
newchannel)
 		struct hv_device *dev
 			=3D newchannel->primary_channel->device_obj;
=20
-		if (vmbus_add_channel_kobj(dev, newchannel)) {
-			atomic_dec(&vmbus_connection.offer_in_progress);
+		if (vmbus_add_channel_kobj(dev, newchannel))
 			goto err_free_chan;
-		}
=20
 		if (channel->sc_creation_callback !=3D NULL)
 			channel->sc_creation_callback(newchannel);
--=20
2.7.4