Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CALCETrUmFfoWE55Nrkiq5cuvPw5oPFJKOg04ky-dJsDVsdSmbg@mail.gmail.com>
References: <1524099966-43544-1-git-send-email-huawei.libin@huawei.com> <CALCETrUmFfoWE55Nrkiq5cuvPw5oPFJKOg04ky-dJsDVsdSmbg@mail.gmail.com>
From:   Dmitry Safonov <0x7f454c46@gmail.com>
Date:   Thu, 26 Apr 2018 22:13:12 +0100
Message-ID: <CAJwJo6bSx3rYZLqPaU6YOed1E6ACwO3ijq8LXA-RUkQWLvdofQ@mail.gmail.com>
Subject: Re: [PATCH v2] prctl: fix compat handling for prctl
To:     Andy Lutomirski <luto@kernel.org>
Cc:     Li Bin <huawei.libin@huawei.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Dominik Brodowski <linux@dominikbrodowski.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Hanjun Guo <guohanjun@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018-04-19 3:25 GMT+01:00 Andy Lutomirski <luto@kernel.org>:
>> On Apr 18, 2018, at 9:06 PM, Li Bin <huawei.libin@huawei.com> wrote:
>>
>> The member auxv in prctl_mm_map structure which be shared with
>> userspace is pointer type, but the kernel supporting COMPAT didn't
>> handle it. This patch fix the compat handling for prctl syscall.
>
> I would propose an alternative fix: change the type to u64. As far as
> I know, this thing is only used by CRIU, and CRIU doesn=E2=80=99t work (A=
FAIK)
> on native 32-bit anyway.

Yeah, it's right - CRIU doesn't work on native 32-bit and no support planne=
d.

Thanks,
             Dmitry