Received: by 10.192.165.148 with SMTP id m20csp88483imm; Thu, 26 Apr 2018 16:37:00 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqTeJv7798GVhyPkYdbuCgADNzyvsBiUAumPmBBDAyH3rTnldkt9jajIlYPAyClpX4ONJtr X-Received: by 10.98.71.141 with SMTP id p13mr63792pfi.164.1524785820444; Thu, 26 Apr 2018 16:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524785820; cv=none; d=google.com; s=arc-20160816; b=QMMRUI3ET9HENwmVhs08qLhr5t8SZFeW6l6Zpu60bDXsbgMSmbVsXsRbZEPGt3A7yI KJKjwlEQVwmyis1H8avrbgtdpBIGJnRKFZQiYb7sEYxy4baY07CFRVeZxEfeESMvteWg xiSP6Egehmq7/2wsPXzmPkDSC82hx6iCXrjNayqtXNTAs5id58qMH1C8+DNY4IzKzn2E v8TmLucwqhvQCs+DSnRBxpXfs8voSNo3Csh1/PnMGeMRJS39Ra/j1yXW93lo8ABiDG4o uiBaZVM1oS2ftRjNZfJZ12PziMm6t4i9ZtQgkrYB0TsJ3P5KQsUNFpS58WG34+C+Bk0U h+Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=wmV6gFAktBN9lBTg6c/KWsqhZe+jkmpZNb7ceJfkg+A=; b=JzDmTd7QmO+R35+hWubhnSMO5wxSQ/fx3hDG6vMKcTL4YeFO7ysHOJPsR+V2X8TkJg eFD9l0WXHLaNg4pmj3AprdW5hr+1AlVQv0+DY/xdo2b+/023mnQpJW/9rsmJv2Xhq2hE 4Z0oHWVG7u+5wKGXAR07wDSB0iuSdu9zIVzEtuJbSUSXrv8Kwzj7f+wFax8MJs+4itv8 IZGDheh7oU4PbkplfL2QZFeYHdxPCr5lpKWRS/OZMhaXug5hPXRGddbQY1Y47fVJMAJu Ju2fcrv8ArfWVeiqqWKR8T339TAs2dt+mvNBMqCvGOgXGWaXKr+mleDFMC6ZC2JDBEqR 8a0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TVp8SuXe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z7-v6si10845pgv.228.2018.04.26.16.36.45; Thu, 26 Apr 2018 16:37:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TVp8SuXe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756937AbeDZX3h (ORCPT + 99 others); Thu, 26 Apr 2018 19:29:37 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35741 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753646AbeDZX3f (ORCPT ); Thu, 26 Apr 2018 19:29:35 -0400 Received: by mail-pg0-f65.google.com with SMTP id j11-v6so59742pgf.2; Thu, 26 Apr 2018 16:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wmV6gFAktBN9lBTg6c/KWsqhZe+jkmpZNb7ceJfkg+A=; b=TVp8SuXeijyqnt5PmLimH0Qf2D5viyOXwqA+xkCnzuxLWVW8OgOFNQwdla2eQqfCmA 82VBIHk/pGKnA8L8+IkYesmUPR8uZQ1joS+NM4AWuxGF2tqSUVIqvmrl9uRkfDH2LXIt 0M7VpGvEsV3sGKZ/ftkkl+hZjrN1UbxvxErGMmfY6LG6CBeHB3pYg4dLoebXL2iTPYbf iIqm6Sly+uW7bHNI2ujAYW3AEMYizHXa2zsdMEvRMU5XIOwiSdGTlyw/H/EKcBRkn23L i/rz5MnTvKvQkukfDl9VtiAhdqQs3pp8KoFLQzRDmbEVTdJsje4+Er+P1ZVHohz3mGC/ sWEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=wmV6gFAktBN9lBTg6c/KWsqhZe+jkmpZNb7ceJfkg+A=; b=dS+UDxtRPG4W9jyBhF0k0qiXiOG45ebJEd7qRpdzkb48lWcO7FNGeDKrFw6uSOSnrv PRHNBlIg39g0CTm4eqt7MhcBPrtcDezdsyds8gC7sGmCq+7MdttXZnk0+fV3YlwtKyRN ksNuOGY01MamQ9WfTdTRoe1fG8aJvOp38ftSHB6IC7S1/moquYvyUUZ3xyjkvrc+ME2r +r6joa8Jogi7cIjEgTNkphUIVPhHz9tx3qV13p3Jtf+/FOLuSnXaQQhEnMGiQqLmJ9NW thnQGA3DRpF76DD+EjjAG3SRjvm5Juqblmq6Ud3LrKOjhNV512Hw3fKzQsrPf1lKzr9e PWKQ== X-Gm-Message-State: ALQs6tBYn5I8V7XWBNDaaRaBLPXwxecq7/LLTSjlD5DEoC9fHyesDsRg 1pvzxf6LKnhF5LUVVQ1GDtw= X-Received: by 2002:a17:902:5c6:: with SMTP id f64-v6mr35896plf.77.1524785374353; Thu, 26 Apr 2018 16:29:34 -0700 (PDT) Received: from [10.69.41.93] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id 203sm351pfz.131.2018.04.26.16.29.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Apr 2018 16:29:33 -0700 (PDT) Subject: Re: [PATCH 04/61] bus: simplify getting .drvdata To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Brian Norris , Gregory Fong , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-5-wsa+renesas@sang-engineering.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Message-ID: <11bc8504-d32a-36fc-0a51-569fff3c4ee2@gmail.com> Date: Thu, 26 Apr 2018 16:29:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180419140641.27926-5-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/19/2018 07:05 AM, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Looks reasonable, would you want to use dev_set_drvdata() while we are it? That would bring more consistency given your proposed change. Thanks! -- -- Florian