Received: by 10.192.165.148 with SMTP id m20csp120282imm; Thu, 26 Apr 2018 17:23:54 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqSi/uCNZi2IYhzQwvoY+MNl0l53/ORz73xpMr6zRNDaQriv/JGIxkYML/+M1xnYlE5Und/ X-Received: by 2002:a63:9a09:: with SMTP id o9-v6mr181476pge.130.1524788634723; Thu, 26 Apr 2018 17:23:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524788634; cv=none; d=google.com; s=arc-20160816; b=mencYvPPcnRqCvVjp5IBXiyz2MowBzuZrBGEBORJX8sl3SAnbm8kwJ7nipXJbolkBM myxLqp/VGAZrhYAbxr/B6w/uXXERr5tak/7v/KL8B6xA47VyvdKPi/rGGg96v/rCOmvj +XBVI7Z56UaK5ZlNHO2w8LbyL/VYniPM3c5IJnzAaw5oxhhNZLcrf0zop1U3yQKMlxlR tZd+tGVs+7zB/+rEGT0+Hq5NWzTJw8soMt2UZAraDdH61nHw/Knvqi5AT+RU9GOagd8a Emzf383tJ/52xb+9JTrAL/cARnWZwLo2Td4bDkRGsjHjml0mN/NMxaXvlz7wq4a3L/0c cBuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=Q6vo5EaqTe4smwJQ/9sbf44vUuAoT84XoPd2jx26h10=; b=P5vREIG+MOXwsO+B98SQJ6828zFe9POYOBEgR4rlto+q1vRJeKAtlsszQCC93AAxGh Esm4AaGzl2CiokvFSkxmUB+P2WvYBQ5/slEjaQcb9/v88PUau0xpVFYFmeuy1v3Tx+NI UW2sP0wwlDOMRNxOcuPzqUjYjCIs9gj3VuxKNfsJXcq54gMM37mI8J1Ngobq1MMojvAC Buc8KUc8ORmVDTglBv/ds3jJnER9L2uRJLd24e0uZ4oC/Syb+jeOCP/N4AQ1vNgYcbRt YnhSFaojHbXm6GBMU+QS/ybr+fKD4MO8qXRJeCVvg+LZlwHfCSsg0bPMyfrsmVINWE3u OUqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rbhjHIoO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e21-v6si68853pgv.513.2018.04.26.17.23.40; Thu, 26 Apr 2018 17:23:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rbhjHIoO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757481AbeD0AWT (ORCPT + 99 others); Thu, 26 Apr 2018 20:22:19 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:41195 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754672AbeD0AWP (ORCPT ); Thu, 26 Apr 2018 20:22:15 -0400 Received: by mail-qt0-f193.google.com with SMTP id g13-v6so192853qth.8; Thu, 26 Apr 2018 17:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q6vo5EaqTe4smwJQ/9sbf44vUuAoT84XoPd2jx26h10=; b=rbhjHIoOXWw2ezYdimNWf7MBujhnTdTdiTRa5uNaCPHNG24naVGC7xLvrdMr5mSsg5 R6klW0g959VZE12rsP0/yVEKzr+ul5y4+3hbzN1jXMEPSNS++kGuumUIq8ZVM1Odz6ip JC1zsI0QIECkG0S+7MhoLY1OypFr+0xb0SV5WDmHSh1iEwTCtDhijZgBNOO6nNlt015x zHyl6BVkoopXBf255dsgz/C374UEeGa3vIiiLNUmrtoxp3vq09ZVEU5lKtY0aa+QUIv7 WeBD6wC77VXYGuoX5pJY/fLSzqN5k+ASrb02GV50+1s3NREdp49MPBok/OzRCixbYDvp u1yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Q6vo5EaqTe4smwJQ/9sbf44vUuAoT84XoPd2jx26h10=; b=t6fe04/51TI9t8R4StP7xnVEiTVWdeFoZuMbGg9Yv4w8vvAht6bptlusuUKZ7a9LFf x12xk1C6OqC4pVcFpI68cYPOe6yksEvE5aphMYYhTki6mlIaQqbU5+laEKr/nPMGB+ru w2WHd6WYfW18ptXK4udDE7XQNFPtI820vrDECNSza+ZkbAe38JCw+VSPbCG3gfgmo7NT MQ71Xkhtx52A6bT4PD/R6dplfFqHUaGWINrcHSbxFPjBsSiq62g0dlXVoFNNalFOHOZR L3dABDxixkh3mNXGjmdqSNY+/TAXSW4+aBkSki7KqmGY+XuKtbp8TuBKcyFcxcqNWWaW oMQw== X-Gm-Message-State: ALQs6tAa2NhdeLG/skLdRUSRTDU7Yw6bq8M3W1BjHsEWNTrHoLlcUYwG RnYiLkm6/eugYwCEoHu7pMbfqOBZ X-Received: by 2002:aed:2411:: with SMTP id r17-v6mr145916qtc.273.1524788534447; Thu, 26 Apr 2018 17:22:14 -0700 (PDT) Received: from [10.69.41.93] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id a28sm85344qkj.28.2018.04.26.17.22.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Apr 2018 17:22:13 -0700 (PDT) Subject: Re: [PATCH 31/61] net: dsa: simplify getting .drvdata To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Andrew Lunn , Vivien Didelot , netdev@vger.kernel.org References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-32-wsa+renesas@sang-engineering.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Message-ID: <4c0bae0e-6338-b6ae-4296-d16c40a7c770@gmail.com> Date: Thu, 26 Apr 2018 17:22:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180419140641.27926-32-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/19/2018 07:06 AM, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang > --- > > Build tested only. buildbot is happy. Please apply individually. Similar to my other comment on patch 4, would not you want to use dev_set_drvdata() to be consistent? This would be functionally equivalent. -- Florian