Received: by 10.192.165.148 with SMTP id m20csp256294imm;
        Thu, 26 Apr 2018 20:56:52 -0700 (PDT)
X-Google-Smtp-Source: AB8JxZqmyV7MfqELTh7u2uHGjk0zdLihpKKWmBelhePyj6oKB7fHLXdLC3+gSWGMp/HHmhp/Wk9x
X-Received: by 2002:a17:902:2804:: with SMTP id e4-v6mr729362plb.153.1524801412045;
        Thu, 26 Apr 2018 20:56:52 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1524801412; cv=none;
        d=google.com; s=arc-20160816;
        b=OQ96vs+bi8OG0ENjX9sGKdsyhourWPQHhdTT7oY/+KXmELdYet7uBQ/0Hh9qIcmV2w
         q7SXoUgEqInHCfeRBX0wAYkerxn+pZlk6YCB7cCcUN0/DGNShGr7mhJQVtfanc0ZYPy5
         3BlChZ5reoveCIfomLWbSDsRcTdWfQ2tdQeDsZgBWoD9MN+3hmH+z1oA+FzoDnfOhkUm
         pmY216Cvv6EdH62TzmWGQiAFJZT+IF3eudXJMZm3T912Y+7lEw2gTXQzWRuyqVLW8rsc
         jiuMnGJYtzfjtojKnlF2N31k8qk5Je2U7jJQSdyBqnWr4BinKdf+11KHvw6qdbf3dh0n
         O++g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=Wr6jj9jp9N4jwvQm9WQ9gX3qHX6iFZlxJniSV5sdVJ0=;
        b=kLKzRKoAMDuIS1QXxwqfU46YmvR+MIBGQSyjqbynBKDSMG/XcUp9p4i3lwicd4OMHb
         15JnXdc6f+XwTOJsMpAoBhPIkrilkLds6afLPFiUxzkenJYixVZJEyZ+/A6TD+viqnZ9
         XrGSwfP5TUuSHd3XejoSkQoVLDWwU0DHsZTJdi2wmNr4zh6PzjEKdtSO6FTaugby3ntG
         D8J42a4sscY9FN3Z6+81+TFNaAnYUw4DdhZEArMLRw7K4gsK8ldbEq4w1FhpOY3zTGiK
         0mOnR7+qE4KYZVlhtGc4IOeeqeloiMtPvrnr3esCimRZTl3fr7k+xn6ZeEzgdEnlFyK1
         T0hA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id p91-v6si416457plb.457.2018.04.26.20.56.01;
        Thu, 26 Apr 2018 20:56:52 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757289AbeD0Dwt (ORCPT <rfc822;peterpeng024@gmail.com>
        + 99 others); Thu, 26 Apr 2018 23:52:49 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:3175 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755540AbeD0Dwr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Apr 2018 23:52:47 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com
        id <B5ae29e990000>; Thu, 26 Apr 2018 20:53:00 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Thu, 26 Apr 2018 20:52:45 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Thu, 26 Apr 2018 20:52:45 -0700
Received: from BGMAIL102.nvidia.com (10.25.59.11) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 27 Apr
 2018 03:52:43 +0000
Received: from [10.24.193.32] (10.24.193.32) by bgmail102.nvidia.com
 (10.25.59.11) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 27 Apr
 2018 03:52:37 +0000
Subject: Re: [PATCH] net: phy: marvell: clear wol event before setting it
To:     Andrew Lunn <andrew@lunn.ch>,
        Jisheng Zhang <Jisheng.Zhang@synaptics.com>
CC:     Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Jingju Hou <Jingju.Hou@synaptics.com>
References: <20180419160232.519d15be@xhacker.debian>
 <20180419121801.GC17888@lunn.ch>
 <4273f766-a017-b336-7d14-a28901d274b9@nvidia.com>
 <20180426141508.6660a633@xhacker.debian>
 <be2addb5-b3fd-13cb-ad33-f0527931a0d2@nvidia.com>
 <20180426155619.2c5d87d1@xhacker.debian> <20180426124007.GC13467@lunn.ch>
From:   Bhadram Varka <vbhadram@nvidia.com>
Message-ID: <7b63b6f5-d93c-f2c8-c448-b81a8323c305@nvidia.com>
Date:   Fri, 27 Apr 2018 09:22:34 +0530
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20180426124007.GC13467@lunn.ch>
X-Originating-IP: [10.24.193.32]
X-ClientProxiedBy: DRBGMAIL104.nvidia.com (10.18.16.23) To
 bgmail102.nvidia.com (10.25.59.11)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew/Jisheng,

On 4/26/2018 6:10 PM, Andrew Lunn wrote:
>> hmm, so you want a "stick" WOL feature, I dunno whether Linux kernel
>> requires WOL should be "stick".
> I see two different cases:
>
> Suspend/resume: The WoL state in the kernel is probably kept across
> such a cycle. If so, you would expect another suspend/resume to also
> work, without needs to reconfigure it.
Trying this scenario (suspend/resume) from my side. In this case WoL 
should be enabled in the HW. For Marvell PHY to generate WoL interrupt 
we need to clear WoL status.
Above mentioned change required to make this happen. Please share your 
thoughts on this.
>
> Boot from powered off: If the interrupt just enables the power supply,
> it is possible to wake up after a shutdown. There is no state kept, so
> WoL will be disabled in the kernel. So WoL should also be disabled in
> the hardware.
>
>      Andrew