Received: by 10.192.165.148 with SMTP id m20csp518943imm; Fri, 27 Apr 2018 03:04:59 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqAmcdjMqSSDgKNZVvVFVi6NbYLBizIRoCYzszyTHFVpymtwfLtx19ost1FFVbNiy5nXnJk X-Received: by 2002:a17:902:9042:: with SMTP id w2-v6mr1704432plz.34.1524823499305; Fri, 27 Apr 2018 03:04:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524823499; cv=none; d=google.com; s=arc-20160816; b=Vbf5IFiho1osnsW+oC1YQ3Oxsvu4HO1t7sHXGO6zfa7ac86XgqQBlCLdnXVqNONcpq H7VlbbAYtH8RAXmRZYJO06L/vZ6WZ7rIDwJmUJ5OYC0N6zLZ2Z2v5s4tbI1n3zaQyYw5 eZGZzglgjjvKJm2cC4ro8z1jiq1A7TbkALIPQM3QI9DXhYtEmnZ2ocbXmgrJUcQ4DX6m T2yyFuv0Tdd//92i4t8Zpel0QNkwUll4/i4y1K0mcpC+1dELzez3ws3Z3NAZhvhtang5 yNTb4EFiH/RmmtrtHKEDy8IS1kCF8ysTp4/eOiZ1/z/6EGgsEWj7DCGzLvxxCGP9SgWd x4pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=sS56OVbyh5vUIl2+wjwUitJq0winQaJSbqr4/7E9Uos=; b=mEBqLGKB/cIYv5I0DkfE2zDwUR+IP6QaSLl4Y5QtV7TXRcC69E4t97VTQg9/Atm0gV uaVlbHwyMgmSANyLZF9cPgf/jd4h4RBJ0CUlrJtqowoyH6GnUXYiewgdZ+FjPrzD/9dh ZKmgh8tuOIDf7HDVHE87zvGyP61upiq1kOorkpXmT4DqETKDqzBVdp7o8T7te6KzkZqe DQMCmNupiobat1xBpAmrvQ/PNs+f1a3W52c327S2Yamt24imk1fJscZHjHsM6zwU7xtB uTV/jzNVvpYgzESaMNlKVxlRGUbvzx8QDbnGkEiA1uA+8Jk3BGNAb+l8/6JVbIwWSfOG e0MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=IK/ZbRyr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11-v6si613776plo.352.2018.04.27.03.04.45; Fri, 27 Apr 2018 03:04:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=IK/ZbRyr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932660AbeD0KDb (ORCPT + 99 others); Fri, 27 Apr 2018 06:03:31 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:36576 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932435AbeD0KD1 (ORCPT ); Fri, 27 Apr 2018 06:03:27 -0400 Received: by mail-wr0-f174.google.com with SMTP id u18-v6so1200716wrg.3; Fri, 27 Apr 2018 03:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sS56OVbyh5vUIl2+wjwUitJq0winQaJSbqr4/7E9Uos=; b=IK/ZbRyrlBKamFewhATZAyFacHRGXXS0XHBVrEuIY9XXpKdEXcP2dPoKSyCna45UsP FXIeYOIWtQWazZMRFiXyfYK63p1PKphNvPMkE6HPBrgmygd6Vh+xQS0WKVLnNVYOaFLJ 4tToLXKjfJZBZf8I0ATWfjcjdxAVFgFSelZXKtM7NZRZvtXhZYS0G3K7X5vPvSEcpSZO t4JvIjADeYTHnHQNrrw/jhB1o0psKxBvuAP9TgZV4wkjRjaSGDgV5PDLy4Ou77OWHiam t/vVz5leigCp78PuL95y7vKcSvr5N6fe5V6TWfnsQOpzymVdp+L9M3Oycf0555Sq4Bk4 CHRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=sS56OVbyh5vUIl2+wjwUitJq0winQaJSbqr4/7E9Uos=; b=J1TokjSuGwOYRl/LL9bB5p5GKBC5y69A8/tERxIGQp8Eaic94Sptq7IciJz4iJzZ0D TuYltJtWDfNsPhyJUc/yo6iss0e6ss1DnhOlc1r9UpSi+bbNswY9ysrDDn2d/6gdDcq8 ewNaxFEBxsAf/c0mwwTTV4TXU0g+/WzwqOpEsU4lK8Texk/AaneBw6TLpOvgCJavtfnC vnklmg17AysrwBrEuBuih1QIAfRJ5Z4f9+ie6uQZcBZzio8KKH8lrWNe0NsOzZzxDoD1 lDidVOpd5Y+MJfIiCYDoqKR+LdO/iWoch8/yZbnzo/jnpXcj551RTPN1UO6plU+ePg0J mz7Q== X-Gm-Message-State: ALQs6tB7YaXa1/yeeE21ZDRHH/2+boVIDiwgU1t5EsqFgJj1kAWvUs5v UnqSZHQGWM6x8C5EJE0Y3DE= X-Received: by 2002:adf:c4c4:: with SMTP id o4-v6mr1245677wrf.173.1524823405453; Fri, 27 Apr 2018 03:03:25 -0700 (PDT) Received: from [192.168.10.165] (dynamic-adsl-78-12-189-60.clienti.tiscali.it. [78.12.189.60]) by smtp.googlemail.com with ESMTPSA id l37-v6sm2351197wrl.83.2018.04.27.03.03.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 03:03:23 -0700 (PDT) Subject: Re: [PATCH 2/2] kvm: nVMX: Introduce KVM_CAP_STATE To: Jim Mattson , "Raslan, KarimAllah" Cc: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "x86@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , "rkrcmar@redhat.com" References: <1523545958-28059-1-git-send-email-karahmed@amazon.de> <1523545958-28059-2-git-send-email-karahmed@amazon.de> <1523898937.22952.13.camel@amazon.de> From: Paolo Bonzini Openpgp: preference=signencrypt Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0f UGFvbG8gQm9uemluaSA8Ym9uemluaUBnbnUub3JnPsLBTQQTAQIAIwUCVEJ7AwIbAwcLCQgH AwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEH4VEAzNNmmxNcwOniaZVLsuy1lW/ntYCA0Caz0i sHpmecK8aWlvL9wpQCk4GlOX9L1emyYXZPmzIYB0IRqmSzAlZxi+A2qm9XOxs5gJ2xqMEXX5 FMtUH3kpkWWJeLqe7z0EoQdUI4EG988uv/tdZyqjUn2XJE+K01x7r3MkUSFz/HZKZiCvYuze VlS0NTYdUt5jBXualvAwNKfxEkrxeHjxgdFHjYWhjflahY7TNRmuqPM/Lx7wAuyoDjlYNE40 Z+Kun4/KjMbjgpcF4Nf3PJQR8qXI6p3so2qsSn91tY7DFSJO6v2HwFJkC2jU95wxfNmTEUZc znXahYbVOwCDJRuPrE5GKFd/XJU9u5hNtr/uYipHij01WXal2cce1S5mn1/HuM1yo1u8xdHy IupCd57EWI948e8BlhpujUCU2tzOb2iYS0kpmJ9/oLVZrOcSZCcCl2P0AaCAsj59z2kwQS9D du0WxUs8waso0Qq6tDEHo8yLCOJDzSz4oojTtWe4zsulVnWV+wu70AioemAT8S6JOtlu60C5 dHgQUD1Tp+ReXpDKXmjbASJx4otvW0qah3o6JaqO79tbDqIvncu3tewwp6c85uZd48JnIOh3 utBAu684nJakbbvZUGikJfxd887ATQRUQnHuAQgAx4dxXO6/Zun0eVYOnr5GRl76+2UrAAem Vv9Yfn2PbDIbxXqLff7oyVJIkw4WdhQIIvvtu5zH24iYjmdfbg8iWpP7NqxUQRUZJEWbx2CR wkMHtOmzQiQ2tSLjKh/cHeyFH68xjeLcinR7jXMrHQK+UCEw6jqi1oeZzGvfmxarUmS0uRuf fAb589AJW50kkQK9VD/9QC2FJISSUDnRC0PawGSZDXhmvITJMdD4TjYrePYhSY4uuIV02v02 8TVAaYbIhxvDY0hUQE4r8ZbGRLn52bEzaIPgl1p/adKfeOUeMReg/CkyzQpmyB1TSk8lDMxQ zCYHXAzwnGi8WU9iuE1P0wARAQABwsEzBBgBAgAJBQJUQnHuAhsMAAoJEH4VEAzNNmmxp1EO oJy0uZggJm7gZKeJ7iUpeX4eqUtqelUw6gU2daz2hE/jsxsTbC/w5piHmk1H1VWDKEM4bQBT uiJ0bfo55SWsUNN+c9hhIX+Y8LEe22izK3w7mRpvGcg+/ZRG4DEMHLP6JVsv5GMpoYwYOmHn plOzCXHvmdlW0i6SrMsBDl9rw4AtIa6bRwWLim1lQ6EM3PWifPrWSUPrPcw4OLSwFk0CPqC4 HYv/7ZnASVkR5EERFF3+6iaaVi5OgBd81F1TCvCX2BEyIDRZLJNvX3TOd5FEN+lIrl26xecz 876SvcOb5SL5SKg9/rCBufdPSjojkGFWGziHiFaYhbuI2E+NfWLJtd+ZvWAAV+O0d8vFFSvr iy9enJ8kxJwhC0ECbSKFY+W1eTIhMD3aeAKY90drozWEyHhENf4l/V+Ja5vOnW+gCDQkGt2Y 1lJAPPSIqZKvHzGShdh8DduC0U3xYkfbGAUvbxeepjgzp0uEnBXfPTy09JGpgWbg0w91GyfT /ujKaGd4vxG2Ei+MMNDmS1SMx7wu0evvQ5kT9NPzyq8R2GIhVSiAd2jioGuTjX6AZCFv3ToO 53DliFMkVTecLptsXaesuUHgL9dKIfvpm+rNXRn9wAwGjk0X/A== Message-ID: Date: Fri, 27 Apr 2018 12:03:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/04/2018 00:28, Jim Mattson wrote: > The other thing that comes to mind is that there are some new fields > in the VMCS12 since I first implemented this. One potentially > troublesome field is the VMX preemption timer. If the current timer > value is not saved on VM-exit, then it won't be stashed in the shadow > VMCS12 by sync_vmcs12. Post-migration, the timer will be reset to its > original value. > > Do we care? Is this any different from what happens on real hardware > when there's an SMI? According to the SDM, this appears to be exacty > what happens when the dual-monitor treatment of SMIs and SMM is > active, but it's not clear what happens with the default treatment of > SMIs and SMM. I think it should be the same, because the preemption timer countdown is not part of the VMX-critical state. Paolo