Received: by 10.192.165.148 with SMTP id m20csp569947imm; Fri, 27 Apr 2018 04:04:09 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpohguZDLb5tFRAoBXOa7pZUxLyjrYnrg3jpLx2X1cIQVx5szR6bJwYKfpCkPqtVdb4IJnP X-Received: by 2002:a63:618b:: with SMTP id v133-v6mr1681443pgb.285.1524827049368; Fri, 27 Apr 2018 04:04:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524827049; cv=none; d=google.com; s=arc-20160816; b=hcdzJ3pxCKcWZ5tOFXN+vaaLdDN60oBFuzXJT8N0zhMBF6+iqzcH7KpY5/mgKxjg6P 778W8teScSziA6I1s3eoAv3XSWgx/eaIm/cL5n8oGhzZb28+AlZoDgCmEc85EYcIMyX+ 0FJj8RY02fTAQNVBB+ka/z8RswwEV93kc2Nc436y3BX+eHBWo95PH6NvUzlC5gP2jv3o rvL92IgoKbViHseI7l6Tgmu/4HcXKBLufHU1rtfduwUWbBypd6EJAqxdmavxuGJLYBhF lKiQIU8wAvKG14gV1oQNCsjKUYOndDR2AMxvJYsQQ0CfFQnL1P2Fbkl+aABgq8m0U+l2 kTIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=QmZqLalP/CIE6cCv5UajDm1VvFaqMW5iTzxj1BKMz/k=; b=sZgCfIH4BbfS/okNpkvepF6KOAzf0YuoTTV9L5hh8UCdAgAISeP1kAKR21MxnV/CUt j/G9WiCkmLr7dSPIz3qZpMkzL6lu24CHqxvV2miXjbSad8udPGyuitxNM/hzT29OydAp +Qol38YRKzNW3UlyUE9b7foqpOYTH7c8o1pypRRQKztXh1xppVKdWBcD/tfoogbO5zeh DxccWrMsXUK5+pZjeHrkh1RteMi2EBXCJe1TIXLYQYmeAGmnag+WP2+iweWq7kyA1lrU 7nQ6Vq2Iuqt0JXtOkgPIPU7aZdVqoSlH5KxO0TI8xMKzxq/uHFvElkH7UrspMhM5XZVn vMVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SAdj6m2w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p17-v6si992320pgn.662.2018.04.27.04.03.54; Fri, 27 Apr 2018 04:04:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SAdj6m2w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932795AbeD0LCc (ORCPT + 99 others); Fri, 27 Apr 2018 07:02:32 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36640 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932700AbeD0LC3 (ORCPT ); Fri, 27 Apr 2018 07:02:29 -0400 Received: by mail-pf0-f196.google.com with SMTP id g14so1243703pfh.3; Fri, 27 Apr 2018 04:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=QmZqLalP/CIE6cCv5UajDm1VvFaqMW5iTzxj1BKMz/k=; b=SAdj6m2wOS/zqjo/dwJg/NYTbuhLnkUG1y0dAWogloBb79N6oTXR6bN/eaczwXlOKX t5SMUjEi7B0hs7Q+aL7LhWFbS/pW5yJaUYup1hAyQtqn4tyk14DvlBQFNBAFajr5Bu0/ 7EFTV2RMoBFm0+ifqt3xZzvEJNtsPAt8yvU9xqm+lPTyArpm90Qm40Qbld1CCwlaKjcR Alti2yCGtWKOe16Xgj3QAFqAlkImBrL7vghOwnLm3FtgdZIDrDQYSZrweXjiRpqFUCFf dq6N7P0DbqqFyp1k9I8ognNSHaFPrZ5PU7/Ky4on1tM2IEaLmzjqZVgmYhMPnU70pGl8 8Bmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QmZqLalP/CIE6cCv5UajDm1VvFaqMW5iTzxj1BKMz/k=; b=I81VHiD+8tu5Mv2s9BLHoxIt5qDCfngu0KOHiAMOtPLLk7OUsWYzGil+XD0ZWmIYPC /Au2Z6BEQ1CBaN0N1M4lEGV84T1YJGiZiFdEmyJzcXaO9++8CjLLSjxAlHh64BDysZ+p 1tf2tPY4PUsWA0hHK6cuBnM/EVXGMaVNwP/3RBxeWmKwdF5bM15kfcMYYX4ylAYHDQE5 LNXV1KdbBn9/iisDxtPQkx5EQumcC1omibRLRNw/GwlKC7Dk1kcYrmeA6/fLEvYFPckQ T93jEd5iLeAyTq0a9WuOzN+mqHxZ0UTqiW9RBG0WXkV54dShPSlh3B7UtFLreEaAMKqT Zs2w== X-Gm-Message-State: ALQs6tCUbkOWHN8wKpm6EZBUQXuxLlCDXOxHLVwe+8uq8QMuGaAyAHgv H9Bidj3wHeYJ1RfwZLRHKbk= X-Received: by 2002:a17:902:aa90:: with SMTP id d16-v6mr1875151plr.189.1524826948539; Fri, 27 Apr 2018 04:02:28 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id r68sm3172401pfi.174.2018.04.27.04.02.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 27 Apr 2018 04:02:27 -0700 (PDT) From: Arvind Yadav To: broonie@kernel.org Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: [PATCH] spi: mpc52xx: Use gpio_is_valid() Date: Fri, 27 Apr 2018 16:32:17 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace the manual validity checks for the GPIO with the gpio_is_valid(). Signed-off-by: Arvind Yadav --- drivers/spi/spi-mpc52xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-mpc52xx.c b/drivers/spi/spi-mpc52xx.c index e8b59ce..0e55784 100644 --- a/drivers/spi/spi-mpc52xx.c +++ b/drivers/spi/spi-mpc52xx.c @@ -447,7 +447,7 @@ static int mpc52xx_spi_probe(struct platform_device *op) for (i = 0; i < ms->gpio_cs_count; i++) { gpio_cs = of_get_gpio(op->dev.of_node, i); - if (gpio_cs < 0) { + if (!gpio_is_valid(gpio_cs)) { dev_err(&op->dev, "could not parse the gpio field in oftree\n"); rc = -ENODEV; -- 1.9.1