Received: by 10.192.165.148 with SMTP id m20csp576624imm; Fri, 27 Apr 2018 04:10:15 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrTFQK1yg6717vjUO633RjgvBAW8/7kcggDnVjOa/UnQxE735XxDeqGv/CmWPxvJ4Vxbd6I X-Received: by 10.98.19.151 with SMTP id 23mr1842160pft.222.1524827415604; Fri, 27 Apr 2018 04:10:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524827415; cv=none; d=google.com; s=arc-20160816; b=z00tM/tyrKYIgnLVzqwKbsiKp3qFqXq/LS2Az0UUA3zEWiMlzlXiSrASb6xRKS/204 GcZI0lmewFrPD+HXDfH71KIX/wjBADfeiJWElCTR5U6vLWyYqCJ2oGZTzjk2aLElICUh fUA3/Jma4Mga+XOXNG1UDU6STvKBG6nR8F9Qn7jD9Fdf90G5Oih91uCByCzEgLBl7kSV XECVPrri2sAzGWVkkrjT2I0Tlej1wsUOAfAgLlnx1xDl+ZOxMgSWFh38h0YFVcajuNIk pz8p7aPaVWTyXY1UXRP4D5cmNufIH6mxUOzsvqwt/aVZn0Ip72tI2csh4HE6UUd+BZIg HrUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=2gYKlEiFyac3/maW7kVBWQePyZzhA4tEXU4FQc2e6Dg=; b=hPatjoGVCyMs7OsoCvMxTSZvdlzD9ky2VaUsZ4iAl9H7io9zCGCCzgnnOTicx22xuh psVl67Z8S1x+T74ig0UXbRUGst9PCZMhqWTNGnofBAAbFGcdd4slUR73kFpuCucZ22HX NbrcaGjKgQ6DaKCBQKWwqHIkmJk4AJsMqwxTAHuq32t3uzlxWFgVNtJ3o5tbaaM5h8hG UZ3uCQ/XxVm03cyQKuAzDxbQNmWlRe8z+v7k1L+j2LkgCe4i4wOn6QxaaXy21SMp2NS8 exKb435dS0E+0RlKlvoOaoP+6Xy8YYHd4REJl6QHAz8O9VU8yeykARH2ITeTnjN9fB2j 5lSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=CRTPWnCF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i136-v6si1033109pgc.0.2018.04.27.04.10.01; Fri, 27 Apr 2018 04:10:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=CRTPWnCF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932793AbeD0LIt (ORCPT + 99 others); Fri, 27 Apr 2018 07:08:49 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:48362 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932605AbeD0LIs (ORCPT ); Fri, 27 Apr 2018 07:08:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=2gYKlEiFyac3/maW7kVBWQePyZzhA4tEXU4FQc2e6Dg=; b=CRTPWnCFJNmx QXQdqciLIdSvTJbr+WhE9HwHaWXNWNBVAGmDsooZMp3JD35JYo5M8fUbnG+0gvuDqihBjJYWCstIj c0y9rHYEyS1hgqd5IeI9Rm/6WczI16fkHZ0G6/rWotEx102aFFutXEEGTkeTvEksH9PakeM2ilC11 8CHIU=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fC1F8-0007i3-KR; Fri, 27 Apr 2018 11:08:46 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1fC1F8-0004WI-06; Fri, 27 Apr 2018 12:08:46 +0100 From: Mark Brown To: Arvind Yadav Cc: Mark Brown , broonie@kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-spi@vger.kernel.org Subject: Applied "spi: mpc52xx: Use gpio_is_valid()" to the spi tree In-Reply-To: Message-Id: Date: Fri, 27 Apr 2018 12:08:46 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: mpc52xx: Use gpio_is_valid() has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 0a090d6537d3ac14391e7aeaf025b725e72a9675 Mon Sep 17 00:00:00 2001 From: Arvind Yadav Date: Fri, 27 Apr 2018 16:32:17 +0530 Subject: [PATCH] spi: mpc52xx: Use gpio_is_valid() Replace the manual validity checks for the GPIO with the gpio_is_valid(). Signed-off-by: Arvind Yadav Signed-off-by: Mark Brown --- drivers/spi/spi-mpc52xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-mpc52xx.c b/drivers/spi/spi-mpc52xx.c index e8b59ce4dc3a..0e55784a3ad9 100644 --- a/drivers/spi/spi-mpc52xx.c +++ b/drivers/spi/spi-mpc52xx.c @@ -447,7 +447,7 @@ static int mpc52xx_spi_probe(struct platform_device *op) for (i = 0; i < ms->gpio_cs_count; i++) { gpio_cs = of_get_gpio(op->dev.of_node, i); - if (gpio_cs < 0) { + if (!gpio_is_valid(gpio_cs)) { dev_err(&op->dev, "could not parse the gpio field in oftree\n"); rc = -ENODEV; -- 2.17.0