Received: by 10.192.165.148 with SMTP id m20csp610559imm; Fri, 27 Apr 2018 04:46:04 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqR26q88XdDT793lyQBHIGwHjD8YO9ZdKH/Wm53wTXp4jy2ZePa4C3zJFOt8604fbX1baGr X-Received: by 2002:a17:902:584:: with SMTP id f4-v6mr2008612plf.290.1524829564104; Fri, 27 Apr 2018 04:46:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524829564; cv=none; d=google.com; s=arc-20160816; b=kuiCbohG6mNlBNc1IjZfVrcbEEHETNMdy4Sq2BgDR5PdUWaGS9CfpRzV5mhGBhq/ax YlNzzm4LVlCMp+vb1DUa6BK/Q2JLiNUhHbBGj0vzYLA7BcfTfh9S9RrdY9Wdbhb55IVg o/OpsiqKg7HHfQ3MopGZbsLZ1R1sVp0t0OjXvVENGGLTFmQ800rYdFf4RjqqBYdpnedS 3tn5eRQ1FWacuEUDAeCZNu8avhGNNr/Vx1/mmXvIOPW0lXjrVt9SeSdmDQ8jjT9y5DjY xRLQ7EjY0D6ZY2r4IwXJfkvoLKflvw5wu3X2bNfgjIO97H26l7ssM1q/weJ6Dmk4faWN wrYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=CSUVrs7RbHla2AZ+PII5RF2BzmsVJRYtdsOAk1f0y8c=; b=IZ89N26GbNhiP0F0kr5h+5N5HxtGQ357ImB1ymHDDtE1UqLv3kl2gubsIa5232vO6f c5o0WCWpstghAHk5X7vxFFFkmpbmCtl51jJdit2PrYtCLUUkFYYtV4jpHucz0yId52BQ uUB47A00sQG/KtVpLslNqp1wZUZNXjx7elX8A5iFpHrdUJqhvIPWHcV4NS3pQYHlGaoK iChuUfkMvABRBL5UaN9LsTDRijdMY3A+NrATXEF0Wqwp0dPouvBUIVGyqB1CrGnGtUcX 3fjvJATZiZe7wZ3OpXY0txRsc2OElpUls73+Rj2BmDbsr1seBJNvzLVZeBipXAdfW8M/ DGOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Mu1q60yC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o14-v6si1112644pli.13.2018.04.27.04.45.50; Fri, 27 Apr 2018 04:46:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Mu1q60yC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757876AbeD0LoW (ORCPT + 99 others); Fri, 27 Apr 2018 07:44:22 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:42767 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbeD0LoT (ORCPT ); Fri, 27 Apr 2018 07:44:19 -0400 Received: by mail-pf0-f195.google.com with SMTP id a11so1312668pfn.9; Fri, 27 Apr 2018 04:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=CSUVrs7RbHla2AZ+PII5RF2BzmsVJRYtdsOAk1f0y8c=; b=Mu1q60yC2osw8pHZDCcvcbkx4lOCpsVbz4q1PrC1RreQa4P5pPs3VG110rQSIOg5zr 9op3E0jyk4e8nZk/Q3gbZEWvgYc4eZZPMmGKlT5n5r1rAfFGMRtx8gNmgnJY0deEN8ye CMLqls0jMNl5TuosJI+ZOdD8ixyg+lMxuY5s4re/dEFfG9E6Yp+vR2Ht6ytw6jD1F9AP 0xbNc86I3hbyA0GS+dparIJSuzt8WvOg1GvK5MZCEisJVroUwvTdNyDBjedI669ahlip UWD1TxmBUlU0fmqfJw/4YMRbt+A/qp8AN/gULBwTiDl7+zn5ZCApmQMwhPnUzDgCtoyC dYVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=CSUVrs7RbHla2AZ+PII5RF2BzmsVJRYtdsOAk1f0y8c=; b=ZO+7iAdXG0OR2xf8zdymxwkTEIf0A+V2oJpfP15iWB3Tyuo3Rbg6RY6sK8gi3PaDqv 1H90T0QK2gQmzDufwfEJ9avEczxGXD4lr90weE5B2wRuJj+AzAbq5AjGVHbj0AZDLYVs sM6QtYPj5cwqYthWFZaJx/hc0sGc45lnvapoBmjUQ9gYL7M7czKHV6JS/pev+E5Btdu3 Lk2xOKykw61qdLGwPOR2c8/R0HAqRAbxJAk5GsDCBOOi6ZBh9v5zUJKeoMm4UBi0q6Wa TAnkGil+OmWwpPCf+0xRiXwP/t2X/3wexmZg/MrnCsdHdS7YaaJgARdfP0Tc7THZK86o M/SA== X-Gm-Message-State: ALQs6tAHZ1zRYyDvEhNF5xsvlONMKXFmh77l0dPDRRcjt34RaM1V7tdt 8YG4NQ2V+rchrV+phQRT28dCmg== X-Received: by 2002:a17:902:1682:: with SMTP id h2-v6mr2016390plh.127.1524829459178; Fri, 27 Apr 2018 04:44:19 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id t23-v6sm4096619pgu.41.2018.04.27.04.44.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 27 Apr 2018 04:44:18 -0700 (PDT) From: Arvind Yadav To: mchehab@kernel.org, hans.verkuil@cisco.com, viro@zeniv.linux.org.uk Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 1/2] [media] platform: Use gpio_is_valid() Date: Fri, 27 Apr 2018 17:14:00 +0530 Message-Id: <93444a65ca7853d27c724aeb50d16c5afd59fa08.1524828993.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace the manual validity checks for the GPIO with the gpio_is_valid(). Signed-off-by: Arvind Yadav --- drivers/media/platform/via-camera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/via-camera.c b/drivers/media/platform/via-camera.c index e9a0263..f01c3e8 100644 --- a/drivers/media/platform/via-camera.c +++ b/drivers/media/platform/via-camera.c @@ -178,7 +178,7 @@ static int via_sensor_power_setup(struct via_camera *cam) cam->power_gpio = viafb_gpio_lookup("VGPIO3"); cam->reset_gpio = viafb_gpio_lookup("VGPIO2"); - if (cam->power_gpio < 0 || cam->reset_gpio < 0) { + if (!gpio_is_valid(cam->power_gpio) || !gpio_is_valid(cam->reset_gpio)) { dev_err(&cam->platdev->dev, "Unable to find GPIO lines\n"); return -EINVAL; } -- 1.9.1