Received: by 10.192.165.148 with SMTP id m20csp768691imm; Fri, 27 Apr 2018 07:14:34 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo+G+uin++CrHc4TZn2z6BHcuo4MdysfZsTMU9I7taUXNIspQL1bpvtdNCTYJkEnuLJa5BF X-Received: by 2002:a65:48c9:: with SMTP id o9-v6mr2235810pgs.390.1524838474024; Fri, 27 Apr 2018 07:14:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524838473; cv=none; d=google.com; s=arc-20160816; b=RGaX384rwlxb58P6qQFW8IKGw1I1pKuzw4VQHVN4t5de6krue2aVW7dcit/UYHRTG3 MCgoaHxTROemEPHfFMW7TIYQ+/nwWNZb7hJHaqekOzSfDqtgFcBQ0SoTgoMUv7gvAxDr pM9wABxDBEMTex7cM1CkB9QtX7fKPwRxmeGVUGeWa+2/jjzoBW9nIEIbucQd3iIq/UAa oQxL6+6cY1HnnL9g/sVcap2uPGJWLkRaBsVAz+s2eUK6lMq0FwUyYauELD/nm4dAY1dC +UYrAseggUvRxj0CUSGXmHvYkUUXli1cr68tC7RjIpMNsqxwfJfrIPuwI6UZ7Wv/ku+l AzEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dmarc-filter :arc-authentication-results; bh=3D+rGn5oa3+IyXFqdU7U5JhodoN/JcWv9DoipmTZGMA=; b=FzcLZSz58JE4Del1AsSHCkBfQWg1GFLPsCxDWzZAw/WB2JBra2T9m3dL0wpvUcPKIs HzjvBJAg/xUyxbLv8d0sru6mNfGrkYCGsMdIvNhk378mKgusN3/ZwQD3jP10PHGo0Uoe 8sS6ut+MqNA+y0c6jXNFyiDQKRiS2mWHR2TscYHnT85sE0K0SxhQNtZtZ2YzqJE9OhIN V0MQe9rO+ZHE4V2rEVmPHbqtL9nq8JqiQuAHdvhJcHJcgN6+4BtH2KVNl6RFI1fAFkem rVWRRlGjMKMarfTjgijvgMVhPvs5IXYruZDjqreONAmvsFl+I7TucYg15uIyov8uNCbP X7lQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t144-v6si1288628pgb.94.2018.04.27.07.14.19; Fri, 27 Apr 2018 07:14:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935328AbeD0ONW (ORCPT + 99 others); Fri, 27 Apr 2018 10:13:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:57638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935277AbeD0ONU (ORCPT ); Fri, 27 Apr 2018 10:13:20 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5AF83218D8; Fri, 27 Apr 2018 14:13:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AF83218D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Laurent Vivier , Jens Axboe , Stan Johnson , Finn Thain , Geert Uytterhoeven Subject: [PATCH 4.16 68/81] block/swim: Remove extra put_disk() call from error path Date: Fri, 27 Apr 2018 15:59:10 +0200 Message-Id: <20180427135747.247793906@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427135743.216853156@linuxfoundation.org> References: <20180427135743.216853156@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Finn Thain commit c1d6207cc0eef2a7f8551f9c7420d8776268f6e1 upstream. Cc: Laurent Vivier Cc: Jens Axboe Cc: stable@vger.kernel.org # v4.14+ Fixes: 103db8b2dfa5 ("[PATCH] swim: stop sharing request queue across multiple gendisks") Tested-by: Stan Johnson Signed-off-by: Finn Thain Acked-by: Laurent Vivier Reviewed-by: Geert Uytterhoeven Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- drivers/block/swim.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/block/swim.c +++ b/drivers/block/swim.c @@ -858,7 +858,6 @@ static int swim_floppy_init(struct swim_ &swd->lock); if (!swd->unit[drive].disk->queue) { err = -ENOMEM; - put_disk(swd->unit[drive].disk); goto exit_put_disks; } blk_queue_bounce_limit(swd->unit[drive].disk->queue,