Received: by 10.192.165.148 with SMTP id m20csp797198imm; Fri, 27 Apr 2018 07:40:38 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqKxR+Y2hzvRRLnFFYS5I9luqlR5nVmhEoF9neB08MZFra5i+FCeLi4g/30eM19C1q5WBdj X-Received: by 2002:a65:5b4a:: with SMTP id y10-v6mr2375322pgr.243.1524840038376; Fri, 27 Apr 2018 07:40:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524840038; cv=none; d=google.com; s=arc-20160816; b=P+RXrc5q1SUCpqMIo417q/oW1TZK4wOXoxJzznrfRcvus00KC3eZx/JzGHFJD54DYK bdyo4lI1CjUwTBEqWJAUIz92i2fCjxBUAeRn4H+EHizLlm3r/IoZcNVSgfIwigqyoPKd EIIV3cGLDzecl5maD6LliiN0ZLGP5PIqy2tj0w1TLtHagRxwSkvV6eR4X5HOQGm2V2PG FIg5M2AW78B1OY9QuTLA59qss8K4lIs64B3egBWhdygt4UUl4V4FVMJUWlYVH1lcl3sY qr3PaTfd9cxDJYfDocBDyb1vd3b7LrT7Ciam337nyqBzx7mFIfLo8pB1OSd/U1nTYtOB X00A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=j2UVDRGF9YVURd1sazsqwaTG/2nSNNsy3AhshoOAe+0=; b=LfV/LB25df+qagBjeGXrDU5INY2zAv33ksJMJvjGEhQ6gOp4xD3k2ZXcli5umXxhiA myXYiqtnUTv//8gUnLrBOoYoPcZ9DfH3GSJ/DUB/Rx7PT/f00kwYVSdtJ3UXL7pHWov8 qKvJx4nhWbEEf8dv4yfyst7bNIP+nRx4GXid6dKd16KR5ZigrRmOdFu6iwhCyuSDX8D+ QPdJq+LNr8J6xE8sMg5hMqd5InQJvBbTqLzNA3PKIBVQ63C6SfuUxvuxQq3xT7hHwtbf KC5f6S/zClG9NfRupXSMkTSXINs0w6KxElKoeRAFrGkglXbQoFKX6i4pLgPgqGoP+V5Q yVIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 68-v6si1367675pla.452.2018.04.27.07.40.24; Fri, 27 Apr 2018 07:40:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934695AbeD0OjE (ORCPT + 99 others); Fri, 27 Apr 2018 10:39:04 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60732 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934230AbeD0OjA (ORCPT ); Fri, 27 Apr 2018 10:39:00 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2F6014023112; Fri, 27 Apr 2018 14:39:00 +0000 (UTC) Received: from localhost (unknown [10.18.25.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F21682023227; Fri, 27 Apr 2018 14:38:59 +0000 (UTC) Date: Fri, 27 Apr 2018 10:38:59 -0400 From: Mike Snitzer To: Kees Cook Cc: Alasdair Kergon , LKML , dm-devel@redhat.com, Tycho Andersen , Heinz Mauelshagen Subject: Re: dm/raid1: Remove VLA usage Message-ID: <20180427143859.GA26647@redhat.com> References: <20180411044315.GA46144@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 27 Apr 2018 14:39:00 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 27 Apr 2018 14:39:00 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'msnitzer@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 26 2018 at 7:31pm -0400, Kees Cook wrote: > On Tue, Apr 10, 2018 at 9:43 PM, Kees Cook wrote: > > On the quest to remove all VLAs from the kernel[1], this avoids VLAs > > in dm-raid1.c by just using the maximum size for the stack arrays. > > The nr_mirrors value was already capped at 9, so this makes it a trivial > > adjustment to the array sizes. > > > > [1] https://lkml.org/lkml/2018/3/7/621 > > > > Signed-off-by: Kees Cook > > Friendly ping... can someone take this, or should this go via another tree? It needs further review but it is on my radar. But please consider it claimed and proceeding upstream for 4.18 via linux-dm.git Thanks, Mike