Received: by 10.192.165.148 with SMTP id m20csp812912imm; Fri, 27 Apr 2018 07:56:39 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrje4Ji6l45DUI223RaSOpW9i4Sc2tn0cWHoHZoEWrc4eh8PdHjpTXOLIYuGh+NL1QDNEjR X-Received: by 2002:a17:902:b18c:: with SMTP id s12-v6mr2660031plr.178.1524840999002; Fri, 27 Apr 2018 07:56:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524840998; cv=none; d=google.com; s=arc-20160816; b=l7VE7RCoo8KXpVHhKvoF4SYvw/mRFIJcqzyYPuDMpeLSsM4jR6Hxa0GzlazFQNnAC/ a8cv7MDH7l1w/tFetHHEaW9v0/sl1R+swIs+919XdmLUndYJOOJdoq/pVWDzIs81ntiF ZKdREhCW8qE7+LJpNwdKsthOycFWiQoq7VT7tNRZpnmZXfO/EPQjGidgNQzhEDSpvzBH 4LzPuIEtoHsf78v5lJllpxztqep5HUnddaxYsTAXq6fBDEPE1XJaSfzyiuoypRprE1ZR GR+TJ9g7DxBX+RqQ4hiou6juGyQZuMIkqDzgmBme1xEy+xY4LYJ+ULGdDgL/islpyNEr dFrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=wolukcIz8RmdTBHIi3rJKnoyXysmwu9CqtzPxiYBzjA=; b=zPari7/9e/drLqROGWC+fYCWb2ox5hr7QPGqm+XePJhpegrUUuuTJVd0bBcq9ge2Ga axd8ie6liEvjUchaSpnD/klI+Dzt/eX8r2OrJ7GV83WgE58Qo8kL1eIwaqX4lxcgTZ6r I7LoF3d4knjQhX+BSfkW+iApyWo8e34maAtL/Svuu1iYWP8w8Je1Qekq3KoeGB2lNjZo C/3SSrXOg/AUNNoHNQ2OPImcmVHE1uPK5mvTb1d0Dv4Fbcpu/z7NiajzAbF3a5D0pGLc Z2qOIFCt0jQm35CdJ9ZmXO3tM28AZvVPL8qk9wbcnacmIrrDvYu4PZX80l1oLTkr+vFK 3+3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m13-v6si1349143pgp.482.2018.04.27.07.56.24; Fri, 27 Apr 2018 07:56:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934336AbeD0OzW (ORCPT + 99 others); Fri, 27 Apr 2018 10:55:22 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52824 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933847AbeD0OzU (ORCPT ); Fri, 27 Apr 2018 10:55:20 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2826E1009428B; Fri, 27 Apr 2018 07:55:19 -0700 (PDT) Date: Fri, 27 Apr 2018 10:55:18 -0400 (EDT) Message-Id: <20180427.105518.55533156322929879.davem@davemloft.net> To: bjorn.andersson@linaro.org Cc: clew@codeaurora.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2] net: qrtr: Expose tunneling endpoint to user space From: David Miller In-Reply-To: <20180423214653.10016-1-bjorn.andersson@linaro.org> References: <20180423214653.10016-1-bjorn.andersson@linaro.org> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Apr 2018 07:55:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Andersson Date: Mon, 23 Apr 2018 14:46:53 -0700 > + count = min_t(size_t, iov_iter_count(to), skb->len); > + if (copy_to_iter(skb->data, count, to) != count) > + count = -EFAULT; > + > + kfree_skb(skb); As noted by Chris, you should be using consume_skb() here. Thanks.