Message-ID: <99F2150714F93F448942F9A9F112634C080EF00E@txexmtae.amd.com>
From: paul.devriendt@amd.com
To: pavel@suse.cz, davej@redhat.com, linux-kernel@vger.kernel.org, aj@suse.de,
       mark.langsdorf@amd.com, richard.brunner@amd.com
Subject: RE: Cpufreq for opteron
Date: Sun, 24 Aug 2003 10:31:56 -0500
MIME-Version: 1.0
Content-Type: text/plain;
 charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1659
Lines: 57

It appears to me that the BUG_ON() macro will take the machine
down ? The BUG_ON() checks in this code (a sample below, but 
this applies to all of the driver) are not fatal conditions - 
execution can continue if an error is returned. Taking the 
machine down to report on a non-fatal condition seems somewhat 
rude.

Paul.

> -----Original Message-----
> From: Pavel Machek [mailto:pavel@suse.cz]
> Sent: Friday, August 22, 2003 3:06 PM
> To: Dave Jones; kernel list; Devriendt, Paul; aj@suse.de; Langsdorf,
> Mark; Brunner, Richard
> Subject: Re: Cpufreq for opteron
> 
> 
> Hi!
> 
> Here's an updated version. It is quite a bit shorter, and thats
> good. Does it look good enough for inclusion?
> 							Pavel
> 
> +static int
> +write_new_fid(u32 fid)
> +{
> +	u32 lo;
> +	u32 savevid = currvid;
> +
> +	if ((fid & INVALID_FID_MASK) || (currvid & INVALID_VID_MASK)) {
> +		printk(KERN_ERR PFX
> +		       "internal error - fid/vid overflow on fid write\n");
> +		return 1;
> +	}
> +
> +	lo = fid | (currvid << MSR_C_LO_VID_SHIFT) | MSR_C_LO_INIT_FID_VID;
> +
> +	dprintk(KERN_DEBUG PFX "writing fid %x, lo %x, hi %x\n",
> +		fid, lo, plllock * PLL_LOCK_CONVERSION);
> +
> +	wrmsr(MSR_FIDVID_CTL, lo, plllock * PLL_LOCK_CONVERSION);
> +
> +	if (query_current_values_with_pending_wait())
> +		return 1;
> +
> +	count_off_irt();
> +
> +	BUG_ON(savevid != currvid);
> +	BUG_ON(fid != currfid);
> +	return 0;
> +}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/