Received: by 10.192.165.148 with SMTP id m20csp890749imm; Fri, 27 Apr 2018 09:07:31 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoOeBRdIywAs8mIxdIrHJBdb+QMirMNIMNf8MaivJGUVTrHzliuweQn+DbXR8UOQon+lskV X-Received: by 2002:a63:7e5c:: with SMTP id o28-v6mr2585105pgn.194.1524845251606; Fri, 27 Apr 2018 09:07:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524845251; cv=none; d=google.com; s=arc-20160816; b=A6EZ57NSrOkseYUAoIR005djE+Vj0aMFZruKV3uMu+djKdBQKveiQ99yTqMcsCzP5U dT8TSVClJmH3K4x+ac38S7yY5a9lGeVw1WQRTSeswpfXl573JwSvNw1SHTZMgf97/oo0 HMSrNEAB7QlsV1iqeJPSk6jmI1im4dogILGxJHT5RSw+vHAA6xn6LqFRH4FBleeb9lvr gDDMKfSdwxZUeAKVIRCRggJA818zVfOPh3ZZZIEq3LyL/rwAcVmSqphnwQaX98BGfv12 QJw4XJb0K6K6Lq68j9rFPKOF55w45zncjMD9P8fPsxmt3bnG9imOpvtsQZ2fViIpUJwY 8/RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=HGRNWshZlNJEcczNOFOiI5azZayG38BcZZ2UuQs0b48=; b=Da6cDPJtArtpYL8VEr7FaJ3jV0/RUAEDNi7uqN3T40nvqSqKmwnLKlAMsPb7HHH44/ PKBwH/H29jJEE/pWHKGEzUpl4vO85X135m4MHZvgKck/PSA1OihYLKiExZgAOm0wyIL2 WZ36OwLYkwgs5lL48AkKhsAdLzSH8f5biN1lkV2X8TlzJVRDCC5pFFWyEODa/bSCnMr+ bfLl7s7yeLu2D9mijj0WmMHxZOe5626xszPwRAs16B7LApjgEfwVYx5kdYuZjRYpw0gX qUiFJy7uPrbf6RyXZGbo8S5dzZe6hSVyqtpLoK+FqPQqjeAdrDNLI66lukDNhMdBM7YJ Ya2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f96-v6si1466150plb.418.2018.04.27.09.07.16; Fri, 27 Apr 2018 09:07:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932823AbeD0QFu (ORCPT + 99 others); Fri, 27 Apr 2018 12:05:50 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:43186 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758629AbeD0QFq (ORCPT ); Fri, 27 Apr 2018 12:05:46 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2DF47A2020; Fri, 27 Apr 2018 16:05:46 +0000 (UTC) Received: from redhat.com (ovpn-123-34.rdu2.redhat.com [10.10.123.34]) by smtp.corp.redhat.com (Postfix) with SMTP id D9D19215CDCB; Fri, 27 Apr 2018 16:05:45 +0000 (UTC) Date: Fri, 27 Apr 2018 19:05:45 +0300 From: "Michael S. Tsirkin" To: Kevin Easton Cc: Jason Wang , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node Message-ID: <20180427185501-mutt-send-email-mst@kernel.org> References: <000000000000a5b2b1056a86e98c@google.com> <20180427154502.GA22544@la.guarana.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180427154502.GA22544@la.guarana.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 27 Apr 2018 16:05:46 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 27 Apr 2018 16:05:46 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: > The struct vhost_msg within struct vhost_msg_node is copied to userspace, > so it should be allocated with kzalloc() to ensure all structure padding > is zeroed. > > Signed-off-by: Kevin Easton > Reported-by: syzbot+87cfa083e727a224754b@syzkaller.appspotmail.com Does it help if a patch naming the padding is applied, and then we init just the relevant field? Just curious. > --- > drivers/vhost/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index f3bd8e9..1b84dcff 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -2339,7 +2339,7 @@ EXPORT_SYMBOL_GPL(vhost_disable_notify); > /* Create a new message. */ > struct vhost_msg_node *vhost_new_msg(struct vhost_virtqueue *vq, int type) > { > - struct vhost_msg_node *node = kmalloc(sizeof *node, GFP_KERNEL); > + struct vhost_msg_node *node = kzalloc(sizeof *node, GFP_KERNEL); > if (!node) > return NULL; > node->vq = vq; > -- > 2.8.1