Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 27 Apr 2018 09:25:24 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        kbuild test robot <lkp@intel.com>,
        "Hao, Shun" <shun.hao@intel.com>, Arnd Bergmann <arnd@arndb.de>,
        Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH 4.14 41/80] Revert "microblaze: fix endian handling"
Message-ID: <20180427162524.GA27698@roeck-us.net>
References: <20180427135732.928644313@linuxfoundation.org>
 <20180427135735.038395432@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180427135735.038395432@linuxfoundation.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Authenticated_sender: guenter@roeck-us.net
X-OutGoing-Spam-Status: No, score=-1.0
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net
X-AntiAbuse: Original Domain - vger.kernel.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - roeck-us.net
X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net
X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 27, 2018 at 03:58:34PM +0200, Greg Kroah-Hartman wrote:
> 4.14-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> This reverts commit ac3d021048be9edb825f0794da5b42f04fefecef which is
> commit 71e7673dadfdae0605d4c1f66ecb4b045c79fe0f upstream.
> 
> kbuild reports that this causes build regressions in 4.14.y, so drop it.
> 

I don't know about kbuild, but with this revert applied all Microblaze
builds fail. There are endless

warning: #warning inconsistent configuration, needs CONFIG_CPU_BIG_ENDIAN [-Wcpp]

followed by

lib/find_bit.c:185:15: error: redefinition of ‘find_next_bit_le’

I have to revert this revert to get successful builds.

Guenter

> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: "Hao, Shun" <shun.hao@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  arch/microblaze/Makefile |   17 ++++++-----------
>  1 file changed, 6 insertions(+), 11 deletions(-)
> 
> --- a/arch/microblaze/Makefile
> +++ b/arch/microblaze/Makefile
> @@ -36,21 +36,16 @@ endif
>  CPUFLAGS-$(CONFIG_XILINX_MICROBLAZE0_USE_DIV) += -mno-xl-soft-div
>  CPUFLAGS-$(CONFIG_XILINX_MICROBLAZE0_USE_BARREL) += -mxl-barrel-shift
>  CPUFLAGS-$(CONFIG_XILINX_MICROBLAZE0_USE_PCMP_INSTR) += -mxl-pattern-compare
> -
> -ifdef CONFIG_CPU_BIG_ENDIAN
> -KBUILD_CFLAGS += -mbig-endian
> -KBUILD_AFLAGS += -mbig-endian
> -LD += -EB
> -else
> -KBUILD_CFLAGS += -mlittle-endian
> -KBUILD_AFLAGS += -mlittle-endian
> -LD += -EL
> -endif
> +CPUFLAGS-$(CONFIG_BIG_ENDIAN) += -mbig-endian
> +CPUFLAGS-$(CONFIG_LITTLE_ENDIAN) += -mlittle-endian
>  
>  CPUFLAGS-1 += $(call cc-option,-mcpu=v$(CPU_VER))
>  
>  # r31 holds current when in kernel mode
> -KBUILD_CFLAGS += -ffixed-r31 $(CPUFLAGS-y) $(CPUFLAGS-1) $(CPUFLAGS-2)
> +KBUILD_CFLAGS += -ffixed-r31 $(CPUFLAGS-1) $(CPUFLAGS-2)
> +
> +LDFLAGS		:=
> +LDFLAGS_vmlinux	:=
>  
>  head-y := arch/microblaze/kernel/head.o
>  libs-y += arch/microblaze/lib/
> 
>