Received: by 10.192.165.148 with SMTP id m20csp1016918imm; Fri, 27 Apr 2018 11:10:20 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoDQw7cm5XhSM709/YRxH3kTDjpnhbGZIX+1oDL1cbLhiK/zET4iPWprz+292lZN1AEbYpS X-Received: by 2002:a63:7f59:: with SMTP id p25-v6mr2946503pgn.440.1524852619968; Fri, 27 Apr 2018 11:10:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524852619; cv=none; d=google.com; s=arc-20160816; b=kB1KIkLYUGP38H5WtUhayg7gT5WylAP9SFQ0fMkgkLyeQxej2VXonax8Qt60PPIoL5 XZNPfPYoWo578fvs7Vs/xtgjWNl7GVRBSLs+kg+e2sfD2yGcJr95+IVLDIDQXLw6LC3J oTlRSFTT56fIPLj5o/MDyl6A2f+dJytJTCiG4Oc8u2kgZIXq4+tYZfxXW2mS5ZfUzJf8 Bdww1pYj82gq4SRCP9VwbErtjRAmpP6z0d+zW8JOT5LXD1jH1F5cDpy3AdwOOawJ1xOR 7PJ+fFT+rOPr0IYCnhFPJ+bCuBdz0PRVOLPBGjXQEM21VntXBeJETHkrY+LrciS2dULt NOuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:organization:references :in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=jci/hJJqL6ly2YUoperGvaN6pTyMaACUogtKkamRhYc=; b=kZJr1STcOpGhO1ZtIvkuAYfRmfImupdDC2sbcPAK0bujiHZeCgAtA4h9czflxed9Nf d9Cb3hF52Qgxdg/cTzp55hdRIqKF1weud/mBiUJ2e8/0VYrWuaj27AhwkNq5ssT9X9Lw y3E46znXHI5m+IUe/EjkCdps/aW1eKvHW0SOTnBrWLQ5DHjtONhhNY9sWzW/Yf9dTo1J X4VpjApKdEosxUfCpr4AJOfMLdxbT+Vs1tzoYh419Pm3y8NhJeuAKXvM+Y0rhLP90Dte X3wMe5UEqPcHv9Tn624oEbXkcuA5zW3zuUeG29Do2WW3iKmldYP5dV0H6AxcwC79G7Os bdLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g15-v6si1599412pgp.168.2018.04.27.11.10.05; Fri, 27 Apr 2018 11:10:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757973AbeD0SIc (ORCPT + 99 others); Fri, 27 Apr 2018 14:08:32 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40878 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757289AbeD0SI3 (ORCPT ); Fri, 27 Apr 2018 14:08:29 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 49EAE4025F12; Fri, 27 Apr 2018 18:08:28 +0000 (UTC) Received: from haswell-e.nc.xsintricity.com (ovpn-122-18.rdu2.redhat.com [10.10.122.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB113215CDCB; Fri, 27 Apr 2018 18:08:27 +0000 (UTC) Message-ID: <1524852507.11756.69.camel@redhat.com> Subject: Re: [PATCH] IB/ipoib: fix ipoib_start_xmit()'s return type From: Doug Ledford To: Leon Romanovsky , Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe , Alex Vesker , Yuval Shaia , Erez Shitrit , Dasaratharaman Chandramouli , Feras Daoud , linux-rdma@vger.kernel.org Date: Fri, 27 Apr 2018 14:08:27 -0400 In-Reply-To: <20180425153532.GM24820@mtr-leonro.local> References: <20180424131549.2859-1-luc.vanoostenryck@gmail.com> <20180425153532.GM24820@mtr-leonro.local> Organization: Red Hat, Inc. Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-bG1LVjLBjd3Y/MM/shNy" Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 27 Apr 2018 18:08:29 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 27 Apr 2018 18:08:29 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dledford@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-bG1LVjLBjd3Y/MM/shNy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2018-04-25 at 18:35 +0300, Leon Romanovsky wrote: > On Tue, Apr 24, 2018 at 03:15:47PM +0200, Luc Van Oostenryck wrote: > > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > > which is a typedef for an enum type, but the implementation in this > > driver returns an 'int'. > >=20 > > Fix this by returning 'netdev_tx_t' in this driver too. > >=20 > > Signed-off-by: Luc Van Oostenryck > > --- > > drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 >=20 > Thanks, > Reviewed-by: Leon Romanovsky Thanks, applied to for-rc. --=20 Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint =3D AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD --=-bG1LVjLBjd3Y/MM/shNy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEErmsb2hIrI7QmWxJ0uCajMw5XL90FAlrjZxsACgkQuCajMw5X L90tww//S79P5V5HEX7illwIe/FJMZzD9ZFWWkm57b+59kkowgeGiVdbPcHXqvvA Z/998m8pLZJdg+emudTYKcL9RY9PzNnrnjTV5rzfvngqGLkevdAVcAwQI4YfbHHI Q4+nWz9SuuVbxRGUzHcWtwY0dcPfmzoyy24YjJyLJnPHceqbsBMYQUEG0zw34GOB rwNNjTffQm1m+/ju8R+72j06w8bB7RhalVdYIs3Wy7ooPAa9DGhHXIhgtuJzjH7r VhkEj4sSeH6rCl7SnSnRba/UTPSNCavoW8WL7CcRNHgXoD1LflWNRT3AGyeFo2w5 aT2gOlJEgQ/UJusQTGN+fefiMGMRhAPZaDNPHWvWCTWqjQUK3Obso/bAF80IKA4P PIWkTUHmbNY+spQQNzTSFryqXA3MDmQMa9KH7Zjlp+MqL7VM0B0zz8Pe73ZqjC4i KW0KmHiUHpnVPB6nwdz5wFE3ar1e8qyN+mr6TFl1j3x6ZfzWXDwe8B6XhLQCOJxE GnvGeoobZkt1rQ1culFY8+ROsqGOKvHBai3CDQ+9pMklIsTsz7zDM/gbhpi5/9fG jbOJzK76D/XJkwvfcRI3n1eQh2XgXFmySod5r/lGJPhyo8iCOXnl1p0gEtlP36xV dGaoEesniOCYmIZB6gjI6sJxpQJCgdGLYHZPvJ9pvi3477ZdT84= =rtig -----END PGP SIGNATURE----- --=-bG1LVjLBjd3Y/MM/shNy--