Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180427095817.74bf5378@endymion>
References: <20180424211111.140374-1-sjg@chromium.org> <20180427095817.74bf5378@endymion>
From:   Simon Glass <sjg@chromium.org>
Date:   Fri, 27 Apr 2018 13:12:05 -0600
Message-ID: <CAPnjgZ0y9GhA12dvM8aW_AY30LzbdgYDc4JJ0aXWudAUU8kz7g@mail.gmail.com>
Subject: Re: [PATCH] firmware: dmi: Add access to the SKU ID string
To:     Jean Delvare <jdelvare@suse.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        C Shapiro <shapiroc@chromium.org>,
        Aaron Durbin <adurbin@chromium.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Alex Hung <alex.hung@canonical.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        sayli karnik <karniksayli1995@gmail.com>,
        Vinod Koul <vinod.koul@intel.com>,
        Sagar Dharia <sdharia@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jean,

On 27 April 2018 at 01:58, Jean Delvare <jdelvare@suse.de> wrote:
> Hi Simon,
>
> On Tue, 24 Apr 2018 15:11:11 -0600, Simon Glass wrote:
>> This is used in some systems from user space for determining the identity
>> of the device.
>>
>> Expose this as a file so that that user-space tools don't need to read
>> from /sys/firmware/dmi/tables/DMI
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>>  drivers/firmware/dmi-id.c       | 2 ++
>>  drivers/firmware/dmi_scan.c     | 1 +
>>  include/linux/mod_devicetable.h | 1 +
>>  3 files changed, 4 insertions(+)
>> (...)
>
> Looks good to me. Applied, thanks. For consistency I have moved product
> SKU before product family in all files, same order as in the DMI entry
> itself.

Sounds good, thanks.

- Simon