Received: by 10.192.165.148 with SMTP id m20csp1135652imm; Fri, 27 Apr 2018 13:22:47 -0700 (PDT) X-Google-Smtp-Source: AB8JxZovn6dQSVn8OpKAVR4o69PjrbLa1i10bMC88y1pLb+eZWTMdE2XuGlFBaPKx1pzvipSgSLo X-Received: by 10.98.133.154 with SMTP id m26mr3345798pfk.247.1524860567072; Fri, 27 Apr 2018 13:22:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524860567; cv=none; d=google.com; s=arc-20160816; b=04ROlIMY0CL4GxPUcdW6TVMyRbSEsr6751rCko2Pg/AVnkqDHs+YZSlMUpQt5MORXT bEJ5aWgGqbTymDXbc9s2pWQPjSfshxQ1IO5fcSt7ZU5ZN9sXnZ5xxIsQ/uamnWQV66vD wfkw1vn3p7v95DLzzt0aNXayIQC63RFRxYQlZKxcilbhoOr3VgMZqEEtLOfERhYkM1Hz dl0E6wCV0kKb5ZcYZ9e0w9GXBe1WlGWzKBdHKAnFpnVxSWRe1SmjBl5JfZy2alCZGzel ftvip/LJG6f6+dyv2KMsaMJeIRdo9SkyJ6IKQ8YKSpeC3huvf7+kb59HmSRxQhCRuFZN t5ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=cwPGgAQJ5Ndlel+fQkyqyEV8kHGuvNQGyU61JemguKc=; b=gZNhauTP68wxtW50PED8iGNdUaODheYYrFbO9hTnK4jMVcAFM8JRhCyeUPfdAQSNqN 5eoNXAbubIZiXY1U+ewBUe8VWB47NSjtEV1PU6WUp5C/X8KT/pLW6C2Spyla0FypDGop Incm4wvRwf4FHekE6GObDYPNwUkmVc3RtLX/RXEEgBFNA+8jAuvXn1CRGi9Cru3pjoj1 Az9fVNBPhGIlWMbJm3DcobY1DTO55QJlmFrOFm7fItje22qpUwrC/TyOiIUMGkhGramh MylbV30WAAUqV2K5PfUUVDahA/139P3SIB2m7Xzc/A4X7VCuDmDREj/+Irvdm2SFTRm0 PLaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1-v6si1708785plr.6.2018.04.27.13.22.32; Fri, 27 Apr 2018 13:22:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759162AbeD0UVZ (ORCPT + 99 others); Fri, 27 Apr 2018 16:21:25 -0400 Received: from www62.your-server.de ([213.133.104.62]:60965 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758944AbeD0UVY (ORCPT ); Fri, 27 Apr 2018 16:21:24 -0400 Received: from [62.202.221.10] (helo=linux.home) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256) (Exim 4.85_2) (envelope-from ) id 1fC9rq-0007WU-4V; Fri, 27 Apr 2018 22:21:18 +0200 Subject: Re: [PATCH 2/2] bpf: btf: remove a couple conditions To: Dan Carpenter , Martin KaFai Lau Cc: Alexei Starovoitov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20180427140459.GB19583@mwanda> <20180427172023.6japncdd3nbqauzn@kafai-mbp> <20180427175544.vydqf4iufopcyv6d@kafai-mbp> <20180427193959.3nebosalgl3ch4mv@mwanda> From: Daniel Borkmann Message-ID: <21126ae9-5178-5d09-679c-6bca57ad48e8@iogearbox.net> Date: Fri, 27 Apr 2018 22:21:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180427193959.3nebosalgl3ch4mv@mwanda> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.99.3/24518/Fri Apr 27 14:29:17 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/27/2018 09:39 PM, Dan Carpenter wrote: > On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: >> On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: >>> On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote: >>>> We know "err" is zero so we can remove these and pull the code in one >>>> indent level. >>>> >>>> Signed-off-by: Dan Carpenter >>> Thanks for the simplification! >>> >>> Acked-by: Martin KaFai Lau >> btw, it should be for bpf-next. Please tag the subject with bpf-next when >> you respin. Thanks! Dan, thanks a lot for your fixes! Please respin with addressing Martin's feedback when you get a chance. Thanks, Daniel