Received: by 10.192.165.148 with SMTP id m20csp1211372imm; Fri, 27 Apr 2018 14:57:23 -0700 (PDT) X-Google-Smtp-Source: AB8JxZr065ILK9UoSJfxgX6LN7vmcIKR2iEeLUM+UnK9BfEPOAcnQc9soNjsEnxHjjx4jRmLIriQ X-Received: by 2002:a17:902:9686:: with SMTP id n6-v6mr3680605plp.136.1524866243169; Fri, 27 Apr 2018 14:57:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524866243; cv=none; d=google.com; s=arc-20160816; b=Mvy6fOqkgK9tjPqsJjB0zB1UsTreiXg9Pq0ZJwD7lgBBkyy3bBP0xVErk9vNB4twuO MvrkPLZfuv/IzNZASyAu1jHWmsmfIT0LS7XSYFzdMCz6UCqtmJYBj3TuiaFOFDJVtiKr XBsocidyJvfrmNKEGmwApN+ulgMKBGqP/h4be36O3mJetCZmdmSFlyGKF+tNj3iItW3V 1uN9wIP63+DW1vZLLudJj4wTx8kRlgxhgJY9Tci9d+e4aih3AdnrQPq2Ks1AbJbyBh0c zTz8teQkpf6RVvEwJMKpewOoW70mdKj5r9gfG+MeKytRIeboF2NoHecP0IP0N/rD+36r Nb9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=uK0NJAvRPjupk588Okhrnc02tlNYSM/pQ81rwuf40Kw=; b=MBrGQLWReXXsKmv/rPfNu66pbQlVZgMTi+AR9cmzP0CFZ5/iSrBXTFovLM/lVngVHx xR+jSrIaUwbMhKsRH0qmaieUNcCfH93XzcD6PjvfFg3yAtr3aeYhfCpT+Kb4miF6QAOX dR1HwGNijjAMuctjcw35JaROgUEvFjRR4OUnMaFimy7bEOWQZynFk50OfMrRa1LdzjCs Q46+C6CUbWK1Mn3cnklwV/iGyNFeyU6d/iFc591vNaKVg3m4lDLvNcIN0WqR1WSdiBkP i4gTSGHYLoMqMMAoe+rQSoE0KZo0mWxZ8yUuElV7a6Ka/6Hezq0C7IWU/3RBiYpNvAF+ Xu+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7-v6si1919783pgf.652.2018.04.27.14.57.07; Fri, 27 Apr 2018 14:57:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759387AbeD0Vzv (ORCPT + 99 others); Fri, 27 Apr 2018 17:55:51 -0400 Received: from mail.efficios.com ([167.114.142.138]:54964 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759307AbeD0Vzu (ORCPT ); Fri, 27 Apr 2018 17:55:50 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 8D1991AF1A0; Fri, 27 Apr 2018 17:55:49 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail02.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id iQTFm5IxCI85; Fri, 27 Apr 2018 17:55:48 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id B0C7E1AF193; Fri, 27 Apr 2018 17:55:48 -0400 (EDT) X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail02.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id QmFU2j3rqxmd; Fri, 27 Apr 2018 17:55:48 -0400 (EDT) Received: from thinkos.internal.efficios.com (192-222-157-41.qc.cable.ebox.net [192.222.157.41]) by mail.efficios.com (Postfix) with ESMTPSA id 8E4FD1AF189; Fri, 27 Apr 2018 17:55:48 -0400 (EDT) From: Mathieu Desnoyers To: Shuah Khan Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , linux-kselftest@vger.kernel.org Subject: [PATCH 4.17-rc2] selftests: Fix lib.mk run_tests target shell script Date: Fri, 27 Apr 2018 17:55:41 -0400 Message-Id: <20180427215541.25007-1-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Within run_tests target, the whole script needs to be executed within the same shell and not as separate subshells, so the initial test_num variable set to 0 is still present when executing "test_num=`echo $$test_num+1 | bc`;". Demonstration of the issue (make run_tests): TAP version 13 (standard_in) 1: syntax error selftests: basic_test ======================================== ok 1.. selftests: basic_test [PASS] (standard_in) 1: syntax error selftests: basic_percpu_ops_test ======================================== ok 1.. selftests: basic_percpu_ops_test [PASS] (standard_in) 1: syntax error selftests: param_test ======================================== ok 1.. selftests: param_test [PASS] With fix applied: TAP version 13 selftests: basic_test ======================================== ok 1..1 selftests: basic_test [PASS] selftests: basic_percpu_ops_test ======================================== ok 1..2 selftests: basic_percpu_ops_test [PASS] selftests: param_test ======================================== ok 1..3 selftests: param_test [PASS] Signed-off-by: Mathieu Desnoyers Fixes: 1f87c7c15d7 ("selftests: lib.mk: change RUN_TESTS to print messages in TAP13 format") CC: Shuah Khan CC: linux-kselftest@vger.kernel.org --- tools/testing/selftests/lib.mk | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index 195e9d4739a9..c1b1a4dc6a96 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -20,10 +20,10 @@ all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) .ONESHELL: define RUN_TESTS - @export KSFT_TAP_LEVEL=`echo 1`; - @test_num=`echo 0`; - @echo "TAP version 13"; - @for TEST in $(1); do \ + @export KSFT_TAP_LEVEL=`echo 1`; \ + test_num=`echo 0`; \ + echo "TAP version 13"; \ + for TEST in $(1); do \ BASENAME_TEST=`basename $$TEST`; \ test_num=`echo $$test_num+1 | bc`; \ echo "selftests: $$BASENAME_TEST"; \ -- 2.11.0