Received: by 10.192.165.148 with SMTP id m20csp1327952imm; Fri, 27 Apr 2018 17:43:40 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrB9AtNt24iKa5eZo9UfRJOkB8OzQvXi9jLCz5WCVajNALs2sAfhx7YR5pHz991o4O2NTco X-Received: by 2002:a63:41c7:: with SMTP id o190-v6mr3824657pga.57.1524876220600; Fri, 27 Apr 2018 17:43:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524876220; cv=none; d=google.com; s=arc-20160816; b=gPqN5EtUE2hctKCxXgs4Xu5/hijkmh0ElgXPvPMNAE0PyIcMCK6t16wuFEUfoXFi+U M+Z0VUnw3YwVFe+tiezd6duwar+2O3n779QvM0bzM3ISMWvzGrpIOpThP3BPV9wRR1q2 YSjKldO9iaA1ojWu2jI5RLRwWipv7uJEs/W6G5aBwtz9N9norEvTIWBC8PlkJY9ZZJc1 acVTDwkznQt/aiMScI2/QHhsrft/jb/5OnAEo8BvWQ5tfxz229ogex1fn0fV18NO87rh F1nrjKDXjNFgPvMQ72f6hpnkBQ41xXWDDPcy3eP9lm1YGE6Vvbw+hK+r8aabnD/RJUN+ PuLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :arc-authentication-results; bh=60YIjH+ei45sDlmbf4NtThTY0Jh7ybhUXSH6Ss/mp10=; b=onUNfJh8qIZdzd0u0W4wciSHC8fdQZRDH1qNMhXzbP7hhjR8z3rL89a1uIcaxflGaX eY9Naw9Xkp+lkQkv2y3O2HHHhzBdOyCkQulhe5ndoVWdPgAbGH1XnVAYushTlCooxO83 6jCwt0vcONn0UgfBHT5CCa2qMZBF4GGZl+afQccaFv2VqTbr//rLDAy4eyrja+8s9H+z lFDuRqYhBw20KCOGpBPp6pFikRs4XbE0rjcUGSI5X1GdKsosVmHt6zqF+kQPApPDpzPe 2UaufI8eGC1nwTbDu5iO8IK9GiPXlf9Qf4kpLMUu3PQa7/8gAdk5cUzGSH6BU9hu14et G0vQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d9-v6si2280071plj.573.2018.04.27.17.43.24; Fri, 27 Apr 2018 17:43:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933231AbeD1AmJ (ORCPT + 99 others); Fri, 27 Apr 2018 20:42:09 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49962 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754447AbeD1AmH (ORCPT ); Fri, 27 Apr 2018 20:42:07 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D870D42709C0; Sat, 28 Apr 2018 00:42:06 +0000 (UTC) Received: from [10.36.116.63] (ovpn-116-63.ams2.redhat.com [10.36.116.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 114F32023227; Sat, 28 Apr 2018 00:42:03 +0000 (UTC) Subject: Re: [PATCH 2/2] kvm: nVMX: Introduce KVM_CAP_STATE To: Jim Mattson Cc: "Raslan, KarimAllah" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "x86@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , "rkrcmar@redhat.com" References: <1523545958-28059-1-git-send-email-karahmed@amazon.de> <1523545958-28059-2-git-send-email-karahmed@amazon.de> <1523898937.22952.13.camel@amazon.de> From: Paolo Bonzini Openpgp: preference=signencrypt Autocrypt: addr=pbonzini@redhat.com; prefer-encrypt=mutual; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0f UGFvbG8gQm9uemluaSA8Ym9uemluaUBnbnUub3JnPsLBTQQTAQIAIwUCVEJ7AwIbAwcLCQgH AwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEH4VEAzNNmmxNcwOniaZVLsuy1lW/ntYCA0Caz0i sHpmecK8aWlvL9wpQCk4GlOX9L1emyYXZPmzIYB0IRqmSzAlZxi+A2qm9XOxs5gJ2xqMEXX5 FMtUH3kpkWWJeLqe7z0EoQdUI4EG988uv/tdZyqjUn2XJE+K01x7r3MkUSFz/HZKZiCvYuze VlS0NTYdUt5jBXualvAwNKfxEkrxeHjxgdFHjYWhjflahY7TNRmuqPM/Lx7wAuyoDjlYNE40 Z+Kun4/KjMbjgpcF4Nf3PJQR8qXI6p3so2qsSn91tY7DFSJO6v2HwFJkC2jU95wxfNmTEUZc znXahYbVOwCDJRuPrE5GKFd/XJU9u5hNtr/uYipHij01WXal2cce1S5mn1/HuM1yo1u8xdHy IupCd57EWI948e8BlhpujUCU2tzOb2iYS0kpmJ9/oLVZrOcSZCcCl2P0AaCAsj59z2kwQS9D du0WxUs8waso0Qq6tDEHo8yLCOJDzSz4oojTtWe4zsulVnWV+wu70AioemAT8S6JOtlu60C5 dHgQUD1Tp+ReXpDKXmjbASJx4otvW0qah3o6JaqO79tbDqIvncu3tewwp6c85uZd48JnIOh3 utBAu684nJakbbvZUGikJfxd887ATQRUQnHuAQgAx4dxXO6/Zun0eVYOnr5GRl76+2UrAAem Vv9Yfn2PbDIbxXqLff7oyVJIkw4WdhQIIvvtu5zH24iYjmdfbg8iWpP7NqxUQRUZJEWbx2CR wkMHtOmzQiQ2tSLjKh/cHeyFH68xjeLcinR7jXMrHQK+UCEw6jqi1oeZzGvfmxarUmS0uRuf fAb589AJW50kkQK9VD/9QC2FJISSUDnRC0PawGSZDXhmvITJMdD4TjYrePYhSY4uuIV02v02 8TVAaYbIhxvDY0hUQE4r8ZbGRLn52bEzaIPgl1p/adKfeOUeMReg/CkyzQpmyB1TSk8lDMxQ zCYHXAzwnGi8WU9iuE1P0wARAQABwsEzBBgBAgAJBQJUQnHuAhsMAAoJEH4VEAzNNmmxp1EO oJy0uZggJm7gZKeJ7iUpeX4eqUtqelUw6gU2daz2hE/jsxsTbC/w5piHmk1H1VWDKEM4bQBT uiJ0bfo55SWsUNN+c9hhIX+Y8LEe22izK3w7mRpvGcg+/ZRG4DEMHLP6JVsv5GMpoYwYOmHn plOzCXHvmdlW0i6SrMsBDl9rw4AtIa6bRwWLim1lQ6EM3PWifPrWSUPrPcw4OLSwFk0CPqC4 HYv/7ZnASVkR5EERFF3+6iaaVi5OgBd81F1TCvCX2BEyIDRZLJNvX3TOd5FEN+lIrl26xecz 876SvcOb5SL5SKg9/rCBufdPSjojkGFWGziHiFaYhbuI2E+NfWLJtd+ZvWAAV+O0d8vFFSvr iy9enJ8kxJwhC0ECbSKFY+W1eTIhMD3aeAKY90drozWEyHhENf4l/V+Ja5vOnW+gCDQkGt2Y 1lJAPPSIqZKvHzGShdh8DduC0U3xYkfbGAUvbxeepjgzp0uEnBXfPTy09JGpgWbg0w91GyfT /ujKaGd4vxG2Ei+MMNDmS1SMx7wu0evvQ5kT9NPzyq8R2GIhVSiAd2jioGuTjX6AZCFv3ToO 53DliFMkVTecLptsXaesuUHgL9dKIfvpm+rNXRn9wAwGjk0X/A== Message-ID: <724a2ae2-e38f-148c-ce29-9869b2ab535f@redhat.com> Date: Sat, 28 Apr 2018 02:42:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Sat, 28 Apr 2018 00:42:06 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Sat, 28 Apr 2018 00:42:06 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'pbonzini@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/04/2018 17:19, Jim Mattson wrote: > > If the default treatment of SMIs and SMM (see Section 34.14) is > active, the VMX-preemption timer counts across an SMI to VMX non-root > operation, subsequent execution in SMM, and the return from SMM via > the RSM instruction. However, the timer can cause a VM exit only from > VMX non-root operation. If the timer expires during SMI, in SMM, or > during RSM, a timer-induced VM exit occurs immediately after RSM with > its normal priority unless it is blocked based on activity state > (Section 25.2). > > So, there's no loophole here that allows us to reset the VMX > preemption timer when restoring nested state. Or when an SMI occurs. So the expiration TSC of the preemption timer should be stored into an "artificial" field of the vmcs12 at vmentry time and later reused. vmx->nested.smm.guest_node should also be saved... Paolo > As a follow-on change, we should probably fix this.