Received: by 10.192.165.148 with SMTP id m20csp1482378imm; Fri, 27 Apr 2018 22:02:02 -0700 (PDT) X-Google-Smtp-Source: AB8JxZozaeP/1E7cTLPCP0eIAsFL7PD0Ge62CEKL/J7bIj3WMRChoiJQA+t+JrtJ/7wuFFHMfK8D X-Received: by 2002:a63:2c12:: with SMTP id s18-v6mr4257591pgs.427.1524891722340; Fri, 27 Apr 2018 22:02:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524891722; cv=none; d=google.com; s=arc-20160816; b=K5RanHfPmpG5oK7X8sEDudo6sL4j3UxmSEtkZpTf/APK9MN4FrGx7gCL5ZM0BIvVjq D1TUYxQUDZytjzW0oQxf0ihJrHtXP/6yQURYczHmaXlqNcqpHum3kAj6I1JbauGTUWiE jM8MzMe7VlRjrm0wdtIt9OfYt4ZYJwESzdQX3Hk1eiRTi+W8RRvdVNrXQzmJRZdz26vw Z4Mn8WNehQZxynCtRSyer9m0gkz7YqzUXM2KNcBzg/05DQ2iFrFRpJG9GJSYOvqn9+fX z/MBga354cAV16f9FPTX6T/QYTjUOP+uuS1tn512VqhCPdft3Jltsbbh4H9UQ/yEr9fg CzGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dmarc-filter:arc-authentication-results; bh=OdN3gBV9z6fFPKul8viVi9Sq7/uZOxg+DCg98TFZM4Q=; b=TUVG57ZQh6ymMaPKaIGivkrIGL0letwHJyRn/lc8ubfNwJHanHoZ7lYL+jGH4T9F3J Oaf+QOKeV1TAtRcYeWZbxe2yJAF4sUDhvPXri4R6lPtv5fQZS4y7yMlqcRYk6R0SVS2b vqqMueE3cvUq4Tq9bZE/ftOnE95S8rDkF/6Hd5khEFhK9FxAS+iCGtyPC5omrT8p7rXZ dUTXp0Lh5MfMZosc6g0nbqLwLKqnld+ugZYlONS8zl+95MijpM6xGcnKQUUE/TNhiJx6 ZFM/lqYtRtlI/4ZDCq+OhhV3Z2Pu2G/xyE6dIQwQiJh8ak2ySWdpUeUN/o8fnR/utcUw ra4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i74si2825915pfd.105.2018.04.27.22.01.46; Fri, 27 Apr 2018 22:02:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751945AbeD1FAh (ORCPT + 99 others); Sat, 28 Apr 2018 01:00:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:42114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303AbeD1FAg (ORCPT ); Sat, 28 Apr 2018 01:00:36 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B3CD21938; Sat, 28 Apr 2018 05:00:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B3CD21938 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=gregkh@linuxfoundation.org Date: Sat, 28 Apr 2018 07:00:26 +0200 From: Greg Kroah-Hartman To: Randy Dunlap Cc: Teck Choon Giam , LKML , Peter Zijlstra , Ingo Molnar , acme@kernel.org, Alexander Shishkin , Jiri Olsa Subject: Re: kernel-4.9.94 compile error: 'KMOD_DECOMP_LEN' undeclared Message-ID: <20180428050026.GA29422@kroah.com> References: <84b1d534-9b9d-ff70-ead6-3f8bb70a4d4b@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84b1d534-9b9d-ff70-ead6-3f8bb70a4d4b@infradead.org> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 27, 2018 at 10:28:27AM -0700, Randy Dunlap wrote: > [adding some Cc:] > > On 04/14/2018 02:41 AM, Teck Choon Giam wrote: > > Hi, > > > > Compile linux-4.9.94 will have error related to KMOD_DECOMP_LEN > > undeclared. Searching string related to KMOD_DECOMP_LEN in > > linux-4.9.94 and linux-4.15.17 sources as below: > > > > sh-4.2# grep -r KMOD_DECOMP_LEN ./linux-4.15.17 > > ./linux-4.15.17/tools/perf/tests/code-reading.c: char > > decomp_name[KMOD_DECOMP_LEN]; > > ./linux-4.15.17/tools/perf/util/dso.h:#define KMOD_DECOMP_LEN > > sizeof(KMOD_DECOMP_NAME) > > ./linux-4.15.17/tools/perf/util/annotate.c: char tmp[KMOD_DECOMP_LEN]; > > ./linux-4.15.17/tools/perf/util/dso.c: char newpath[KMOD_DECOMP_LEN]; > > sh-4.2# grep -r KMOD_DECOMP_LEN ./linux-4.9.94 > > ./linux-4.9.94/tools/perf/tests/code-reading.c: char > > decomp_name[KMOD_DECOMP_LEN]; > > ./linux-4.9.94/tools/perf/util/dso.c: char newpath[KMOD_DECOMP_LEN]; > > > > So I guess for linux-4.9.94 has not define KMOD_DECOMP_LEN in > > tools/perf/util/dso.h? > > > 4.9.9[456] lack: > #define KMOD_DECOMP_NAME "/tmp/perf-kmod-XXXXXX" > #define KMOD_DECOMP_LEN sizeof(KMOD_DECOMP_NAME) > > > However, the commit that added those macros does not apply cleanly to 4.9.96. > > commit 42b3fa670825983fc8bd0ac7b80cc84ae3abb75b > Author: Namhyung Kim > Date: Thu Jun 8 16:31:03 2017 +0900 > > perf tools: Introduce dso__decompress_kmodule_{fd,path} This should now be fixed in the latest 4.9.y -rc release, right? If not, please let me know as I though I resolved this problem there... thanks, greg k-h