Received: by 10.192.165.148 with SMTP id m20csp1601972imm; Sat, 28 Apr 2018 01:12:58 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoOD2j1MlsANgZvjYDNJ5SwOlbI20OyCo5Sz6iRbMAO8KTjkCvYEmarKPjxobbGAKpcfpq+ X-Received: by 2002:a63:10a:: with SMTP id 10-v6mr4525242pgb.444.1524903178580; Sat, 28 Apr 2018 01:12:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524903178; cv=none; d=google.com; s=arc-20160816; b=BbTn6KuVv+oJx1zJNbzNOYqZsmkpwXxBB9+AObvU3rSbsQgOuXf7waNFHZwgT8EVYF X9Gqy4pzb+r12WO2EgJn5YvDLTW2vFrYdCYbu88DON65mLAn3DciPVELBYmcyWIECUHH 3avRIDC2uWkzMAmAhQyD9J++N5YKRvT4harH7jbVO1uQptj/e1Kl5YS0+pvr5Cfwayde GA+jx3jWWz+oGcmJCNWPEEd8bjcrtIvekBVT69DePS6uA5uovBrTvHYMmdBGGUBHe6j9 nLXahTscivgiptRMr5qzU5ckDicPK9oZFUO7D/h5cYDx8AM8ctnD0fgSKq7fARyloiNb fABQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dmarc-filter:arc-authentication-results; bh=kYM8SZ1R8M35nX0sAxEPN4GLOvT0sBCFkvqWAK1+cM4=; b=jirroDaFHKW8CP4GjO7KW4r2xqm+grj3kUJ0pJBNUFaRlu9AEjsXnQ49JzZHhVd02q r0A3+P/iXASNx0OQcpmTmuZp7tRlJSqS4V88IDiuZWv26ofpRZEvc8hOSCrBgjK9rfZV 1U7cHslw2EUcGrbxf0mY5Ns7qO/ED1/cUCsT7UG+NVZ7AZ4kmMAOOVHNoLk3ILIk3DE2 TfGw8UMijHgph+7mUdE2oaC9JIwRovTTVd2/iGE8gy3uwU+cAO0L3MzdMNG3C0ChxJeu +M5l9ezWSy0GARW6ihFdSgPUZicfjtYS9gPyVydvy9aQvlvAJ8ZRqBft7PeAR4XNwd7S B+xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b97-v6si3113655plb.135.2018.04.28.01.12.44; Sat, 28 Apr 2018 01:12:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759651AbeD1ILg (ORCPT + 99 others); Sat, 28 Apr 2018 04:11:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:57060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753304AbeD1ILd (ORCPT ); Sat, 28 Apr 2018 04:11:33 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD0CC21993; Sat, 28 Apr 2018 08:11:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD0CC21993 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=gregkh@linuxfoundation.org Date: Sat, 28 Apr 2018 10:11:22 +0200 From: Greg Kroah-Hartman To: Randy Dunlap Cc: Teck Choon Giam , LKML , Peter Zijlstra , Ingo Molnar , acme@kernel.org, Alexander Shishkin , Jiri Olsa Subject: Re: kernel-4.9.94 compile error: 'KMOD_DECOMP_LEN' undeclared Message-ID: <20180428081122.GA27926@kroah.com> References: <84b1d534-9b9d-ff70-ead6-3f8bb70a4d4b@infradead.org> <20180428050026.GA29422@kroah.com> <5a56f585-d3c1-ee42-20a3-b47921f160c4@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a56f585-d3c1-ee42-20a3-b47921f160c4@infradead.org> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 27, 2018 at 11:09:56PM -0700, Randy Dunlap wrote: > On 04/27/2018 10:00 PM, Greg Kroah-Hartman wrote: > > On Fri, Apr 27, 2018 at 10:28:27AM -0700, Randy Dunlap wrote: > >> [adding some Cc:] > >> > >> On 04/14/2018 02:41 AM, Teck Choon Giam wrote: > >>> Hi, > >>> > >>> Compile linux-4.9.94 will have error related to KMOD_DECOMP_LEN > >>> undeclared. Searching string related to KMOD_DECOMP_LEN in > >>> linux-4.9.94 and linux-4.15.17 sources as below: > >>> > >>> sh-4.2# grep -r KMOD_DECOMP_LEN ./linux-4.15.17 > >>> ./linux-4.15.17/tools/perf/tests/code-reading.c: char > >>> decomp_name[KMOD_DECOMP_LEN]; > >>> ./linux-4.15.17/tools/perf/util/dso.h:#define KMOD_DECOMP_LEN > >>> sizeof(KMOD_DECOMP_NAME) > >>> ./linux-4.15.17/tools/perf/util/annotate.c: char tmp[KMOD_DECOMP_LEN]; > >>> ./linux-4.15.17/tools/perf/util/dso.c: char newpath[KMOD_DECOMP_LEN]; > >>> sh-4.2# grep -r KMOD_DECOMP_LEN ./linux-4.9.94 > >>> ./linux-4.9.94/tools/perf/tests/code-reading.c: char > >>> decomp_name[KMOD_DECOMP_LEN]; > >>> ./linux-4.9.94/tools/perf/util/dso.c: char newpath[KMOD_DECOMP_LEN]; > >>> > >>> So I guess for linux-4.9.94 has not define KMOD_DECOMP_LEN in > >>> tools/perf/util/dso.h? > >> > >> > >> 4.9.9[456] lack: > >> #define KMOD_DECOMP_NAME "/tmp/perf-kmod-XXXXXX" > >> #define KMOD_DECOMP_LEN sizeof(KMOD_DECOMP_NAME) > >> > >> > >> However, the commit that added those macros does not apply cleanly to 4.9.96. > >> > >> commit 42b3fa670825983fc8bd0ac7b80cc84ae3abb75b > >> Author: Namhyung Kim > >> Date: Thu Jun 8 16:31:03 2017 +0900 > >> > >> perf tools: Introduce dso__decompress_kmodule_{fd,path} > > > > This should now be fixed in the latest 4.9.y -rc release, right? > > > > If not, please let me know as I though I resolved this problem there... > > It still fails in 4.9.96. (not #defined there) Should be fixed in 4.9.97-r1, I know .96 still had the issue. thanks, greg k-h