Received: by 10.192.165.148 with SMTP id m20csp1791997imm; Sat, 28 Apr 2018 05:40:00 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoy8CujCyVt6jEocw4s4hfAkyoYwSLMYVzC4II/1NdtoRREFMMkkjnT29ClmJJoetjm4ywg X-Received: by 2002:a17:902:5785:: with SMTP id l5-v6mr5690807pli.379.1524919200265; Sat, 28 Apr 2018 05:40:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524919200; cv=none; d=google.com; s=arc-20160816; b=gHhZCL8rUsTP6rn87QxmKdK2tt7k8LgWkmlYHebDlmVfiBzv3hf43ufu0tvSZhMPTO uwNZMa0IaHXvM2UayqTu0fB/hZc6abk16IKky9daXEA1qponIROBjPtoaR88evnKjme0 0/acytrgyHIByVGir98hvPwZlbe/zcrX7qECFwYy/w+82Ig+TW3Y/7pDG8CegFBMrdl8 wL/YFs6qrWDVku90ZIHOAe7YCLMn7hrK0W0kjKPAmK6x033cMJjGLmcVQRDtQpIjZ+fF brP4J8MK/i2Cgs0Dy085wDkJ666kYhML7btbRIwzFNFgXAiZhUojuY++156/JLHWkmQQ x8jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=JZOJZVL1+Rsx8NVCQdnouiDxKhG6qpausGozvR/c2ow=; b=PoNagmNafcleJstiYab81HaAy/1ciFjSU5YnXkWWRWC+xsBz4cdr3gi+qduFH/GjRo SoohJIpWJ/XaXu6GbcEqATf/scr7LTI+5LpHqkYZ74GV0cEEI1sB4ScNm6YPIcnV3W1B N0TRmb/MIZq8MlrzgccvS7LV9LFg2Q41FlyzZwQ5Za3uUL5htxlPYzT18NKSmnvuO5M6 Nw/V+oSDoxYH5TLdowAxap8VTqb3q2I/zRA6gcjE941cYhfWHqrKihfLxOEkye3KTstb sDzxR/p9mfD8hG2omMzcqdIzJwQZ056GYvEaowuzwQdh0/QjWZR31REKSZF1LjyATnQk E3pA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x22si3417584pfe.318.2018.04.28.05.39.46; Sat, 28 Apr 2018 05:40:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933484AbeD1Mim (ORCPT + 99 others); Sat, 28 Apr 2018 08:38:42 -0400 Received: from sauhun.de ([88.99.104.3]:57468 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759778AbeD1Mil (ORCPT ); Sat, 28 Apr 2018 08:38:41 -0400 Received: from localhost (p54B33D0E.dip0.t-ipconnect.de [84.179.61.14]) by pokefinder.org (Postfix) with ESMTPSA id 5948D32475C; Sat, 28 Apr 2018 14:38:39 +0200 (CEST) Date: Sat, 28 Apr 2018 14:38:38 +0200 From: Wolfram Sang To: David Engraf Cc: ludovic.desroches@microchip.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] i2c: at91: Read all available bytes at once Message-ID: <20180428123838.abxiht7k4egv7iel@ninjato> References: <20180426082558.GX13305@rfolt0960.corp.atmel.com> <20180426095314.12758-1-david.engraf@sysgo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nzns2kqhetuwit6p" Content-Disposition: inline In-Reply-To: <20180426095314.12758-1-david.engraf@sysgo.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nzns2kqhetuwit6p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 26, 2018 at 11:53:14AM +0200, David Engraf wrote: > With FIFO enabled it is possible to read multiple bytes > at once in the interrupt handler as long as RXRDY is > set. This may also reduce the number of interrupts. >=20 > This patch polls RXRDY and reads all available bytes at > once. >=20 > Signed-off-by: David Engraf checkpatch said twice: WARNING: line over 80 characters While I am not super-strict with this limit, it makes sense here IMO. The comment stays readable, and we don't even lose a line. Fixed it this time for you. Applied to for-next, thanks! --nzns2kqhetuwit6p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlrka00ACgkQFA3kzBSg KbZmOg/+IhlsJDzcKMB5N2UOolGljf8oOYDLSslHRZRLb8EjJM5TzbpUA/LzV8lA fyH29EKFbh3Z4MWKzTn4+KnLsgy7q4ZhMsuyc2jBbX1/SblkeeyXRAjnpXln+APW Us77mNu4wU04/q6Tlzs1rg+WWhoLOPbFo8VlTywQQPbE9YtABZpxcDSAVZQcl6sI w38GoKR6mdLZKKQA7ZoSAh9YG8jvqTa4NRHYnF5I1YTLRCsrcje9cAFyASNYd04s pZrYaBzlOeKwlI8hPC1rxtHAm3nwHFTUhS2Oib8c1p7xFM5hjkX54sxFn/BUuwGx R1WOw+UUcuI0IUtKiMHhsEerKuAI7ZM6xkNy9hYtjR675bYNz6a4BK1gxwKEo0Sf jACqmKtBtf5mFbc8F2pQRWhbSHcJInnbmTbfnjJyALFZdFG3jLXdVBUqUc9vSLNK GY1rR4HDlJyCSbiwnSU6hN3uBFarMLvOdorwlS6DfUk0dgvhAzE9XFg/YOQi3SxY n1CNWgPIYXHvf50pL7QwGzPIfCcT+X2+F20KKcvvR4x8CSYS3nNrkSNSz5i79+ea rBaXe1Nqu+v8VO4fkqo4AlTKFYpdeimVEnVKMeEUuPb9l0IUjOMLlqW69fYmmODN xVWEx0TARtm2Kpo+CbdUjWXdKuOJKx4RT2QfNRFW/cHqDWr74VY= =pn8i -----END PGP SIGNATURE----- --nzns2kqhetuwit6p--