Received: by 10.192.165.148 with SMTP id m20csp3479470imm; Mon, 30 Apr 2018 00:27:17 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq64g/lHme19/c2abksBuiA8rgTvbay8DPNVpJQ3LKnMnCUD2x1gP7cXa9sOlEPxHiRWyZz X-Received: by 2002:a65:534d:: with SMTP id w13-v6mr9452397pgr.429.1525073237420; Mon, 30 Apr 2018 00:27:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525073237; cv=none; d=google.com; s=arc-20160816; b=FAPVxNQTSTWHzq08rHcnxN2bvQyWnjowjGIN+fmrru79TstPTUVSPzoAmm8Dux/TjD UN8Y94t2z+hLKnH3eWMKSPlPHv4c1O/60tIe2K0e61WwfcSVJcjH3Vi18jBTDRJbgOPj 6Ee7tk014TwHycZ1sTdCnHbPVh+CgyYtFhdSzbWiCHTLXQlGpVFB+ekJ1RWwYRkxyPy+ 8g5IZ4Jzxl7UxKhtl/tomh//hYjFtuMYQyCce//R+4LxI01M2Dhoplhr/98Z8F+R3hlC IuYoMBgs5dhA+URdSKg0MgGpDfA1M8+lD0xyVpi3uz4Z+VSv2miX4puU+L8fSmtaFm3M awCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=f7wlA6bH1y8ihdbPjFc9CUNZlRcSnTwSoWnuapEbNsg=; b=SG+PbDaG2arJgJj1BFLfhRzUPj4UC1beUnPIhc+WtEMm+Ikpl3vVdQEqU1ItEHghnw dmorBxXgu7Vog6U44zZFP66i+DS6HmKEq44xmnZbDuv3zwWTL2dTKdO3l/2uFj1ATt3p 7hlzurQXcQ+rTLiPuCpjKR+brT4JZIxB9qQ5UfcCzM/bW4R0DTjHz7d1dXzFXkjut+Ov Z09vWtVddIpOzirEQcbt/2loZSlKnV1ZqBzYr613OvVSmADovrGrJmfqGDWu9qN9C3Il ymBhEe6LQIY2R2bdMXGnCYzu0rWUh/IsEJLJzIwglzoff9SCzi+SSDNd+bsIqvMWzvEL QyNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y23-v6si1217119pgv.318.2018.04.30.00.27.03; Mon, 30 Apr 2018 00:27:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbeD3H0p (ORCPT + 99 others); Mon, 30 Apr 2018 03:26:45 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:49997 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751751AbeD3H0o (ORCPT ); Mon, 30 Apr 2018 03:26:44 -0400 X-UUID: 661a9bd7db0041d8b3e077538f54e989-20180430 Received: from mtkcas34.mediatek.inc [(172.27.4.250)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1676031057; Mon, 30 Apr 2018 15:26:39 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 30 Apr 2018 15:26:37 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Mon, 30 Apr 2018 15:26:36 +0800 Message-ID: <1525073196.21494.3.camel@mtkswgap22> Subject: Re: [PATCH] spi: mediatek: Use of_device_get_match_data() From: Ryder Lee To: Mark Brown CC: Leilk Liu =?UTF-8?Q?=28=E5=88=98=E7=A3=8A=29?= , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Date: Mon, 30 Apr 2018 15:26:36 +0800 In-Reply-To: <94cba80f703be048666afde1ed53c15c3704c533.1523347340.git.ryder.lee@mediatek.com> References: <31f944ab8dfcc1d7b6f03b35657a2a34825b5246.1523347340.git.ryder.lee@mediatek.com> <94cba80f703be048666afde1ed53c15c3704c533.1523347340.git.ryder.lee@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, Is it okay with you? On Mon, 2018-04-16 at 10:33 +0800, Ryder Lee (李庚?V) wrote: > The usage of of_device_get_match_data() reduce the code size a bit. > > Also, the only way to call mtk_spi_probe() is to match an entry in > mtk_spi_of_match[], so of_id cannot be NULL. > > Signed-off-by: Ryder Lee > --- > drivers/spi/spi-mt65xx.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) >