Received: by 10.192.165.148 with SMTP id m20csp3536731imm; Mon, 30 Apr 2018 01:49:31 -0700 (PDT) X-Google-Smtp-Source: AB8JxZodBolWayeDu94k9bq/CW3/rL31rd4UCzhFABLBWRKfyZbwHm9B/zLUl6Qe28DzOJC/TqWI X-Received: by 2002:a63:41c5:: with SMTP id o188-v6mr9465599pga.280.1525078171912; Mon, 30 Apr 2018 01:49:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525078171; cv=none; d=google.com; s=arc-20160816; b=CkIAnFOCrW9SYWryvKzhae1fvcYoE2cS4iHHCaVu/jDprR8zi7wIL4PAh+rFLmw5MN 6ihtKoW4BPjfM8A0tdx7xZUNkmQ+9Rx6j7G0LGf15z2eqvQuOHAtk8ILqRe+Z5V0VgBC v5yU0nuaId3bzwxZTgQLDQZrgJLCwNpm1Ar4WcT7/DmrbAgDFWMHcOlhhIM3oIoeSRJE 2ZmZsK/KybwRuaJfqBBBa3Yy3V6Kcgb6efhRj5ySfYxwRhCKeo11uKC+BHcqAgK4Ldvu c90eTYNA6NtRuUTUo/x7VLt3NHwH+M6xnH0fGs4z0yNgzSgKrtjLxC+uICf5xsGTh/9l bUmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=AYy9sD2ATGoqXrAexWRPu0IzvXRDdw19FqN4zzfmCkg=; b=m/XivFY7vwXbvHg1zLfy6+FlVtBsMj50hhI7lh4zD1PoIQDkcPN8fajR+EHL6jMS+N rxR78kfL+xzQdJ//pnMyls62hNo1s0XU0L44ormeYd80hhyu8SCyZ2fAGchxfrcHwSYN AySBqnH80xRaCs7bcXF6UdH8B+CQD/13eFUOa6Lab0v6kMAGl4WCz0iDAwwtNfHvlNdh PzUYM2vzLiUY8K3IN0aKgpiYBoB8FKK+RXyETr+WcIrAPQvNRcrScRyd9/qJ1REYrklg WqQ0BzUKO4yxxFyWJo4F9/JYTEqHN+yez/HW13PnWzAZZ6g9mD9l3SFfu+GDi6qLaSLb ZQSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NDTTUpxV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 37-v6si6946957plc.140.2018.04.30.01.49.06; Mon, 30 Apr 2018 01:49:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NDTTUpxV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751899AbeD3Isz (ORCPT + 99 others); Mon, 30 Apr 2018 04:48:55 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:35474 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbeD3Isx (ORCPT ); Mon, 30 Apr 2018 04:48:53 -0400 Received: by mail-it0-f54.google.com with SMTP id 186-v6so8714343itu.0 for ; Mon, 30 Apr 2018 01:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AYy9sD2ATGoqXrAexWRPu0IzvXRDdw19FqN4zzfmCkg=; b=NDTTUpxVE6j9vh4GsxdxIEZOF6E/2D+T7DOJYBNMNesFK8RTMJt3dskbeKe/MYFG2E RQ/h3+7iHQ+VeFfiFpR8yfqNsdTs3PToVBPscrKTcbsRBn+YaYDcTkYK1t4t0AByLLi9 GqjsK/TyfLJHsCK2tL4FsSr3pnVF7Ng7gUHA0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AYy9sD2ATGoqXrAexWRPu0IzvXRDdw19FqN4zzfmCkg=; b=Ul3t/Ao9bIvKYCknqgCGCGF9dKwjtpQPFPq61YNE2AJACHGdxT3taAw+LgDOnymeE2 BqtqqmGvlk5kor/kgdfTx6ywMRgBwtdxZEvA/6kVmZCAxQ8i/0xcKOyNzh80Mttk9TqH WKUyQ6dEKYhadJSd+2Gf2GkT+ztzCv4bWmqke1nXFYFmyBgbONNZN64esQ8OT3Bg6bit mnVgxur3Ub3uf8XR2cY6hRxn9ezXPKZhwxFtnEVfdCcKkYmEZjkyUcacmITYDY+0G2AP MSyCyodNX5u0etPB1SrTggaR2VTD5Vb88pPLmW0x7SGp891I/jYL3wkSu3zCmcOhEXSM vYMA== X-Gm-Message-State: ALQs6tDtjgnId9JwEUvFGjRv/be485tj2T/+2JoRKlifATeOrRUoPGEP upe2nYfgxBb9JM//Y2tkAkfGU6VfjGRPwO6OvK8sOw== X-Received: by 2002:a24:a0cc:: with SMTP id o195-v6mr10806707ite.115.1525078132999; Mon, 30 Apr 2018 01:48:52 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:2793:0:0:0:0:0 with HTTP; Mon, 30 Apr 2018 01:48:52 -0700 (PDT) In-Reply-To: <20180420135020.23423-1-vilhelm.gray@gmail.com> References: <20180420135020.23423-1-vilhelm.gray@gmail.com> From: Linus Walleij Date: Mon, 30 Apr 2018 10:48:52 +0200 Message-ID: Subject: Re: [PATCH] gpio: pcie-idio-24: Fix off-by-one error in get_multiple loop To: William Breathitt Gray Cc: "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 20, 2018 at 3:50 PM, William Breathitt Gray wrote: > The PCIe-IDIO-24 features 8 bits of TTL GPIO which may be configured for > output or input. This patch fixes an off-by-one error in the loop > conditional for the get_multiple callback so that the TTL GPIO are > handled. > > Fixes: ca37081595a2 ("gpio: pcie-idio-24: Implement get_multiple/set_multiple callbacks") > Signed-off-by: William Breathitt Gray Patch applied for fixes. Yours, Linus Walleij