Received: by 10.192.165.148 with SMTP id m20csp3547430imm; Mon, 30 Apr 2018 02:03:55 -0700 (PDT) X-Google-Smtp-Source: AB8JxZracJ+kftJRDF6pi3RC75LWA9GxjLGnfc2NCx/sz3N4r8ipb5JbGn7QMqnnEH9lmatE89iP X-Received: by 10.98.223.205 with SMTP id d74mr11305472pfl.114.1525079035710; Mon, 30 Apr 2018 02:03:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525079035; cv=none; d=google.com; s=arc-20160816; b=Ow275mf9OPw4zkofLM+9W1M1g8rELVKujAB6pNVV9h00idCMIilAt7NHUV7jQwO4eh CyJ7JG2hW9ubU8ni7P+nvglKwJmk4BQp2dbVk07jcOCAGjg7Gu+cwTrjfFVRrqK5zL23 jQJuYH2kcJHLQs0s2cWAx9SXcYjwNGzERpxMwAoVC8ocmYJVzWio2Igg8PCnTwHXjJZm KQjLeULpsZAuGNztvw0HH+eMWL38J3JcYRRlGbjGJjjLwl6N6IUj2o39Rr7R2tFsEBJD NPS1h+yzGhMpmiusXGC01161f1fot98WUa8gUNg6508RlKCveBEzRonKPkBDQEYlQEGp JjSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=GEVYMr5oIo+PbV3EIpka9xYRM4NsuKhFZcCJQc1H/40=; b=UKWZvm2NkYgwbSovlpAgm6jKNmQSPY9VGj/Sr54CrjOqigglD58MG3v5JBGCSOThvA lI66+aEPHOXN6ka9kIbllScbqffvSiUatQjsyoOM722Qy91KvDLAXTLQ2nT4ACo5ETRs XuhlYBYbyp9gLt8TwYnBwuYvJ/B8604uBP9H8H2dTo0byHU3arFvlMasn+03qRdVNizp kkAfI26Di3twyOwracch9cBx74oppKD+9EU34bmqk3mDUnsgHAgmTYHyACbptsYfvPBf MlU6VIntncMpPhUmbc1DOM1AbEncGyKL6sYnyaZrBOkUWggGfFISsE0/v6YGFQJYOtJM 6mHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LJv4326k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33-v6si6998841plk.83.2018.04.30.02.03.41; Mon, 30 Apr 2018 02:03:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LJv4326k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752418AbeD3JDa (ORCPT + 99 others); Mon, 30 Apr 2018 05:03:30 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:36552 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbeD3JD0 (ORCPT ); Mon, 30 Apr 2018 05:03:26 -0400 Received: by mail-io0-f195.google.com with SMTP id d73-v6so9434624iog.3 for ; Mon, 30 Apr 2018 02:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GEVYMr5oIo+PbV3EIpka9xYRM4NsuKhFZcCJQc1H/40=; b=LJv4326k5N6qb8HVy8/lrcEhLjMM42PM7mgGLkoIXjx2WgpL8DUNkgB53LhUV6+Q5M 6ElwJnBi4DOfXxt4aZuzz8uxfGqV5R3uTK13/WGBArHIFIXRo+e1EdFd0C6mz86I7Kju 9qYMDKzQ38Jjh99N90+3SJAlq4aSctNjaFf7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GEVYMr5oIo+PbV3EIpka9xYRM4NsuKhFZcCJQc1H/40=; b=dLjr0zkuFAjjEPb/vKPLiV7YOuM3Q+bej2OPos4y8R6hP0w69mxlXMt4ZN34Rt4SrC 2WRrbdZdQshPvKaBJmMygcRDgEljmh62WY5PByMyv9QKYop1MouQyyporDvKX0pF2/cW 79Wy27IbCKgPE4S5x8XoO8CaZCJ+3uXOlgW1YmZTLG5doCzl4f+RSu5MNivO991ug2RE gPFzCCS1PPFASdVqqntJcXhVeaRj1EA4UnJo4Dv1SFabrZFy7Tq/vuLB575wChJRiUzw R455r7bWIMPSL3CXYjnNGgoK77cOibQ7W+lDwcQfiZqxkJ9202zqjfw5NGwkOkEmLvpi gVDA== X-Gm-Message-State: ALQs6tCfRRM0fVm9keYaXnRQbO5fkCym3b30Ifh0JizSZEkNR+p12YdB mPCNAP7gjS7qa1Z7um/R0YRlFkj8IOHDcHoSBnpi0w== X-Received: by 2002:a6b:cc02:: with SMTP id c2-v6mr11522032iog.304.1525079006196; Mon, 30 Apr 2018 02:03:26 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:2793:0:0:0:0:0 with HTTP; Mon, 30 Apr 2018 02:03:25 -0700 (PDT) In-Reply-To: References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-11-wsa+renesas@sang-engineering.com> From: Linus Walleij Date: Mon, 30 Apr 2018 11:03:25 +0200 Message-ID: Subject: Re: [PATCH 10/61] gpio: simplify getting .drvdata To: Grygorii Strashko Cc: Wolfram Sang , "linux-kernel@vger.kernel.org" , Linux-Renesas , kernel-janitors@vger.kernel.org, Hoan Tran , Santosh Shilimkar , Kevin Hilman , Thierry Reding , Jonathan Hunter , Michal Simek , "open list:GPIO SUBSYSTEM" , Linux-OMAP , linux-tegra@vger.kernel.org, Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2018 at 5:14 PM, Grygorii Strashko wrote: > On 04/19/2018 09:05 AM, Wolfram Sang wrote: >> >> We should get drvdata from struct device directly. Going via >> platform_device is an unneeded step back and forth. >> >> Signed-off-by: Wolfram Sang >> --- >> >> Build tested only. buildbot is happy. Please apply individually. > > > for gpio-omap.c: > Reviewed-by: Grygorii Strashko Hm I only see the responses not the actual patch, I guess I will find it sooner or later. Wolfram: if I don't find it, poke me with something sharp so I get to apply it. Yours, Linus Walleij