Received: by 10.192.165.148 with SMTP id m20csp3578276imm; Mon, 30 Apr 2018 02:44:36 -0700 (PDT) X-Google-Smtp-Source: AB8JxZorvo/74yKAJSIo/gpAhomrH3dsOc2A4JTmP2yhxLHNb/9iiGSNEI5KVA0OX4EfqG1E3MHh X-Received: by 10.98.80.145 with SMTP id g17mr11157045pfj.71.1525081476758; Mon, 30 Apr 2018 02:44:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525081476; cv=none; d=google.com; s=arc-20160816; b=oroRVGaYVJj1+mUJYu0VyXrm+XRJuRYeGiJ1rHFLczFqNSRHbihe+m0bOEg2wsaLzR JGGSl2pUZjQaPT8OZ5ZIyo/6lB1dDGq6iUfONQMVWLPoyv1MFYMboyDwOcnpm6onMbD8 4L0sdpHa3b/MVx5Ea+1vI3c4jV/HvxGVNXAR5q+xeMdT4W4AIsIsqhM1yOjhHw+SlDHC 9qYat+nHHzlve5DxCI8Wb96BekKvHiBdPkKjuE708MYPCWojCRGvgxr3uQwzhCpqCPpi WmnWuyJ9BJP7MADKau31Dt9O2lyKFTOg4DGJFrgOqtLhbnhJ4tJ7ssPix9p8SnG0ahYt 4Tpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=aM9fOKeb3NCge2HW6JWSsOBD5mgkmCYhThjr3iHCjIA=; b=TeOJylxIDVV3/PgW3JZWVuVQcyTDvntDcBErTh+/ojdVFcJAlKVFua+Cyzd+HRErO6 plsYKK0o8sAwIWsRUFJbuKM5BHEE2qdnbJjzay+VqNFRl1f9v3OK11RtM2kpEcsuHA1Q mpE23wgfu0q2tuMIarVfAl6bjYANGszy6ggzdzeKTeKnZNBL21/uRhMvGWdFOdwJWV0W 9W8/9+ApmtX9IrUzwiyCdMjXNq3kQVZNE3+gMvOolYRoLMrDEClbKqvRdh9GMgfemwRE Nyzt7A54LXPAHMyyDxDm0DLRc11N/fSlRGhJmyuFkjrxN0YLYI9J9f4YTv7q5tqL1b1t t07Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s10-v6si6009058pge.41.2018.04.30.02.44.22; Mon, 30 Apr 2018 02:44:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336AbeD3Jm7 (ORCPT + 99 others); Mon, 30 Apr 2018 05:42:59 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:51568 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753003AbeD3Jm4 (ORCPT ); Mon, 30 Apr 2018 05:42:56 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1DB6A402385D; Mon, 30 Apr 2018 09:42:56 +0000 (UTC) Received: from t460s.redhat.com (ovpn-117-122.ams2.redhat.com [10.36.117.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id 639872023499; Mon, 30 Apr 2018 09:42:54 +0000 (UTC) From: David Hildenbrand To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, David Hildenbrand , Andrew Morton , Michal Hocko , Vlastimil Babka , Dan Williams , Reza Arbab , Pavel Tatashin , Thomas Gleixner Subject: [PATCH RCFv2 5/7] mm/memory_hotplug: print only with DEBUG_VM in offline_pages() Date: Mon, 30 Apr 2018 11:42:34 +0200 Message-Id: <20180430094236.29056-6-david@redhat.com> In-Reply-To: <20180430094236.29056-1-david@redhat.com> References: <20180430094236.29056-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 30 Apr 2018 09:42:56 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 30 Apr 2018 09:42:56 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'david@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's try to minimze the noise. Cc: Andrew Morton Cc: Michal Hocko Cc: Vlastimil Babka Cc: Dan Williams Cc: Reza Arbab Cc: Pavel Tatashin Cc: Thomas Gleixner Signed-off-by: David Hildenbrand --- mm/memory_hotplug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 4c7e0efff079..d8f127754c2e 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1685,7 +1685,9 @@ static int __ref __offline_pages(unsigned long start_pfn, offlined_pages = check_pages_isolated(start_pfn, end_pfn); if (offlined_pages < 0) goto repeat; +#ifdef CONFIG_DEBUG_VM pr_info("Offlined Pages %ld\n", offlined_pages); +#endif /* Ok, all of our target is isolated. We cannot do rollback at this point. */ offline_isolated_pages(start_pfn, end_pfn); @@ -1720,9 +1722,11 @@ static int __ref __offline_pages(unsigned long start_pfn, return 0; failed_removal: +#ifdef CONFIG_DEBUG_VM pr_debug("memory offlining [mem %#010llx-%#010llx] failed\n", (unsigned long long) start_pfn << PAGE_SHIFT, ((unsigned long long) end_pfn << PAGE_SHIFT) - 1); +#endif memory_notify(MEM_CANCEL_OFFLINE, &arg); /* pushback to free area */ undo_isolate_page_range(start_pfn, end_pfn, MIGRATE_MOVABLE); -- 2.14.3