Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261620AbTHYIu2 (ORCPT ); Mon, 25 Aug 2003 04:50:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261621AbTHYIu2 (ORCPT ); Mon, 25 Aug 2003 04:50:28 -0400 Received: from trained-monkey.org ([209.217.122.11]:38916 "EHLO trained-monkey.org") by vger.kernel.org with ESMTP id S261620AbTHYIuW (ORCPT ); Mon, 25 Aug 2003 04:50:22 -0400 To: Krzysztof Halasa Cc: "David S. Miller" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] RFC: kills consistent_dma_mask References: <20030818111522.A12835@devserv.devel.redhat.com> <1061298438.30566.29.camel@dhcp23.swansea.linux.org.uk> <20030819095547.2bf549e3.davem@redhat.com> <20030824060057.7b4c0190.davem@redhat.com> From: Jes Sorensen Date: 25 Aug 2003 04:50:24 -0400 In-Reply-To: Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 30 >>>>> "Krzysztof" == Krzysztof Halasa writes: Krzysztof> "David S. Miller" writes: >> See, to show something is broken, you have to show a device that >> will break currently. Krzysztof> SBE wanXL sync serial adapter. 32 bits for buffers but 28 Krzysztof> bits for consistent data. Well if the buffers are dynamic, why would they want to be allocated using the consistent interface? Krzysztof> I can't imagine all devices work properly on all platforms Krzysztof> wrt consistent allocs. Say, sound drivers setting only Krzysztof> dma_mask to < 32 bits and expecting consistent alloc will Krzysztof> use that and not consistent_dma_mask. If sound drivers set the dma_mask to something and expect that to apply to the consistent allocations, then they aren't complying with the current API and needs to be fixed. Krzysztof> Of course, there is a question if we want to support such Krzysztof> sound cards on Itaniums and Opterons? Of course they work Krzysztof> on i386 as i386 pci_alloc_consistent() ignores Krzysztof> consistent_dma_mask. So fix it on ia32 to respect that mask for consistent allocations, problem solved. Jes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/