Received: by 10.192.165.148 with SMTP id m20csp3609608imm; Mon, 30 Apr 2018 03:24:03 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqL9Kfj2fNbRy52bi/gPBT62f0SmqDPUf0ezzXI0fmLkUJC7+Hxv+bpu+oz+0aIi8fslD0P X-Received: by 2002:a17:902:8f96:: with SMTP id z22-v6mr11756169plo.200.1525083843929; Mon, 30 Apr 2018 03:24:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525083843; cv=none; d=google.com; s=arc-20160816; b=JgWwtJCZQ0y4GI9P83OeKLLyC3yuIGJuwIgQp0t3SBXUn7TB8j77Ekml46Hy8B9gfW kV9h+FPcH/uhBKVEyb9dOlcJpoSa8udeMko26GhBqy8VIGCP+d2oDeLIUS80NCy/Z44c fx45cx0KO5dJHipzZG/2eF8HefCIu3LpTZya33PXIhjeouXKt+qGxj/aFQEplbJM2qh5 /47qe8ak48OVp+oBBaL1Au6hxpAvMQVO3UlfeXCV949WDjMduaO76vQzhq+ieppstlfF 7+6bRgzAy3CPkXxQOv5Xk2p5ltys0wxEijfwAk6m6SSKcHldINJ/3MgZih+sjUz08xiS xYZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=iuXZL4yDXkcrbJkBzGX56Q1iAsD4MLQ54ImGmZ4XRp4=; b=mKyLtQLS8pdT3mdULbhtT8AxPyNT0C7ipPQ9M+pKwrN+B2C9YwgYR41RHnj8iXUmty 76JcJntNiliuuY0HGPMYVf6+kCz6+s5P9JswOAOjg+EClVkj9/ajx1VlERtoI7cfNSSU RXf3dtiR7dI41p5+VD4yVlKxQsBLCosRAaGPoPpVsN3ISAg6YIea9dR0uD6D78Le9XqC V9yerufw47qwoe+i95Ow+EVxEGt+lH2A56mXfPlFWAFLO3medC9rHnRNiQS1t28XN7TY PBWpPNN8olabfpvBcMTZPNpYYoV/dExEYihaLu6xx77N8Baz2ec3jF9ZUbzv6fNercFY JlKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ont/2zDk; dkim=pass header.i=@codeaurora.org header.s=default header.b=cjJdRZne; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x8-v6si3168095plv.71.2018.04.30.03.23.49; Mon, 30 Apr 2018 03:24:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ont/2zDk; dkim=pass header.i=@codeaurora.org header.s=default header.b=cjJdRZne; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbeD3KXe (ORCPT + 99 others); Mon, 30 Apr 2018 06:23:34 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59902 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbeD3KXc (ORCPT ); Mon, 30 Apr 2018 06:23:32 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C959D60710; Mon, 30 Apr 2018 10:23:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525083811; bh=tjVsD/luzN+WqFkIRKdUS6/D4cZ71yt8Y0Z/pQdN1rw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ont/2zDkqb2c5XuiXhnk/2o8bRKuru1ykT/TzWoisScngJ/yNGWm2KxP/2YyDLATX J7qbbOGHeA4Dj3lka2zh6rqucjzhpAd2nCMt+Ja2x6oMd8sL5jTS5rapkzfAC6Qp7L TntqNjpH4vOQiH4x0VAgCxXH2osHFts7JQNnYcLY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A68E6601A1; Mon, 30 Apr 2018 10:23:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525083811; bh=tjVsD/luzN+WqFkIRKdUS6/D4cZ71yt8Y0Z/pQdN1rw=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=cjJdRZneBJ+JPyWxmydpmLJEaoOiEp2/r7KVqFzMMNjdRJ4KJ3pibZ9IE0e8pwAcj UzgA5LBO16OqBUqpjEZ/fdz9s7EBATdCln6fBExHSPS7ZmesAKiDP6TKe5gA8dDOsb Yn8Zpod5z8mAmyxIHLPjLnhUycXPGopL/ltNjqtE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A68E6601A1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: mwifiex: fix mwifiex_hard_start_xmit()'s return type From: Kalle Valo In-Reply-To: <20180424131802.4913-1-luc.vanoostenryck@gmail.com> References: <20180424131802.4913-1-luc.vanoostenryck@gmail.com> To: Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, Luc Van Oostenryck , Amitkumar Karwar , Nishant Sarmukadam , Ganapathi Bhat , Xinming Hu , linux-wireless@vger.kernel.org, netdev@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180430102331.C959D60710@smtp.codeaurora.org> Date: Mon, 30 Apr 2018 10:23:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck Patch applied to wireless-drivers-next.git, thanks. c126e1995f79 mwifiex: fix mwifiex_hard_start_xmit()'s return type -- https://patchwork.kernel.org/patch/10359857/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches