Received: by 10.192.165.148 with SMTP id m20csp3614013imm; Mon, 30 Apr 2018 03:29:22 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp+hXwZ1poanqkxQLxg1pPOcclfSk4tVbiqz4Mp7/8PxgCv/DH/Y/UjOQcSsDIjfCpGKeqd X-Received: by 10.167.129.154 with SMTP id g26mr11578505pfi.169.1525084162880; Mon, 30 Apr 2018 03:29:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525084162; cv=none; d=google.com; s=arc-20160816; b=owddB44TC2GHgaOLgu/XVMZ+/oDe4GK1VvaYXLS2gshhXpDY3BMX6EE0B3mUlfofFK 5Lj/ypkRNf8S0WVJ/0aFsShbfkFisnzuIcHfRakudQnoNRKNmjLHZzuMlDgtmbIdov60 2ZcrpHfOI80MKqGh7e5P+D2A0kLl3dDrQhDi+b0z/fuU/pKugrBNK7r6E172hMScVMW0 O870/RWl9jHx2pFz8C998M+Em0oc8dUyXTHIZRPPZVc1O/Nfc6dsKxsxF4DIO1yKD3kC 53zw3YTvKqNbUDA/aKf3SsdWe3ZTIOgIMqVLkelXN5GKwFLfHphSrSOjFRmBOzeJEUk9 iR/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=O0a0xpDKIPKfCW9ymhj2bYTOcTPNrR+XN7hILqWStgQ=; b=oWezVQvDH8I3u6/78v9PM2G9gymhZb/1QAwwQyZmz/CAzL87WQHjDjmtQwW9Q+YbOy TZsN4MJ0H8bROd7NIOZf3oyK5KaBr1VN7sjZCALgt6CYQHNxr+HuGvAIl3MLL+nnLyka Em6aoH6BJFDIqsqPlyAQApl5QVvGRouvGLBnqkS2+HCEuXkZX+hvk8QyOmeEUXhaEBYd DO8tWat5SwzpjerRuMHVuN8kyEHGnSiXesa2/8/aEcARLgW4rfHjcxrYH1eZQH65E9qh WUlLONUl1nmbpFvdC1MKMX2gEN6A0CkyPgrYjZvdbw/IttUMrvxRtfsLnjlC+P2yK7Zd mFyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=dDtee9Io; dkim=pass header.i=@codeaurora.org header.s=default header.b=fFYXe/q4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f2-v6si5971514pgs.655.2018.04.30.03.29.08; Mon, 30 Apr 2018 03:29:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=dDtee9Io; dkim=pass header.i=@codeaurora.org header.s=default header.b=fFYXe/q4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752857AbeD3K25 (ORCPT + 99 others); Mon, 30 Apr 2018 06:28:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33986 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbeD3K2z (ORCPT ); Mon, 30 Apr 2018 06:28:55 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CA14360558; Mon, 30 Apr 2018 10:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525084134; bh=0VV/A0Oo5owQmBiMsCWRf35dDi9R9uHpA7r1fC2G0sk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=dDtee9IoEChGjskDZ9kg821P1mJCWjU67U6A27KH8bP6TOPNIc4AO6B5NAhWHGWDZ M+fwgYX+5ak7xvOl1pC2XFrxDnPQCVDk2QjWO/Pbn9W3Aiutq37VYe7j6dfLAWfjku s/5RoNftMP47LXAtUObi/7ovXR/1vSDrb9ASl+wc= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C9EDD601A1; Mon, 30 Apr 2018 10:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525084134; bh=0VV/A0Oo5owQmBiMsCWRf35dDi9R9uHpA7r1fC2G0sk=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=fFYXe/q4rvg6oBuzwtyheqjic49s/8GWDqmEwFhCg5Z8Ln+i+TRHhsyO1dY5lCrRs nv0fby6uZHX732/vQQc3xST+6FBqZ/pt3qCOubcvygjc/JjTRK1vRSRn0DZtnVU2fO Uned6rOhzDJuLFR+q2uVXhuhTWTROIKjnBjtkRMY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C9EDD601A1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type From: Kalle Valo In-Reply-To: <20180424131810.4963-1-luc.vanoostenryck@gmail.com> References: <20180424131810.4963-1-luc.vanoostenryck@gmail.com> To: Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, Luc Van Oostenryck , Igor Mitsyanko , Avinash Patil , Sergey Matyukevich , Vasily Ulyanov , Kees Cook , linux-wireless@vger.kernel.org, netdev@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180430102854.CA14360558@smtp.codeaurora.org> Date: Mon, 30 Apr 2018 10:28:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck > Reviewed-by: Sergey Matyukevich Patch applied to wireless-drivers-next.git, thanks. 3ff6ee28535f qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type -- https://patchwork.kernel.org/patch/10359851/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches