Received: by 10.192.165.148 with SMTP id m20csp3616766imm; Mon, 30 Apr 2018 03:32:08 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpOl0OdHQPhIoOjgM/BULMd8gDK91GH2z1/uxGV+SrW42jyEvlkgRZ3pZZmDGOcD3pW2O5D X-Received: by 2002:a65:4301:: with SMTP id j1-v6mr40028pgq.356.1525084328267; Mon, 30 Apr 2018 03:32:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525084328; cv=none; d=google.com; s=arc-20160816; b=I5Fl1p8vz6SRXzhUcR1+C01c8lZCFYMaBfHMwZNu+l27jNyRt/YAawj695KV6UjICe 2wXRgErCA+vSKkm/sathZWTvW3XPv3awxG+H3NF1MFght6bCMtfE2SJjs5TlMmBJ5uKN lf169pSWaILnX+/yQrzmjPCQ6Vuf+3TYoZKI7gmmMnwOjf978z0Gmzc0jkMQKEn1o1Hc x+0UfnAbLKKrLkcTrkqSXIS8SmA3zA/FEiS3h810jWj2pUbFM7BJbBdEeIPlVqku2CBW GUYh0WvK8HNXQIP4t3myQXaK1WeEmZJeTPtpfHSzdOrzYqgz6sFrPK/u9B7aSixGCTUJ 21dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=vRSsenkLo34STN6si/IWiCNkMe7+89GVfMudpwWAsJg=; b=C1/xWZp9uO55UPhTxCGgeBa3rruKIhD33i6FANlg0Y9TGnEKXbpvw44fLR1tr6be/e ik1930jnSvbFlm1G8AkNW6WCIo0smNQ6m37Qrs8/CIwxo/IC5drojOpHuAf4lp1yce/b n0pmPvb9s2gn2dyJEmx6x1FYxGxym8P8v7TqnGonRbl6ZqLQiddw2/nDZ8agS7flBYK9 JPDpkntijxfQDpDZczUOECnmTumbTi9DdIG5GLvdjJpW7tbPVQVHCh1Knh8h5BNnyQ0S e/0GuC9h2dXDcHCw12fZH477QeTQ028MIgRW8dIwZ2ocKBJqbRNrhNExzs4q2q7rVheI azBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=bnSyMSu5; dkim=pass header.i=@codeaurora.org header.s=default header.b=WqNYb4/3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q12-v6si7102898pli.419.2018.04.30.03.31.54; Mon, 30 Apr 2018 03:32:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=bnSyMSu5; dkim=pass header.i=@codeaurora.org header.s=default header.b=WqNYb4/3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752942AbeD3Kb3 (ORCPT + 99 others); Mon, 30 Apr 2018 06:31:29 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36812 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473AbeD3Kb1 (ORCPT ); Mon, 30 Apr 2018 06:31:27 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 274E86079C; Mon, 30 Apr 2018 10:31:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525084287; bh=oiI0aJV038t8Ek+sRr8SAIi3me3pXDV9G/qoEKZj5Es=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=bnSyMSu5/kQbYwn3rRakfSYJIk+2JjQYLarda3V31chrcEMTjRG/8rviX652xtLnf dqvfpntLw9B+nyscr3l0nbJ6nFVeuQv60h/zwSeYCbGV1639+f01SnIwK6drs4RlxG CElMsq0LUrSoq3yLImcEDe2fki9s477zJIyKqQzw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E950E600C9; Mon, 30 Apr 2018 10:31:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525084286; bh=oiI0aJV038t8Ek+sRr8SAIi3me3pXDV9G/qoEKZj5Es=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=WqNYb4/3SbTTt8sadVwRWAsi3av423RMcKNPSVhPbYqdntEhJzBia9rf2fbjCFaU6 HvLJohTK7spThl6plnkdae8Cc9Vx+V7tblrnSLrNGyvT45c7ky1rheILEMXWf0xsqj XXgym5qQuRiTWRJt062mj9fEloz+ehr59hUbiVC4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E950E600C9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v2] wlcore: sdio: allow pm to handle sdio power From: Kalle Valo In-Reply-To: <1524721631-5983-1-git-send-email-eyalr@ti.com> References: <1524721631-5983-1-git-send-email-eyalr@ti.com> To: Eyal Reizer Cc: linux-wireless@vger.kernel.org, robh@kernel.org, sre@kernel.org, tony@atomide.com, linux-kernel@vger.kernel.org, Eyal Reizer User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180430103127.274E86079C@smtp.codeaurora.org> Date: Mon, 30 Apr 2018 10:31:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eyal Reizer wrote: > pm_runtime handles sdio power on and power off transitions. > An old workaround for trying to control the power explicitly from the > driver was in fact causing failures on suspend/resume as the mmc layer > already power the module on resume. > > In case of resume pm_runtime_get sync returns a positive device's usage > count causing the driver to try an re-initialize an already initialized > device. This was causing sdio bus failure on resume. > > Remove this manual power on/off sequence as it is in-fact not needed. > > Signed-off-by: Eyal Reizer > Acked-by: Tony Lindgren Patch applied to wireless-drivers-next.git, thanks. 60f36637bbbd wlcore: sdio: allow pm to handle sdio power -- https://patchwork.kernel.org/patch/10364645/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches