Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Apr 2018 11:30:29 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     matthias.bgg@kernel.org
Cc:     ulrich.hecht+renesas@gmail.com, laurent.pinchart@ideasonboard.com,
        ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie,
        robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com,
        sboyd@codeaurora.org, davem@davemloft.net,
        gregkh@linuxfoundation.org, mchehab@kernel.org,
        rdunlap@infradead.org, sean.wang@mediatek.com,
        linux-clk@vger.kernel.org, linux@armlinux.org.uk,
        matthias.bgg@gmail.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        Matthias Brugger <mbrugger@suse.com>
Subject: Re: [v3 01/10] dt-bindings: mediatek: mmsys: Add support for mfd
Message-ID: <20180430103029.GD5147@dell>
References: <cover.1524820923.git.mbrugger@suse.com>
 <64ca273429d92f581568a48f3efe6035af65f579.1524820923.git.mbrugger@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <64ca273429d92f581568a48f3efe6035af65f579.1524820923.git.mbrugger@suse.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 27 Apr 2018, matthias.bgg@kernel.org wrote:

> From: Matthias Brugger <mbrugger@suse.com>
> 
> Add binding description for the mmsys mfd for some Mediatek
> devices. mmsys has some registers to control clock gates (which is
> used in the clk driver) and some registers to set the routing and enable
> the differnet blocks of the display subsystem.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
>  .../bindings/arm/mediatek/mediatek,mmsys.txt       |  2 --
>  .../bindings/display/mediatek/mediatek,disp.txt    |  2 +-
>  .../devicetree/bindings/mfd/mediatek,mmsys.txt     | 27 ++++++++++++++++++++++
>  3 files changed, 28 insertions(+), 3 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> index 4eb8bbe15c01..4468345f8b1a 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> @@ -6,10 +6,8 @@ The Mediatek mmsys controller provides various clocks to the system.
>  Required Properties:
>  
>  - compatible: Should be one of:
> -	- "mediatek,mt2701-mmsys", "syscon"
>  	- "mediatek,mt2712-mmsys", "syscon"
>  	- "mediatek,mt6797-mmsys", "syscon"
> -	- "mediatek,mt8173-mmsys", "syscon"
>  - #clock-cells: Must be 1
>  
>  The mmsys controller uses the common clk binding from
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index 383183a89164..85a3b4ec06cd 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -9,7 +9,7 @@ function block.
>  
>  All DISP device tree nodes must be siblings to the central MMSYS_CONFIG node.
>  For a description of the MMSYS_CONFIG binding, see
> -Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt.
> +Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt
>  
>  DISP function blocks
>  ====================
> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt b/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt
> new file mode 100644
> index 000000000000..2331ae16917e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt
> @@ -0,0 +1,27 @@
> +MediaTek MMSYS Multifunction Device Driver

What is "MMSYS"?

"Multi-Function Driver"s are specific to Linux.

What actually is the device?

> +MMSYS is a multifunction device with the following sub modules:
> +- clocks for the multi-media subsystem
> +- central node for the DRM subsystem.
> +
> +This document describes the binding for MFD device. The MFD takes care to initailize
> +the clock driver and the DRM driver. More info see
> +Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +
> +Required properties:
> +- compatible: Should be one of:
> +	- "mediatek,mt2701-mmsys", "syscon"
> +	- "mediatek,mt8173-mmsys", "syscon"
> +- #clock-cells: Must be 1
> +
> +Optional properties:
> +- power-domains: list of powerdomains needed for the subsystem to work
> +
> +Example:
> +
> +mmsys: clock-controller@14000000 {
> +	compatible = "mediatek,mt8173-mmsys", "syscon";
> +	reg = <0 0x14000000 0 0x1000>;
> +	power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> +	#clock-cells = <1>;
> +};

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog