Received: by 10.192.165.148 with SMTP id m20csp3640618imm; Mon, 30 Apr 2018 04:00:02 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqsOara4MvdvG8kCpJ9W63zCX2ggH6rKmk+cvsQzOqiUrHoOwpKTMAI56emb5NBrFhkwGO5 X-Received: by 2002:a17:902:8ec5:: with SMTP id x5-v6mr11975146plo.57.1525086002792; Mon, 30 Apr 2018 04:00:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525086002; cv=none; d=google.com; s=arc-20160816; b=ziJbNHhtKFqyh4BznwjQITnXIM8veIMBkTYdMU84EZeqyD8NSBvovZxkkjZZ6fhddF F8msR3uqnKefRCeoF2oO8uzQnGaiRJpUHNzi/eVvDcBR0+xthYzCB/iO/5vnVtdLKeLz Nd3zd5GCBIgfxSFLLIGZpmHL4vufiumwTHQNpN9VESfoboSzd9WZrX+2Y6+nwh60HxGg LEGYD3R7bJV4z6wr/IPtGujNNau/gBKD360NOi8fOSDjlwJ8i9ezj8UEDF6XsdLAJTJK JNvvhpNokU8pv603aX8dmwajK+RajR2aALfDERS6vDEzX0CBB8+uNKFiAdhHCoYk9s/6 LEQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=IeI8HD5ZDC8ctfZ2s5viDGXaPDJokMth+PUbdMfJP0A=; b=QlpGssI27HZnooegj8p1NcfzawUwXuSaMp6LfxyHQBhGwkSLAzYCU4Ok4C4sOS4XFN F+qS/BgHAP7Wbqv9PEj/MdvS9XZNtb9dXxGRp1MQwNlNlFn+F7k/LjH05NLwM6KjCzsv fpcvEBOxEYW+FHeKIYafXPwAu28bPSW9VkTLByaB/Exy11bGUED7DUeoCwLctOTW79Yq bj/fmh86hjyBkguHbp4KIko626KLrq3KrtByvEFxdOGjjLj0rEjkb+9sEzq42vc2VfER uo2yCufm0AL12yfdt8N+a/f2FwbQUAC/XJuaL9S3k9ZZJArY62MTgDx9phV6C9L1mFPz athw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y11-v6si7097944plg.154.2018.04.30.03.59.48; Mon, 30 Apr 2018 04:00:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753256AbeD3K6o (ORCPT + 99 others); Mon, 30 Apr 2018 06:58:44 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:19499 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753181AbeD3K6n (ORCPT ); Mon, 30 Apr 2018 06:58:43 -0400 X-UUID: 8065ca0fb21e4205ae8cfd25f66f2a29-20180430 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 360121692; Mon, 30 Apr 2018 18:58:38 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 30 Apr 2018 18:58:36 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Mon, 30 Apr 2018 18:58:36 +0800 Message-ID: <1525085916.25456.8.camel@mtksdaap41> Subject: Re: [v3 09/10] drm: mediatek: Omit warning on probe defers From: CK Hu To: CC: , , , , , , , , , , , , , , , , , , , , , Matthias Brugger Date: Mon, 30 Apr 2018 18:58:36 +0800 In-Reply-To: <9d514a4ab45f0700663fa756d5aa3913922b6fb7.1524820923.git.mbrugger@suse.com> References: <9d514a4ab45f0700663fa756d5aa3913922b6fb7.1524820923.git.mbrugger@suse.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Matthias: On Fri, 2018-04-27 at 11:24 +0200, matthias.bgg@kernel.org wrote: > From: Matthias Brugger > > When probe through the MFD, it can happen that the > clock drivers wasn't probed before the ddp driver gets > invoked. The driver used to omit a warning that the driver > failed to get the clocks. Omit this error on the defered probe path. > > Signed-off-by: Matthias Brugger It's better to use 'drm/mediatek:' for title to align drm commits. For the modification, Acked-by: CK Hu Regards, CK > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > index bafc5c77c4fb..6b399348a2dc 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > @@ -374,7 +374,8 @@ static int mtk_ddp_probe(struct platform_device *pdev) > > ddp->clk = devm_clk_get(dev, NULL); > if (IS_ERR(ddp->clk)) { > - dev_err(dev, "Failed to get clock\n"); > + if (PTR_ERR(ddp->clk) != -EPROBE_DEFER) > + dev_err(dev, "Failed to get clock\n"); > return PTR_ERR(ddp->clk); > } >