Received: by 10.192.165.148 with SMTP id m20csp3821633imm; Mon, 30 Apr 2018 07:01:48 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpl4XQ8yYPmK/rL4bcvmIKFjA+fXOOD6/lTLU3RPIJoYfdS4FVCMcUpva0NXo/D2nqM7QCB X-Received: by 2002:a17:902:4545:: with SMTP id m63-v6mr12818539pld.268.1525096908179; Mon, 30 Apr 2018 07:01:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525096908; cv=none; d=google.com; s=arc-20160816; b=vnB+OACOb6/m84TIJDWhpTtIEbp8Y4MNNe1zxVOC7Kk7SNWYvJLxuZ6egwpz4o7Z23 DGxh7p9Aa/qXDwRdpBhnd1+ys+iNuWWJuaUWiCV774fcezUUUS4ATXq+6QoP0e3gO4jH EbGTNkXCFFX7n0iJW46SVaywTqi0jFhUOn2+HWxMNujONyHI1CV16YLZQiWSV8KtH0j9 0vON9YoVFIZIZiaSzJtCP5qFsu6PzxYmnY+uQU14BOHp4nLU96EQhilCPmHqfz2sgibw JMjR7wkLRka9n5EQgEdadkSOU4ZbgJQCQkyJIwj4ur5RALZ2s50Rg8Not3pIM3GkLYbO WeJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=pXyB5QRjcf62Ec8TLao273k667kAPyGJ7nnk2CagNUg=; b=H11BOtWv3iZ7Rnxa8FRBXTwIuZOXjg2cKoARD4GCLXV7Y5w23ZIzOuxrwE0sJ+w++g 6c0iB8cY6aZ4zoAMytyDk4tDfJm+PevmH1asYu8FhZ+xYffqa1G870hlGupWdluY26cU DDBl78nGZi2PFM/0lfTNz0xczYi4h/vvhlKQUL2JraZLYhXqypXiSyLQwCdEvtMHC0pS vOdQ/y6CeUYu9Y7XtQtzIqwb6tL+Q9hVXJhBMhtEN9Udt5NnL2TWg+e751IoFAkVy7ly m3BHGwVq3MS5/rkXYfHHG6O1A0KGrxHumrx1FZya1+LHVxjjlbCcn1CagPOypvOBamnY hr9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=o4bzVtme; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s16-v6si6189509pgv.596.2018.04.30.07.01.29; Mon, 30 Apr 2018 07:01:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=o4bzVtme; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753881AbeD3OBV (ORCPT + 99 others); Mon, 30 Apr 2018 10:01:21 -0400 Received: from merlin.infradead.org ([205.233.59.134]:34534 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbeD3OBU (ORCPT ); Mon, 30 Apr 2018 10:01:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pXyB5QRjcf62Ec8TLao273k667kAPyGJ7nnk2CagNUg=; b=o4bzVtmeTdGQgs35JdyxQixFv a6nVy3Lsyb849lVtkJL1M1dv68OoVxPCTR6TjUnLpZaLyIUk8UvugT8c0oRB0PcY1Jn6tGrAQm3Gy ja8jLYxOzrMIro3WJOqdbLproC/3JXT/3a2Xy53ZAPBNLNLb0Zgw4tbfodJO2N1UTwSO8Qo3vlQMl vIpoZgc1hWmLF1S3Zt9MTiX3VD5eC2AmCkoO7Qo5C9HnshAaRZZbpliQI8QsyF8/LvvYpq/rB4vX0 azpyUrgEKU40ZtsvBZp7zZjHI/GaXstrAn1KjYINv44qkURwtIZ0+gOm0FoyUo95l4OcJuTlpQtyI YDKN0T21Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fD9Mh-0006Gl-IC; Mon, 30 Apr 2018 14:01:15 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 269322029FA14; Mon, 30 Apr 2018 16:01:14 +0200 (CEST) Date: Mon, 30 Apr 2018 16:01:13 +0200 From: Peter Zijlstra To: Luwei Kang Cc: kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com, linux-kernel@vger.kernel.org, joro@8bytes.org Subject: Re: [PATCH v6 03/11] perf/x86/intel/pt: Introduce a new function to get the capability of Intel PT Message-ID: <20180430140113.GC12258@hirez.programming.kicks-ass.net> References: <1521544918-31084-1-git-send-email-luwei.kang@intel.com> <1521544918-31084-4-git-send-email-luwei.kang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1521544918-31084-4-git-send-email-luwei.kang@intel.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 20, 2018 at 07:21:50PM +0800, Luwei Kang wrote: > Because of the guest CPUID information may different with > host(some bits may mask off in guest) so introduce a new > function to get the capability of Intel PT. That's not English, also you need whitespace before a parenthesis. Also, what?