Received: by 10.192.165.148 with SMTP id m20csp3869704imm; Mon, 30 Apr 2018 07:46:36 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoAcv0rOvlMlxPFVXRMEjO3zFmgbkzBxYGg6t3X4aCDPfWhsUmoBRna4SRtA4JAe19DkgCT X-Received: by 2002:a65:6188:: with SMTP id c8-v6mr10343161pgv.131.1525099596152; Mon, 30 Apr 2018 07:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525099596; cv=none; d=google.com; s=arc-20160816; b=tjngjXNCzAAr3HBXgjX3x5oMW2kOrMqbGRABXUNuTq1LqCaAodKraElky+rxEQjdWx OmriOZxDxXqKvQLUUjCBAZxYYe2s2Aw8G/HhDs1yyXasRra+vhvj8geJ/3by709Re+rb TOB96+smBnRLL+a+gXoOAkkUEMEYMJAbO87e1Y0vJXUWmXRrjh4U5GmCW3yBrOuqrJXc Q6GGHuMGtAf4Sl1Nm/KzO9r6A6iNLTXICjJinsHpnD3wvgllhINcjutm4tdVgdTxQziu sJyEc1uSD6ND1vpsDfVPYPCzxwtj4P1Fc71dAeUX72wkTNfzzAmBEsEGyphCBJtfZ1HL 7Sjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=ARB+PspY2oL9LRIOA0TzJvNUUX3jbW44Z+VpIhKjrMw=; b=remUYwBYGoxLhcEj6BisHgyilmm5kcqVjTcQ0RKD8g7M1oxE7hO+jifYmG7hNz399C NuYbXhJAcHaDAAwsOmY0H1yOCicxeYURSIX7/pQIv7XAPO9DMpUjZDCICus9PDUpnf9s O50GfU2P9SIoRmq/vEYlLKhD1hN89FTlSKX1sJUeAMKcUEy+YyFuL+RaFp17MphpmEs7 zedq1CHlJMUHGm3Ng6Y0VoBmXilORFzDokXyihslvuDI1LQHDXK3nIsL16LNdOPSWZrA tUHAPLPP9l3W/zLN3o4lw9tBrv7LGmFtr8UHYQwUe3c2FBPufB68SKKrXIsN/Yi4uVvC 5+pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Vfpcau7m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u3-v6si7710223plj.338.2018.04.30.07.46.21; Mon, 30 Apr 2018 07:46:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Vfpcau7m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754387AbeD3Oo6 (ORCPT + 99 others); Mon, 30 Apr 2018 10:44:58 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:54596 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754333AbeD3Ooy (ORCPT ); Mon, 30 Apr 2018 10:44:54 -0400 Received: by mail-wm0-f66.google.com with SMTP id f6so13614400wmc.4 for ; Mon, 30 Apr 2018 07:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ARB+PspY2oL9LRIOA0TzJvNUUX3jbW44Z+VpIhKjrMw=; b=Vfpcau7mKStxuG4nYyo4B+3vIySzflkTvMlF26T+7V/t2TIUo5otgnJEftA94cz5PK qhFoQrvWdfrKDaYZU+LXMZNfT0cg9QDF+QY0CUzkLwDN6HW3RqPPGCABGw22JyqUHVPP EGQ/UY0KrLDHLllC7aIxyfbxOvflfRonsTn0Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ARB+PspY2oL9LRIOA0TzJvNUUX3jbW44Z+VpIhKjrMw=; b=Ho2R1mQYGYJy6OO1iH4P+TDQD/q6hANGdqUmBhptrr2wQBtQ0OX5RjkxQ0KdGsKwzF WP02kE0lWSix3K3FQBKfS9NXKI46+qxO0jxJTlfTLIKGylE3GPi/EA79mDFEc6VvGVEg SnEFX74Yjk+5btY8WdVko/Exox0l+FPkLpo1QyqN9PkYPXF7iAjmH1kZJuLP9F1E16Co 8gar0FQwcC6258/Xq4LNaBmqmmor2xlYP9FNIL7Q2BZgV22WkxOTsECbNw2UO/ca6yxa 3muA2XVqRFDxUO/9krUR1ntomszQ4ZeyRHhG8jjvJ6x0gfPrZPt1rsn/Wej+A/IRSqIu 8rHA== X-Gm-Message-State: ALQs6tDj25gNNaeIRydwwHDXbU7ruVJid0PbY3UXOcE8eQ1Hs4ZysyDw yTV9UnLb3bHacqE7e0CL8vEcDw== X-Received: by 10.28.9.194 with SMTP id 185mr5710239wmj.53.1525099493307; Mon, 30 Apr 2018 07:44:53 -0700 (PDT) Received: from mai ([2a01:e35:879a:6cd0:3e97:eff:fe5b:1402]) by smtp.gmail.com with ESMTPSA id n79sm13136602wmi.20.2018.04.30.07.44.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Apr 2018 07:44:52 -0700 (PDT) Date: Mon, 30 Apr 2018 16:44:50 +0200 From: Daniel Lezcano To: Bartlomiej Zolnierkiewicz Cc: Eduardo Valentin , Zhang Rui , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/18] thermal: exynos: always check for critical trip points existence Message-ID: <20180430144450.GI11457@mai> References: <1524743493-28113-1-git-send-email-b.zolnierkie@samsung.com> <1524743493-28113-4-git-send-email-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1524743493-28113-4-git-send-email-b.zolnierkie@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 26, 2018 at 01:51:18PM +0200, Bartlomiej Zolnierkiewicz wrote: > * Check for critical trip point existence in exynos_tmu_initialize() > so it is checked on all SoCs (except Exynos5433 for now). Why "except Exynos5433" ? > * Use dev_err() instead of pr_err(). > > * Fix dev_err() to reference "device tree" not "of-thermal.c". > > * Remove no longer needed check from exynos4412_tmu_initialize(). > > Signed-off-by: Bartlomiej Zolnierkiewicz > ---